From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 5/8] drm/i915: Don't access to crtc->new_config from intel_mode_max_pixclk() Date: Mon, 15 Dec 2014 21:30:44 +0200 Message-ID: <20141215193044.GI10649@intel.com> References: <1418301491-23020-1-git-send-email-ander.conselvan.de.oliveira@intel.com> <1418301491-23020-6-git-send-email-ander.conselvan.de.oliveira@intel.com> <20141215191745.GE31948@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D74B6E5D7 for ; Mon, 15 Dec 2014 11:30:49 -0800 (PST) Content-Disposition: inline In-Reply-To: <20141215191745.GE31948@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: Ander Conselvan de Oliveira , intel-gfx@lists.freedesktop.org, shuang.he@linux.intel.com List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBEZWMgMTUsIDIwMTQgYXQgMTE6MTc6NDVBTSAtMDgwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBPbiBUaHUsIERlYyAxMSwgMjAxNCBhdCAwMjozODowOFBNICswMjAwLCBBbmRlciBDb25z ZWx2YW4gZGUgT2xpdmVpcmEgd3JvdGU6Cj4gPiBTbyB0aGF0IHdlIGNhbiBnZXQgcmlkIG9mIHRo ZSBuZXdfY29uZmlnIHBvaW50ZXIgbGF0ZXIuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IEFuZGVy IENvbnNlbHZhbiBkZSBPbGl2ZWlyYSA8YW5kZXIuY29uc2VsdmFuLmRlLm9saXZlaXJhQGludGVs LmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8 IDMwICsrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAy MiBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5jCj4gPiBpbmRleCBkYTVhZjIzLi5hOWYzMDM0IDEwMDY0NAo+ID4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IEBAIC00ODk3LDI3ICs0ODk3LDM5IEBA IHN0YXRpYyBpbnQgdmFsbGV5dmlld19jYWxjX2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiwKPiA+ICB9Cj4gPiAgCj4gPiAgLyogY29tcHV0ZSB0aGUgbWF4IHBpeGVsIGNs b2NrIGZvciBuZXcgY29uZmlndXJhdGlvbiAqLwo+ID4gLXN0YXRpYyBpbnQgaW50ZWxfbW9kZV9t YXhfcGl4Y2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICtzdGF0aWMg aW50IGludGVsX21vZGVfbWF4X3BpeGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYsCj4gPiArCQkJCSBzdHJ1Y3QgaW50ZWxfY3J0YyAqbW9kZV9zZXRfY3J0YywKPiAKPiBJJ20g bm90IHN1cmUgaWYgeW91IG5lZWQgdG8gcGFzcyB0aGlzLiAgZHJtX2NydGNfc3RhdGUgaGFzIGEg YmFja3BvaW50ZXIKPiB0byB0aGUgY29ycmVzcG9uZGluZyBkcm1fY3J0YyBub3csIHNvIGlmIHdl IGVuc3VyZSB0aGF0J3Mgc2V0IGJ5IG91cgo+IGRyaXZlciB3aGVuIGNyZWF0aW5nIGEgbmV3IHBp cGVfY29uZmlnLCB3ZSBjb3VsZCBwcm9iYWJseSBnZXQgYXdheSB3aXRoCj4ganVzdCBwYXNzaW5n IHRoZSBzdGF0ZSBoZXJlLgo+IAo+ID4gKwkJCQkgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNy dGNfbmV3X3N0YXRlKQo+ID4gIHsKPiA+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGRldl9w cml2LT5kZXY7Cj4gPiAgCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjOwo+ID4gIAlpbnQg bWF4X3BpeGNsayA9IDA7Cj4gPiArCWludCBwaXhjbGs7Cj4gPiAgCj4gPiAgCWZvcl9lYWNoX2lu dGVsX2NydGMoZGV2LCBpbnRlbF9jcnRjKSB7Cj4gPiAtCQlpZiAoaW50ZWxfY3J0Yy0+bmV3X2Vu YWJsZWQpCj4gPiAtCQkJbWF4X3BpeGNsayA9IG1heChtYXhfcGl4Y2xrLAo+ID4gLQkJCQkJIGlu dGVsX2NydGMtPm5ld19jb25maWctPmJhc2UuYWRqdXN0ZWRfbW9kZS5jcnRjX2Nsb2NrKTsKPiA+ ICsJCWlmICghaW50ZWxfY3J0Yy0+bmV3X2VuYWJsZWQpCj4gPiArCQkJY29udGludWU7Cj4gCj4g Tm90IHJlYWxseSByZWxhdGVkIHRvIHRoaXMgcGF0Y2ggc3BlY2lmaWNhbGx5LCBidXQgSSdtIGEg bGl0dGxlIGZ1enp5IG9uCj4gdGhlIGRpc3RpbmN0aW9uIGJldHdlZW4gZHJtX2NydGMtPmVuYWJs ZWQgYW5kIGRybV9jcnRjX3N0YXRlLT5lbmFibGUKPiAoYW5kIHRoZW4gYnkgZXh0ZW5zaW9uIGlu dGVsX2NydGMtPm5ld19lbmFibGVkKS4gIEl0J3Mgbm90IGltbWVkaWF0ZWx5Cj4gY2xlYXIgdG8g bWUgd2h5IHdlIGNhbid0IGp1c3QgaGF2ZSBhIHNpbmdsZSAnZW5hYmxlZCcgaW4gdGhlIGJhc2Ug c3RhdGUKPiBzdHJ1Y3R1cmUgYW5kIHRoZW4gd2hlbiB3ZSBoYXZlIGEgbmV3IGNvbmZpZyB0aGF0 IHdlJ3JlIHBhc3NpbmcgYXJvdW5kLAo+IHRoZSBlbmFibGVkIGZsYWcgaW4gdGhhdCBzdHJ1Y3R1 cmUgd291bGQgc2VydmUgdGhlIHB1cnBvc2UgdGhhdAo+IGludGVsX2NydGMtPm5ld19lbmFibGVk IGRvZXMgZm9yIGk5MTUgdG9kYXkuICBJJ20gcHJvYmFibHkKPiBtaXN1bmRlcnN0YW5kaW5nIHNv bWV0aGluZy4KClllYWggdGhhdCBzb3VuZHMgbGlrZSB3aGVyZSB3ZSB3YW50IHRvIGdvLiBObyBt b3JlIHJhbmRvbSBiaXRzIG9mCnN0YXRlIHNwcmlua2xlZCBhbGwgb3ZlciB0aGUgcGxhY2UsIGFu ZCBpbnN0ZWFkIGhhdmUgaXQgYWxsIG5lYXRseQpjb2xsZWN0ZWQgaW4gdGhlIHN0YXRlIHN0cnVj dC4KCj4gCj4gCj4gTWF0dAo+IAo+ID4gKwo+ID4gKwkJaWYgKGludGVsX2NydGMgPT0gbW9kZV9z ZXRfY3J0YykKPiA+ICsJCQlwaXhjbGsgPSBjcnRjX25ld19zdGF0ZS0+YmFzZS5hZGp1c3RlZF9t b2RlLmNydGNfY2xvY2s7Cj4gPiArCQllbHNlCj4gPiArCQkJcGl4Y2xrID0gaW50ZWxfY3J0Yy0+ Y29uZmlnLT5iYXNlLmFkanVzdGVkX21vZGUuY3J0Y19jbG9jazsKPiA+ICsKPiA+ICsJCW1heF9w aXhjbGsgPSBtYXgobWF4X3BpeGNsaywgcGl4Y2xrKTsKPiA+ICAJfQo+ID4gIAo+ID4gIAlyZXR1 cm4gbWF4X3BpeGNsazsKPiA+ICB9Cj4gPiAgCj4gPiAgc3RhdGljIHZvaWQgdmFsbGV5dmlld19t b2Rlc2V0X2dsb2JhbF9waXBlcyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4gLQkJCQkJICAg IHVuc2lnbmVkICpwcmVwYXJlX3BpcGVzKQo+ID4gKwkJCQkJICAgIHVuc2lnbmVkICpwcmVwYXJl X3BpcGVzLAo+ID4gKwkJCQkJICAgIHN0cnVjdCBpbnRlbF9jcnRjICptb2RlX3NldF9jcnRjLAo+ ID4gKwkJCQkJICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX25ld19zdGF0ZSkKPiA+ ICB7Cj4gPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3By aXZhdGU7Cj4gPiAgCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjOwo+ID4gLQlpbnQgbWF4 X3BpeGNsayA9IGludGVsX21vZGVfbWF4X3BpeGNsayhkZXZfcHJpdik7Cj4gPiArCWludCBtYXhf cGl4Y2xrID0KPiA+ICsJCWludGVsX21vZGVfbWF4X3BpeGNsayhkZXZfcHJpdiwgbW9kZV9zZXRf Y3J0YywgY3J0Y19uZXdfc3RhdGUpOwo+ID4gIAo+ID4gIAlpZiAodmFsbGV5dmlld19jYWxjX2Nk Y2xrKGRldl9wcml2LCBtYXhfcGl4Y2xrKSA9PQo+ID4gIAkgICAgZGV2X3ByaXYtPnZsdl9jZGNs a19mcmVxKQo+ID4gQEAgLTQ5MzIsNyArNDk0NCw3IEBAIHN0YXRpYyB2b2lkIHZhbGxleXZpZXdf bW9kZXNldF9nbG9iYWxfcGlwZXMoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ICBzdGF0aWMg dm9pZCB2YWxsZXl2aWV3X21vZGVzZXRfZ2xvYmFsX3Jlc291cmNlcyhzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2KQo+ID4gIHsKPiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0g ZGV2LT5kZXZfcHJpdmF0ZTsKPiA+IC0JaW50IG1heF9waXhjbGsgPSBpbnRlbF9tb2RlX21heF9w aXhjbGsoZGV2X3ByaXYpOwo+ID4gKwlpbnQgbWF4X3BpeGNsayA9IGludGVsX21vZGVfbWF4X3Bp eGNsayhkZXZfcHJpdiwgTlVMTCwgTlVMTCk7Cj4gPiAgCWludCByZXFfY2RjbGsgPSB2YWxsZXl2 aWV3X2NhbGNfY2RjbGsoZGV2X3ByaXYsIG1heF9waXhjbGspOwo+ID4gIAo+ID4gIAlpZiAocmVx X2NkY2xrICE9IGRldl9wcml2LT52bHZfY2RjbGtfZnJlcSkgewo+ID4gQEAgLTEwOTU2LDcgKzEw OTY4LDkgQEAgc3RhdGljIGludCBfX2ludGVsX3NldF9tb2RlKHN0cnVjdCBkcm1fY3J0YyAqY3J0 YywKPiA+ICAJICogYWRqdXN0ZWRfbW9kZSBiaXRzIGluIHRoZSBjcnRjIGRpcmVjdGx5Lgo+ID4g IAkgKi8KPiA+ICAJaWYgKElTX1ZBTExFWVZJRVcoZGV2KSkgewo+ID4gLQkJdmFsbGV5dmlld19t b2Rlc2V0X2dsb2JhbF9waXBlcyhkZXYsICZwcmVwYXJlX3BpcGVzKTsKPiA+ICsJCXZhbGxleXZp ZXdfbW9kZXNldF9nbG9iYWxfcGlwZXMoZGV2LCAmcHJlcGFyZV9waXBlcywKPiA+ICsJCQkJCQl0 b19pbnRlbF9jcnRjKGNydGMpLAo+ID4gKwkJCQkJCXBpcGVfY29uZmlnKTsKPiA+ICAKPiA+ICAJ CS8qIG1heSBoYXZlIGFkZGVkIG1vcmUgdG8gcHJlcGFyZV9waXBlcyB0aGFuIHdlIHNob3VsZCAq Lwo+ID4gIAkJcHJlcGFyZV9waXBlcyAmPSB+ZGlzYWJsZV9waXBlczsKPiA+IC0tIAo+ID4gMS45 LjEKPiA+IAo+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KPiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKPiA+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngKPiAKPiAtLSAKPiBNYXR0IFJvcGVyCj4gR3JhcGhpY3MgU29mdHdhcmUgRW5n aW5lZXIKPiBJb1RHIFBsYXRmb3JtIEVuYWJsaW5nICYgRGV2ZWxvcG1lbnQKPiBJbnRlbCBDb3Jw b3JhdGlvbgo+ICg5MTYpIDM1Ni0yNzk1Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==