public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Vandana Kannan <vandana.kannan@intel.com>
Cc: intel-gfx@lists.freedesktop.org, paulo.r.zanoni@intel.com,
	rodrigo.vivi@intel.com
Subject: Re: [PATCH v2 0/8] eDP DRRS based on frontbuffer tracking
Date: Thu, 18 Dec 2014 21:15:07 +0100	[thread overview]
Message-ID: <20141218201507.GP2711@phenom.ffwll.local> (raw)
In-Reply-To: <1418916741-31452-1-git-send-email-vandana.kannan@intel.com>

On Thu, Dec 18, 2014 at 09:02:14PM +0530, Vandana Kannan wrote:
> This patch series inserts DRRS into frontbuffer tracking mechanism.
> 
> 1. Previous submission for this feature was designed considering only eDP
> DRRS. In this series, apart from following fb tracking, changes have been made
> to make structures generic so that it can be of use to any other code
> addition to support DRRS with other display types.
> 2. DRRS support is checked based on VBT setting and panel's capability (if
> more than one RR is supported).
> 3. Based on DRRS support availability, related structures are initialized or
> cleaned up through calls from enable/disable DDI respectively.
> 4. Since flip() indicates busyness, changes have been made to invalidate
> DRRS during flip. This changes RR back to preferred mode RR. New work to set
> low RR is scheduled after a delay of 1 second.
> 5. This series includes patches to support RR switching on all platforms.
> 
> v2: As discussed with Daniel, discarding the patch which added a module
> param to specify the delay before entering DRRS. This delay has been fixed
> to 1 second.
> The call to invalidate DRRS from page_flip still remains - will be 
> changed (or kept as is) depending on the behavior on Android..
> Right now testing is done using vbltest in libdrm.. But i-g-t for DRRS is WIP.

Really please remove these two hunks in the pageflip code because:
- the frontbuffer tracking code _does_ flush on flips
- you're just moving moving the call around in the same function, that
  doesn't have any effect.

Or maybe I'm blind, but then you need to explain what exactly changes in
perceived behaviour.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2014-12-18 20:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-18 15:32 [PATCH v2 0/8] eDP DRRS based on frontbuffer tracking Vandana Kannan
2014-12-18 15:32 ` [PATCH 1/7] drm/i915: Modifying structures related to DRRS Vandana Kannan
2014-12-18 16:29   ` Chris Wilson
2014-12-18 20:13     ` Daniel Vetter
2014-12-18 15:32 ` [PATCH 2/7] drm/i915: Initialize DRRS delayed work Vandana Kannan
2014-12-18 15:32 ` [PATCH 3/7] drm/i915: Enable/disable DRRS Vandana Kannan
2014-12-18 15:32 ` [PATCH 4/7] drm/i915: DRRS calls based on frontbuffer Vandana Kannan
2014-12-18 20:15   ` Daniel Vetter
2014-12-18 15:32 ` [PATCH 5/7] drm/i915/bdw: Add support for DRRS to switch RR Vandana Kannan
2014-12-18 15:32 ` [PATCH 6/7] drm/i915: Support for RR switching on VLV Vandana Kannan
2014-12-18 15:32 ` [PATCH 7/7] drm/i915: Enable eDP DRRS for CHV Vandana Kannan
2014-12-19  9:42   ` shuang.he
2014-12-18 20:15 ` Daniel Vetter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141218201507.GP2711@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=vandana.kannan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox