Re: [PATCH 03/24] drm/i915: Rename to GEN8_LEGACY_PDPES

[Daniel Vetter <daniel@ffwll.ch>]

On Thu, Dec 18, 2014 at 09:40:51PM +0100, Daniel Vetter wrote:
> On Thu, Dec 18, 2014 at 05:10:00PM +0000, Michel Thierry wrote:
> > From: Ben Widawsky <benjamin.widawsky@intel.com>
> > 
> > In gen8, 32b PPGTT has always had one "pdp" (it doesn't actually have
> > one, but it resembles having one). The #define was confusing as is, and
> > using "PDPE" is a much better description.
> > 
> > sed -i 's/GEN8_LEGACY_PDPS/GEN8_LEGACY_PDPES/' drivers/gpu/drm/i915/*.[ch]
> 
> Hm generally I've thought the abbreviations are pdp (for the page itself)
> and pde (for the entries within). I still have no idea what pdpe means ...
> 
> So either please explain that or pick one of the others.

In case you fear the rebase pain of renaming this:

1. Export entire series as patches with git format-patch.
2. sed -e 's/PDPE/PDE/g' on all the patch files
3. Import the changed patches into a new fresh branch.'

That's all. Feels really crazy the first time you do it, but after having
done this a lot with the internal branch when something random (function
name or so) changed in upstream it's a fairly simple trick to pull off ;-)

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx