From: Daniel Vetter <daniel@ffwll.ch>
To: Bob Paauwe <bob.j.paauwe@intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>, danh@ghs.com
Subject: Re: [PATCH] igt: Test tiled bo for proper fence.
Date: Fri, 19 Dec 2014 09:49:15 +0100 [thread overview]
Message-ID: <20141219084915.GF2711@phenom.ffwll.local> (raw)
In-Reply-To: <20141218144345.60b58fa9@bpaauwe-desk.fm.intel.com>
On Thu, Dec 18, 2014 at 02:43:45PM -0800, Bob Paauwe wrote:
> On Thu, 18 Dec 2014 21:31:43 +0100
> Daniel Vetter <daniel@ffwll.ch> wrote:
>
> > On Thu, Dec 18, 2014 at 09:50:27AM -0800, Bob Paauwe wrote:
> > > +
> > > + /* Set the tiled buffer to all 0xff's */
> > > + memset(bo_tiled->virtual, 0xff, bo_tiled->size);
> > > + memset(bo_tiled->virtual, 0xdd, pitch * height);
> > > +
> > > + /* Verify linear buffer is still all 0's by looking for a 0xff */
> > > + if (memchr(bo_linear->virtual, 0xff, bo_linear->size) != NULL)
> > > + failed = 1;
> >
> > Imo just igt_assert here and reduce all the control flow.
>
> So it's ok to skip all the unref / unmap when the test fails?
Totally. The kernel will clean up the mess for you, and being able to do
that is why we run each test as its own binary. It also helps a lot in
streamlining the testlogic by removing and control-flow which isn't part
of the test itself.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2014-12-19 8:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 17:50 [PATCH] igt: Test tiled bo for proper fence Bob Paauwe
2014-12-18 20:31 ` Daniel Vetter
2014-12-18 22:43 ` Bob Paauwe
2014-12-19 8:49 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141219084915.GF2711@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=bob.j.paauwe@intel.com \
--cc=danh@ghs.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox