From: Daniel Vetter <daniel@ffwll.ch>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 1/2] drm/i915: gen9: fix RPS interrupt routing to CPU vs. GT
Date: Fri, 19 Dec 2014 14:31:31 +0100 [thread overview]
Message-ID: <20141219133131.GL2711@phenom.ffwll.local> (raw)
In-Reply-To: <1418993517-9324-1-git-send-email-imre.deak@intel.com>
On Fri, Dec 19, 2014 at 02:51:56PM +0200, Imre Deak wrote:
> GEN8+ HW has the option to route PM interrupts to either the CPU or to
> GT. For GEN8 this was already set correctly to routing to CPU, but not
> for GEN9, so fix this. Note that when disabling RPS interrupts this was
> set already correctly, though in that case it didn't matter much except
> for the possibility of spurious interrupts.
>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index a3ebaa8..f1f06d7 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -3751,7 +3751,7 @@ static u32 gen6_rps_pm_mask(struct drm_i915_private *dev_priv, u8 val)
> if (INTEL_INFO(dev_priv->dev)->gen <= 7 && !IS_HASWELL(dev_priv->dev))
> mask |= GEN6_PM_RP_UP_EI_EXPIRED;
>
> - if (IS_GEN8(dev_priv->dev))
> + if (INTEL_INFO(dev_priv)->gen >= 8)
> mask |= GEN8_PMINTR_REDIRECT_TO_NON_DISP;
>
> return ~mask;
> --
> 1.8.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2014-12-19 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 12:51 [PATCH v2 1/2] drm/i915: gen9: fix RPS interrupt routing to CPU vs. GT Imre Deak
2014-12-19 12:51 ` [PATCH v2 2/2] drm/i915: fix HW lockup due to missing RPS IRQ workaround on GEN6 Imre Deak
2014-12-19 13:41 ` Daniel Vetter
2014-12-19 14:07 ` Imre Deak
2014-12-19 13:31 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141219133131.GL2711@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox