From: Daniel Vetter <daniel@ffwll.ch>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] drm/i915/skl: Enabling PSR on Skylake
Date: Wed, 21 Jan 2015 09:37:09 +0100 [thread overview]
Message-ID: <20150121083708.GD10113@phenom.ffwll.local> (raw)
In-Reply-To: <CABVU7+tGe5er9f0Xdcj8aFE8RT46Ngsga0-mcQzwTVg3OF+3=A@mail.gmail.com>
On Tue, Jan 20, 2015 at 02:01:25PM -0800, Rodrigo Vivi wrote:
> Hi Sonika, for the login screen my guess is that blinking cursor
> waiting for password blocks psr entry.
>
> For test cases I started the test case enhancement but my psr work is
> paused this month for bug maintainance. Any help is welcome.
> I was planing also to take a look on new Paulo's fbc tests cases to
> see if we could use some pieces on PSR validation. might be worth to
> take a look.
>
> But anyway, for HW tracking I would only consider when I use a KDE for
> a while without missing any screen updates and seeing perf counter
> increasing. But if you tell this is what happening I trust you and we
> can add support for that since it is disabled by default and validate
> that carefully also on SKL when trying to enable it by default
> everywhere.
I'm definitely leaning the other way: Before we take out the sw tracking
for some platforms I want the full psr validation to be done (since
otherwise no one will do it again and for skl+1 we have the same hilarious
saga again). And if we figure out that the hw tracking has indeed become
better and is now useful, then we can do the same thing like Paulo's fbc
patches and ignore some sw invalidate events selectively. But only when
the tests are solid, we're sure we have full coverage and that the hw
really works for that use-case.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-01-21 8:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 8:37 [PATCH] drm/i915/skl: Enabling PSR on Skylake Sonika Jindal
2015-01-16 15:06 ` shuang.he
2015-01-17 4:24 ` Daniel Vetter
2015-01-19 11:40 ` sonika
2015-01-20 9:50 ` Daniel Vetter
2015-01-20 11:49 ` Jindal, Sonika
2015-01-20 22:01 ` Rodrigo Vivi
2015-01-21 4:53 ` sonika
2015-01-21 8:37 ` Daniel Vetter [this message]
2015-01-21 8:55 ` sonika
2015-01-21 9:42 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2015-01-22 9:00 Sonika Jindal
2015-01-22 17:48 ` shuang.he
2015-01-28 16:02 ` Daniel Vetter
2015-01-29 3:57 ` sonika
2015-01-29 16:11 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150121083708.GD10113@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@gmail.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox