From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Quietly reject attempts to create non-pagealigned stolen objects Date: Wed, 21 Jan 2015 19:13:04 +0100 Message-ID: <20150121181304.GQ10113@phenom.ffwll.local> References: <1418199431-5293-1-git-send-email-chris@chris-wilson.co.uk> <20141210102344.GM27182@phenom.ffwll.local> <874mrk58pu.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C22A6E754 for ; Wed, 21 Jan 2015 10:13:09 -0800 (PST) Received: by mail-we0-f182.google.com with SMTP id l61so19390123wev.13 for ; Wed, 21 Jan 2015 10:13:08 -0800 (PST) Content-Disposition: inline In-Reply-To: <874mrk58pu.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKYW4gMjEsIDIwMTUgYXQgMDc6NDU6MDFQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gV2VkLCAxMCBEZWMgMjAxNCwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNo PiB3cm90ZToKPiA+IE9uIFdlZCwgRGVjIDEwLCAyMDE0IGF0IDA4OjE3OjExQU0gKzAwMDAsIENo cmlzIFdpbHNvbiB3cm90ZToKPiA+PiBUaGlzIGFkZGVkIGFzIGEgQlVHX09OIGFzIGl0IGNvbnNp ZGVyZWQgdGhhdCBubyBvbmUgd291bGQgZXZlciByZXF1ZXN0Cj4gPj4gYW4gdW5hbGlnbmVkIG9i amVjdC4gSG93ZXZlciwgaXQgdHVybnMgb3V0IHRoYXQgc29tZSBCSU9TZXMgd2lsbAo+ID4+IGFs bG9jYXRlIGEgc2Nhbm91dCB0aGF0IGlzIG9mZnNldCBmcm9tIDAgYW5kIG5vdCBhbGlnbmVkIHRv IGEgcGFnZQo+ID4+IGJvdW5kYXJ5LCBhbmQgd2Ugd2VyZSBwYXNzaW5nIHRoaXMgdGhyb3VnaCBh bmQgaGl0dGluZyB0aGUgQlVHX09OIGR1cmluZwo+ID4+IGJvb3QuCj4gPj4gCj4gPj4gUXVpZXRs eSByZWplY3Qgc3VjaCBhIHJlcXVlc3QgdG8gcmVzZXJ2ZSB0aGUgdW5hbGlnbmVkIHN0b2xlbiBv YmplY3QgYW5kCj4gPj4gbGV0IHRoZSBib290IGNvbnRpbnVlLCByZXN0b3JpbmcgcHJldmlvdXMg YmVoYXZpb3VyIChpLmUuIG5vIEJJT1MKPiA+PiBmcmFtZWJ1ZmZlciBwcmVzZXJ2YXRpb24pLgo+ ID4+IAo+ID4+IEJ1Z3ppbGxhOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVn LmNnaT9pZD04Njg4Mwo+ID4+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hy aXMtd2lsc29uLmNvLnVrPgo+ID4+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnCj4gPj4gLS0t Cj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3N0b2xlbi5jIHwgMTAgKysrKysr LS0tLQo+ID4+ICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygt KQo+ID4+IAo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9z dG9sZW4uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3N0b2xlbi5jCj4gPj4gaW5k ZXggNWM2MTZlYzJjNWM4Li5hM2JjMGZhMDdjNmMgMTAwNjQ0Cj4gPj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9nZW1fc3RvbGVuLmMKPiA+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2dlbV9zdG9sZW4uYwo+ID4+IEBAIC02NDYsMTMgKzY0NiwxNSBAQCBpOTE1X2dl bV9vYmplY3RfY3JlYXRlX3N0b2xlbl9mb3JfcHJlYWxsb2NhdGVkKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYsCj4gPj4gIAlEUk1fREVCVUdfS01TKCJjcmVhdGluZyBwcmVhbGxvY2F0ZWQgc3RvbGVu IG9iamVjdDogc3RvbGVuX29mZnNldD0leCwgZ3R0X29mZnNldD0leCwgc2l6ZT0leFxuIiwKPiA+ PiAgCQkJc3RvbGVuX29mZnNldCwgZ3R0X29mZnNldCwgc2l6ZSk7Cj4gPj4gIAo+ID4+IC0JLyog S0lTUyBhbmQgZXhwZWN0IGV2ZXJ5dGhpbmcgdG8gYmUgcGFnZS1hbGlnbmVkICovCj4gPj4gLQlC VUdfT04oc3RvbGVuX29mZnNldCAmIDQwOTUpOwo+ID4+IC0JQlVHX09OKHNpemUgJiA0MDk1KTsK PiA+PiAtCj4gPj4gIAlpZiAoV0FSTl9PTihzaXplID09IDApKQo+ID4+ICAJCXJldHVybiBOVUxM Owo+ID4+ICAKPiA+PiArCS8qIEtJU1MgYW5kIGV4cGVjdCBldmVyeXRoaW5nIHRvIGJlIEdUVCBw YWdlLWFsaWduZWQgKi8KPiA+PiArCWlmICgoc3RvbGVuX29mZnNldCB8IHNpemUpICYgNDA5NSkg ewo+ID4KPiA+IEltbyB3ZSBzaG91bGQgc3RpbCBXQVJOX09OIGFuZCBmaXh1cCB1cCB0aGUgdGFr ZW92ZXIgY29kZSB0byBhbGlnbiB0aGluZ3MKPiA+IHByb3Blcmx5IC4uLgo+IAo+IENhbiB3ZSBm aXggdGhlIHJlZ3Jlc3Npb24gd2l0aCBDaHJpcycgcGF0Y2ggYW5kIGRvIHByb3BlciBzdHVmZiB3 aGVuIHdlCj4gZmlndXJlIG91dCB3aGF0IHdlIHdhbnQgdG8gZG8/CgpTb21ldGhpbmcgbGlrZSB0 aGUgYmVsb3cgd291bGQgaW1vIGJlIHRoZSBwcm9wZXIgYmFuZGFpZC4gVW50ZXN0ZWQgc2luY2Ug SQpkb24ndCBoYXZlIGFuIGFmZmVjdGVkIHN5c3RlbS4gVGhlbiB3ZSBjYW4gc3RpbGwgKGxhdGVy IG9uLCBpZiBib3JlZCkKcmVjb3ZlciB0aGUgb2Zmc2V0cyBwcm9wZXJseSBpZiBldmVyIG5lZWRl ZC4KLURhbmllbAoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3N0 b2xlbi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fc3RvbGVuLmMKaW5kZXggYTIw NDU4NDhiZDFhLi5mNzViZjI5MjI4NWQgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtX3N0b2xlbi5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3N0 b2xlbi5jCkBAIC00ODUsMTAgKzQ4NSw3IEBAIGk5MTVfZ2VtX29iamVjdF9jcmVhdGVfc3RvbGVu X2Zvcl9wcmVhbGxvY2F0ZWQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKIAkJCXN0b2xlbl9vZmZz ZXQsIGd0dF9vZmZzZXQsIHNpemUpOwogCiAJLyogS0lTUyBhbmQgZXhwZWN0IGV2ZXJ5dGhpbmcg dG8gYmUgcGFnZS1hbGlnbmVkICovCi0JQlVHX09OKHN0b2xlbl9vZmZzZXQgJiA0MDk1KTsKLQlC VUdfT04oc2l6ZSAmIDQwOTUpOwotCi0JaWYgKFdBUk5fT04oc2l6ZSA9PSAwKSkKKwlpZiAoV0FS Tl9PTihzaXplID09IDAgfHwgc3RvbGVuX29mZnNldCAmIDQwOTUgfHwgc2l6ZSAmIDQwOTUpKQog CQlyZXR1cm4gTlVMTDsKIAogCXN0b2xlbiA9IGt6YWxsb2Moc2l6ZW9mKCpzdG9sZW4pLCBHRlBf S0VSTkVMKTsKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXku YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwppbmRleCA4NjgzMWFlYzVj MGQuLjczM2M5OWQ1YjY3MSAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwpAQCAt MjM3MCwxMyArMjM3MCwxNyBAQCBpbnRlbF9hbGxvY19wbGFuZV9vYmooc3RydWN0IGludGVsX2Ny dGMgKmNydGMsCiAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNydGMtPmJhc2UuZGV2OwogCXN0 cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmogPSBOVUxMOwogCXN0cnVjdCBkcm1fbW9kZV9m Yl9jbWQyIG1vZGVfY21kID0geyAwIH07Ci0JdTMyIGJhc2UgPSBwbGFuZV9jb25maWctPmJhc2U7 CisJdTMyIGJhc2VfYWxpZ25lZCA9IHJvdW5kX2Rvd24ocGxhbmVfY29uZmlnLT5iYXNlLCBQQUdF X1NJWkUpOworCXUzMiBzaXplX2FsaWduZWQgPSByb3VuZF91cChwbGFuZV9jb25maWctPmJhc2Ug KyBwbGFuZV9jb25maWctPnNpemUsCisJCQkJICAgIFBBR0VfU0laRSk7CiAKIAlpZiAocGxhbmVf Y29uZmlnLT5zaXplID09IDApCiAJCXJldHVybiBmYWxzZTsKIAotCW9iaiA9IGk5MTVfZ2VtX29i amVjdF9jcmVhdGVfc3RvbGVuX2Zvcl9wcmVhbGxvY2F0ZWQoZGV2LCBiYXNlLCBiYXNlLAotCQkJ CQkJCSAgICAgcGxhbmVfY29uZmlnLT5zaXplKTsKKwlvYmogPSBpOTE1X2dlbV9vYmplY3RfY3Jl YXRlX3N0b2xlbl9mb3JfcHJlYWxsb2NhdGVkKGRldiwKKwkJCQkJCQkgICAgIGJhc2VfYWxpZ25l ZCwKKwkJCQkJCQkgICAgIGJhc2VfYWxpZ25lZCwKKwkJCQkJCQkgICAgIHNpemVfYWxpZ25lZCk7 CiAJaWYgKCFvYmopCiAJCXJldHVybiBmYWxzZTsKIApAQCAtNjYyNiw3ICs2NjMwLDcgQEAgaTl4 eF9nZXRfaW5pdGlhbF9wbGFuZV9jb25maWcoc3RydWN0IGludGVsX2NydGMgKmNydGMsCiAJYWxp Z25lZF9oZWlnaHQgPSBpbnRlbF9mYl9hbGlnbl9oZWlnaHQoZGV2LCBmYi0+aGVpZ2h0LAogCQkJ CQkgICAgICAgcGxhbmVfY29uZmlnLT50aWxpbmcpOwogCi0JcGxhbmVfY29uZmlnLT5zaXplID0g UEFHRV9BTElHTihmYi0+cGl0Y2hlc1swXSAqIGFsaWduZWRfaGVpZ2h0KTsKKwlwbGFuZV9jb25m aWctPnNpemUgPSBmYi0+cGl0Y2hlc1swXSAqIGFsaWduZWRfaGVpZ2h0OwogCiAJRFJNX0RFQlVH X0tNUygicGlwZS9wbGFuZSAlYy8lZCB3aXRoIGZiOiBzaXplPSVkeCVkQCVkLCBvZmZzZXQ9JXgs IHBpdGNoICVkLCBzaXplIDB4JXhcbiIsCiAJCSAgICAgIHBpcGVfbmFtZShwaXBlKSwgcGxhbmUs IGZiLT53aWR0aCwgZmItPmhlaWdodCwKQEAgLTc2NjMsNyArNzY2Nyw3IEBAIHNreWxha2VfZ2V0 X2luaXRpYWxfcGxhbmVfY29uZmlnKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAogCWFsaWduZWRf aGVpZ2h0ID0gaW50ZWxfZmJfYWxpZ25faGVpZ2h0KGRldiwgZmItPmhlaWdodCwKIAkJCQkJICAg ICAgIHBsYW5lX2NvbmZpZy0+dGlsaW5nKTsKIAotCXBsYW5lX2NvbmZpZy0+c2l6ZSA9IEFMSUdO KGZiLT5waXRjaGVzWzBdICogYWxpZ25lZF9oZWlnaHQsIFBBR0VfU0laRSk7CisJcGxhbmVfY29u ZmlnLT5zaXplID0gZmItPnBpdGNoZXNbMF0gKiBhbGlnbmVkX2hlaWdodCwgUEFHRV9TSVpFOwog CiAJRFJNX0RFQlVHX0tNUygicGlwZSAlYyB3aXRoIGZiOiBzaXplPSVkeCVkQCVkLCBvZmZzZXQ9 JXgsIHBpdGNoICVkLCBzaXplIDB4JXhcbiIsCiAJCSAgICAgIHBpcGVfbmFtZShwaXBlKSwgZmIt PndpZHRoLCBmYi0+aGVpZ2h0LApAQCAtNzc1NCw3ICs3NzU4LDcgQEAgaXJvbmxha2VfZ2V0X2lu aXRpYWxfcGxhbmVfY29uZmlnKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAogCWFsaWduZWRfaGVp Z2h0ID0gaW50ZWxfZmJfYWxpZ25faGVpZ2h0KGRldiwgZmItPmhlaWdodCwKIAkJCQkJICAgICAg IHBsYW5lX2NvbmZpZy0+dGlsaW5nKTsKIAotCXBsYW5lX2NvbmZpZy0+c2l6ZSA9IFBBR0VfQUxJ R04oZmItPnBpdGNoZXNbMF0gKiBhbGlnbmVkX2hlaWdodCk7CisJcGxhbmVfY29uZmlnLT5zaXpl ID0gZmItPnBpdGNoZXNbMF0gKiBhbGlnbmVkX2hlaWdodDsKIAogCURSTV9ERUJVR19LTVMoInBp cGUgJWMgd2l0aCBmYjogc2l6ZT0lZHglZEAlZCwgb2Zmc2V0PSV4LCBwaXRjaCAlZCwgc2l6ZSAw eCV4XG4iLAogCQkgICAgICBwaXBlX25hbWUocGlwZSksIGZiLT53aWR0aCwgZmItPmhlaWdodCwK LS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCis0 MSAoMCkgNzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK