From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Paulo Zanoni <paulo.r.zanoni@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] drm/i915: Fix and clean BDW PCH identification
Date: Thu, 22 Jan 2015 07:15:15 +0100 [thread overview]
Message-ID: <20150122061515.GR10113@phenom.ffwll.local> (raw)
In-Reply-To: <87vbk03rlp.fsf@intel.com>
On Wed, Jan 21, 2015 at 08:40:02PM +0200, Jani Nikula wrote:
> On Wed, 21 Jan 2015, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> > It seems in the past we have BDW with PCH not been propperly identified
> > and we force it to be LPT and we were warning !IS_HASWELL on propper identification.
> >
> > Now that products are out there we are receiveing logs with this incorrect WARN.
> > And also according to local tests on all production BDW here ULT or HALO we don't
> > need this force anymore. So let's clean this block for real.
> >
> > v2: Fix LPT_LP WARNs to avoid wrong warns on BDW_ULT (By Jani).
> >
> > Reference: https://bugs.freedesktop.org/attachment.cgi?id=110972
> >
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > Cc: Xion Zhang <xiong.y.zhang@intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> With the caveat that I have no idea how common the early pre-release
> Broadwells that do *not* have proper pch identification are,
Generally we throw out all preproduction hacks once production machines
are widely available. Which is the case now for bdw, so imo no concern.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-01-22 6:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 18:18 [PATCH] drm/i915: Fix and clean BDW PCH identification Rodrigo Vivi
2015-01-21 3:08 ` shuang.he
2015-01-21 16:08 ` Jani Nikula
2015-01-21 16:45 ` Rodrigo Vivi
2015-01-21 17:22 ` Jani Nikula
2015-01-21 18:33 ` Rodrigo Vivi
2015-01-21 18:40 ` Jani Nikula
2015-01-22 6:15 ` Daniel Vetter [this message]
2015-01-21 19:12 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150122061515.GR10113@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=paulo.r.zanoni@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox