From: Daniel Vetter <daniel@ffwll.ch>
To: "Siluvery, Arun" <arun.siluvery@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/4] drm/i915: Implement Wa4x4STCOptimizationDisable:chv
Date: Thu, 22 Jan 2015 07:16:21 +0100 [thread overview]
Message-ID: <20150122061621.GS10113@phenom.ffwll.local> (raw)
In-Reply-To: <54BFF501.4060407@linux.intel.com>
On Wed, Jan 21, 2015 at 06:50:41PM +0000, Siluvery, Arun wrote:
> On 21/01/2015 17:37, ville.syrjala@linux.intel.com wrote:
> >From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> >Wa4x4STCOptimizationDisable got only implemented for BDW, but according
> >to the w/a database CHV needs it too, so add it.
> >
> >Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >---
> > drivers/gpu/drm/i915/intel_ringbuffer.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> >diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> >index d7aa5c4..2a1a178 100644
> >--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> >+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> >@@ -851,6 +851,10 @@ static int chv_init_workarounds(struct intel_engine_cs *ring)
> > */
> > WA_CLR_BIT_MASKED(CACHE_MODE_0_GEN7, HIZ_RAW_STALL_OPT_DISABLE);
> >
> >+ /* Wa4x4STCOptimizationDisable:chv */
> >+ WA_SET_BIT_MASKED(CACHE_MODE_1,
> >+ GEN8_4x4_STC_OPTIMIZATION_DISABLE);
> >+
> > /* Improve HiZ throughput on CHV. */
> > WA_SET_BIT_MASKED(HIZ_CHICKEN, CHV_HZ_8X8_MODE_IN_1X);
> >
> >
> Looks good to me.
> only tested Wa4x4STCOptimizationDisable on Android, no issues observed.
>
> For the whole series,
> Reviewed-by: Arun Siluvery <arun.siluvery@linux.intel.com>
All merged, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-01-22 6:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 17:37 [PATCH 1/4] drm/i915: Implement Wa4x4STCOptimizationDisable:chv ville.syrjala
2015-01-21 17:37 ` [PATCH 2/4] drm/i915: Drop some more CHV pre-production workarounds ville.syrjala
2015-01-21 17:38 ` [PATCH 3/4] drm/i915: Change CHV WIZ hashing mode to 16x4 ville.syrjala
2015-01-21 17:38 ` [PATCH 4/4] drm/i915: Change VLV " ville.syrjala
2015-01-21 18:50 ` [PATCH 1/4] drm/i915: Implement Wa4x4STCOptimizationDisable:chv Siluvery, Arun
2015-01-22 6:16 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150122061621.GS10113@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=arun.siluvery@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox