From: Thierry Reding <thierry.reding@gmail.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/atomic: Add drm_crtc_state->active
Date: Thu, 22 Jan 2015 10:03:08 +0100 [thread overview]
Message-ID: <20150122090307.GB30706@ulmo> (raw)
In-Reply-To: <1421910273-26495-1-git-send-email-daniel.vetter@ffwll.ch>
[-- Attachment #1.1: Type: text/plain, Size: 845 bytes --]
On Thu, Jan 22, 2015 at 08:04:33AM +0100, Daniel Vetter wrote:
[...]
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
[...]
> @@ -1391,6 +1395,12 @@ static int drm_mode_create_standard_properties(struct drm_device *dev)
> return -ENOMEM;
> dev->mode_config.prop_crtc_id = prop;
>
> + prop = drm_property_create_bool(dev, DRM_MODE_PROP_ATOMIC,
> + "ACTIVE");
We seem to have a weird mix of property names. Some are all caps, others
all lowercase. I guess we can't really make it consistent anymore since
the only one so far that stands out is "type" and we've already exposed
that to userspace, so ABI...
Otherwise, this looks good, but I don't feel like I understand this good
enough to give my Reviewed-by. I'll go give this a spin on Tegra, see if
that improves my understanding.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-01-22 9:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 22:09 [PATCH 1/4] drm: Add standardized boolean props Daniel Vetter
2015-01-20 22:09 ` [PATCH 2/4] drm/atomic: Add drm_crtc_state->active Daniel Vetter
2015-01-21 21:59 ` Rob Clark
2015-01-22 7:04 ` [PATCH] " Daniel Vetter
2015-01-22 9:03 ` Thierry Reding [this message]
2015-01-20 22:09 ` [PATCH 3/4] drm/atomic-helper: add connector->dpms() implementation Daniel Vetter
2015-01-20 22:09 ` [PATCH 4/4] drm/atomic-helpers: Recover full cursor plane behaviour Daniel Vetter
2015-01-21 8:32 ` shuang.he
2015-01-21 16:59 ` Dave Gordon
2015-01-21 17:45 ` Daniel Vetter
2015-01-23 19:33 ` Dave Gordon
2015-01-22 8:44 ` Thierry Reding
2015-01-21 7:47 ` [PATCH] drm: Add standardized boolean props Daniel Vetter
2015-01-21 21:38 ` Rob Clark
2015-01-22 8:52 ` Thierry Reding
2015-01-22 17:32 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150122090307.GB30706@ulmo \
--to=thierry.reding@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox