From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/atomic: Add drm_crtc_state->active Date: Thu, 22 Jan 2015 10:03:08 +0100 Message-ID: <20150122090307.GB30706@ulmo> References: <1421791754-6244-2-git-send-email-daniel.vetter@ffwll.ch> <1421910273-26495-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1320238199==" Return-path: In-Reply-To: <1421910273-26495-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: intel-gfx@lists.freedesktop.org --===============1320238199== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pvezYHf7grwyp3Bc" Content-Disposition: inline --pvezYHf7grwyp3Bc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 22, 2015 at 08:04:33AM +0100, Daniel Vetter wrote: [...] > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c [...] > @@ -1391,6 +1395,12 @@ static int drm_mode_create_standard_properties(str= uct drm_device *dev) > return -ENOMEM; > dev->mode_config.prop_crtc_id =3D prop; > =20 > + prop =3D drm_property_create_bool(dev, DRM_MODE_PROP_ATOMIC, > + "ACTIVE"); We seem to have a weird mix of property names. Some are all caps, others all lowercase. I guess we can't really make it consistent anymore since the only one so far that stands out is "type" and we've already exposed that to userspace, so ABI... Otherwise, this looks good, but I don't feel like I understand this good enough to give my Reviewed-by. I'll go give this a spin on Tegra, see if that improves my understanding. Thierry --pvezYHf7grwyp3Bc Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUwLzLAAoJEN0jrNd/PrOhi3sP/iJIWpB9dLsYm5nmVWOQrxAY jLAKlrk/5owrQ7M6NVo1KCbIGviC9v57EpBmQSkcajuMd6w4US96F5uNVlKLDad5 9TH8HkeHu0rjmgBKVk2k0Qqy7pEqShX1GSmB1m9cJTO2rRpPpB+ZE8puVVZdrcjy 9y+qv78dbkgSGxokg/Brlplwjrk1W3+GN3vSwqXYCDtoc02F128rZSoPRIg2MakC zTCB1E1Y0eReMcg0wfqd94yIzTMJv74QAzkJmUKHbKlCO/iN0eFtwiRw5v9Gr3Uh q6++QGnVI9K2TcWWN6+ptHvxCT1RjJbSoa8d4lNYqEXhaHRs6uFuAU3V5TmkTY5h 2JbthJ8fu9+sPB6/uN8VO0i1xvo0C45qJWXz7P+xbI2Nc8R/roTf5r1hLIfmlKWD R9bo8zDcZ0K0rqVAi+Os0CcErc4LaPlZK/eOLp6G32dN/J5CmQz7c1VjZ8+ngdXW 9dKsLo4MFoCtIedlPHCuq083nHp8xEMe8WeU0G93o02FEAxRISBVVeSOh3UN6Q7t QoHKw0xRIJt8vCvL/fPcSME93rR9JOLmCWuloVJbEvyIlCabIcwHRF3KHI9DNQSs DK98WvelsQaBxU5sQv4WExvFCqLP1vDpYkpS0pZ8opX/kOkBR31pmFJ9Zt9RsmbG DGg8VIwNpEkCULMYQ/0x =FlSs -----END PGP SIGNATURE----- --pvezYHf7grwyp3Bc-- --===============1320238199== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============1320238199==--