From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2] agp/intel: Serialise after GTT updates Date: Tue, 27 Jan 2015 15:58:05 +0100 Message-ID: <20150127145805.GC4764@phenom.ffwll.local> References: <1421234459-21424-1-git-send-email-chris@chris-wilson.co.uk> <1422269230-24850-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by gabe.freedesktop.org (Postfix) with ESMTP id 637CB6E4B4 for ; Tue, 27 Jan 2015 06:56:48 -0800 (PST) Received: by mail-wi0-f174.google.com with SMTP id n3so5396718wiv.1 for ; Tue, 27 Jan 2015 06:56:47 -0800 (PST) Content-Disposition: inline In-Reply-To: <1422269230-24850-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBKYW4gMjYsIDIwMTUgYXQgMTA6NDc6MTBBTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IEFuIGludGVyZXN0aW5nIGJ1ZyBvY2N1cnMgb24gUGluZXZpZXcgdGhyb3VnaCB3aGlj aCB0aGUgcm9vdCBjYXVzZSBpcwo+IHRoYXQgdGhlIHdyaXRlcyBvZiB0aGUgUFRFIHZhbHVlcyBp bnRvIHRoZSBHVFQgaXMgbm90IHNlcmlhbGlzZWQgd2l0aAo+IHN1YnNlcXVlbnQgbWVtb3J5IGFj Y2VzcyB0aHJvdWdoIHRoZSBHVFQgKHdoZW4gdXNpbmcgV0MgdXBkYXRlcyBvZiB0aGUKPiBQVEUg dmFsdWVzKS4gVGhpcyBpcyBkZXNwaXRlIHRoZXJlIGJlaW5nIGEgcG9zdGluZyByZWFkIGFmdGVy IHRoZSBHVFQKPiB1cGRhdGUuIEhvd2V2ZXIsIGJ5IGNoYW5naW5nIHRoZSBhZGRyZXNzIG9mIHRo ZSBwb3N0aW5nIHJlYWQsIHRoZSBtZW1vcnkKPiBhY2Nlc3MgaXMgaW5kZWVkIHNlcmlhbGlzZWQg Y29ycmVjdGx5Lgo+IAo+IFdoaWxzdCB3ZSBhcmUgbWFuaXB1bGF0aW5nIHRoZSBtZW1vcnkgYmFy cmllcnMsIHdlIGNhbiByZW1vdmUgdGhlCj4gY29tcGlsZXIgOm1lbW9yeSByZXN0cmFpbnQgb24g dGhlIGludGVybWVkaWF0ZSBQVEUgd3JpdGVzIGtub3dpbmcgdGhhdAo+IHdlIGV4cGxpY2l0bHkg cGVyZm9ybSBhIHBvc3RpbmcgcmVhZCBhZnRlcndhcmRzLgo+IAo+IHYyOiBSZXBsYWNlIHBvc3Rp bmcgcmVhZHMgd2l0aCBleHBsaWNpdCB3cml0ZSBtZW1vcnkgYmFycmllcnMgLSBpbgo+IHBhcnRp Y3VsYXIgdGhpcyBpcyBhZHZhbnRhZ2VzIGluIGNhc2Ugb2Ygc2luZ2xlIHBhZ2Ugb2JqZWN0cy4g VXBkYXRlCj4gY29tbWVudHMgdG8gbWVudGlvbiB0aGlzIGlzc3VlIGlzIG9ubHkgd2l0aCBXQyB3 cml0ZXMuCj4gCj4gVGVzdGNhc2U6IGlndC9nZW1fZXhlY19iaWcgI3Budgo+IEJ1Z3ppbGxhOiBo dHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD04ODE5MQo+IFRlc3Rl ZC1ieTogaHVheC5sdUBpbnRlbC5jb20gKHYxKQo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNv biA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwu dmV0dGVyQGZmd2xsLmNoPgoKUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0 ZXJAZmZ3bGwuY2g+CgpTaG91bGRuJ3Qgd2UgQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcgdG9v PwotRGFuaWVsCgo+IC0tLQo+ICBkcml2ZXJzL2NoYXIvYWdwL2ludGVsLWd0dC5jIHwgMTQgKysr KysrKy0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlv bnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9jaGFyL2FncC9pbnRlbC1ndHQuYyBiL2Ry aXZlcnMvY2hhci9hZ3AvaW50ZWwtZ3R0LmMKPiBpbmRleCA5MmFhNDNmYThkNzAuLjBiNDE4OGI5 YWY3YyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2NoYXIvYWdwL2ludGVsLWd0dC5jCj4gKysrIGIv ZHJpdmVycy9jaGFyL2FncC9pbnRlbC1ndHQuYwo+IEBAIC0yMjUsNyArMjI1LDcgQEAgc3RhdGlj IGludCBpODEwX2luc2VydF9kY2FjaGVfZW50cmllcyhzdHJ1Y3QgYWdwX21lbW9yeSAqbWVtLCBv ZmZfdCBwZ19zdGFydCwKPiAgCQlpbnRlbF9wcml2YXRlLmRyaXZlci0+d3JpdGVfZW50cnkoYWRk ciwKPiAgCQkJCQkJICBpLCB0eXBlKTsKPiAgCX0KPiAtCXJlYWRsKGludGVsX3ByaXZhdGUuZ3R0 K2ktMSk7Cj4gKwl3bWIoKTsKPiAgCj4gIAlyZXR1cm4gMDsKPiAgfQo+IEBAIC0zMjksNyArMzI5 LDcgQEAgc3RhdGljIHZvaWQgaTgxMF93cml0ZV9lbnRyeShkbWFfYWRkcl90IGFkZHIsIHVuc2ln bmVkIGludCBlbnRyeSwKPiAgCQlicmVhazsKPiAgCX0KPiAgCj4gLQl3cml0ZWwoYWRkciB8IHB0 ZV9mbGFncywgaW50ZWxfcHJpdmF0ZS5ndHQgKyBlbnRyeSk7Cj4gKwl3cml0ZWxfcmVsYXhlZChh ZGRyIHwgcHRlX2ZsYWdzLCBpbnRlbF9wcml2YXRlLmd0dCArIGVudHJ5KTsKPiAgfQo+ICAKPiAg c3RhdGljIGNvbnN0IHN0cnVjdCBhcGVyX3NpemVfaW5mb19maXhlZCBpbnRlbF9mYWtlX2FncF9z aXplc1tdID0gewo+IEBAIC03MzUsNyArNzM1LDcgQEAgc3RhdGljIHZvaWQgaTgzMF93cml0ZV9l bnRyeShkbWFfYWRkcl90IGFkZHIsIHVuc2lnbmVkIGludCBlbnRyeSwKPiAgCWlmIChmbGFncyA9 PSAgQUdQX1VTRVJfQ0FDSEVEX01FTU9SWSkKPiAgCQlwdGVfZmxhZ3MgfD0gSTgzMF9QVEVfU1lT VEVNX0NBQ0hFRDsKPiAgCj4gLQl3cml0ZWwoYWRkciB8IHB0ZV9mbGFncywgaW50ZWxfcHJpdmF0 ZS5ndHQgKyBlbnRyeSk7Cj4gKwl3cml0ZWxfcmVsYXhlZChhZGRyIHwgcHRlX2ZsYWdzLCBpbnRl bF9wcml2YXRlLmd0dCArIGVudHJ5KTsKPiAgfQo+ICAKPiAgYm9vbCBpbnRlbF9lbmFibGVfZ3R0 KHZvaWQpCj4gQEAgLTg1OCw3ICs4NTgsNyBAQCB2b2lkIGludGVsX2d0dF9pbnNlcnRfc2dfZW50 cmllcyhzdHJ1Y3Qgc2dfdGFibGUgKnN0LAo+ICAJCQlqKys7Cj4gIAkJfQo+ICAJfQo+IC0JcmVh ZGwoaW50ZWxfcHJpdmF0ZS5ndHQrai0xKTsKPiArCXdtYigpOwo+ICB9Cj4gIEVYUE9SVF9TWU1C T0woaW50ZWxfZ3R0X2luc2VydF9zZ19lbnRyaWVzKTsKPiAgCj4gQEAgLTg3NSw3ICs4NzUsNyBA QCBzdGF0aWMgdm9pZCBpbnRlbF9ndHRfaW5zZXJ0X3BhZ2VzKHVuc2lnbmVkIGludCBmaXJzdF9l bnRyeSwKPiAgCQlpbnRlbF9wcml2YXRlLmRyaXZlci0+d3JpdGVfZW50cnkoYWRkciwKPiAgCQkJ CQkJICBqLCBmbGFncyk7Cj4gIAl9Cj4gLQlyZWFkbChpbnRlbF9wcml2YXRlLmd0dCtqLTEpOwo+ ICsJd21iKCk7Cj4gIH0KPiAgCj4gIHN0YXRpYyBpbnQgaW50ZWxfZmFrZV9hZ3BfaW5zZXJ0X2Vu dHJpZXMoc3RydWN0IGFncF9tZW1vcnkgKm1lbSwKPiBAQCAtOTM4LDcgKzkzOCw3IEBAIHZvaWQg aW50ZWxfZ3R0X2NsZWFyX3JhbmdlKHVuc2lnbmVkIGludCBmaXJzdF9lbnRyeSwgdW5zaWduZWQg aW50IG51bV9lbnRyaWVzKQo+ICAJCWludGVsX3ByaXZhdGUuZHJpdmVyLT53cml0ZV9lbnRyeShp bnRlbF9wcml2YXRlLnNjcmF0Y2hfcGFnZV9kbWEsCj4gIAkJCQkJCSAgaSwgMCk7Cj4gIAl9Cj4g LQlyZWFkbChpbnRlbF9wcml2YXRlLmd0dCtpLTEpOwo+ICsJd21iKCk7Cj4gIH0KPiAgRVhQT1JU X1NZTUJPTChpbnRlbF9ndHRfY2xlYXJfcmFuZ2UpOwo+ICAKPiBAQCAtMTEwNiw3ICsxMTA2LDcg QEAgc3RhdGljIHZvaWQgaTk2NV93cml0ZV9lbnRyeShkbWFfYWRkcl90IGFkZHIsCj4gIAo+ICAJ LyogU2hpZnQgaGlnaCBiaXRzIGRvd24gKi8KPiAgCWFkZHIgfD0gKGFkZHIgPj4gMjgpICYgMHhm MDsKPiAtCXdyaXRlbChhZGRyIHwgcHRlX2ZsYWdzLCBpbnRlbF9wcml2YXRlLmd0dCArIGVudHJ5 KTsKPiArCXdyaXRlbF9yZWxheGVkKGFkZHIgfCBwdGVfZmxhZ3MsIGludGVsX3ByaXZhdGUuZ3R0 ICsgZW50cnkpOwo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50IGk5eHhfc2V0dXAodm9pZCkKPiAtLSAK PiAyLjEuNAo+IAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENv cnBvcmF0aW9uCis0MSAoMCkgNzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK