From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Mika Kuoppala <mika.kuoppala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/4] drm/i915: Remove nested work in gpu error handling
Date: Wed, 28 Jan 2015 10:37:18 +0100 [thread overview]
Message-ID: <20150128093718.GO4764@phenom.ffwll.local> (raw)
In-Reply-To: <20150127095320.GH22081@nuc-i3427.alporthouse.com>
On Tue, Jan 27, 2015 at 09:53:20AM +0000, Chris Wilson wrote:
> On Mon, Jan 26, 2015 at 06:03:05PM +0200, Mika Kuoppala wrote:
> > Now when we declare gpu errors only through our own dedicated
> > hangcheck workqueue there is no need to have a separate workqueue
> > for handling the resetting and waking up the clients as the deadlock
> > concerns are no more.
> >
> > The only exception is i915_debugfs::i915_set_wedged, which triggers
> > error handling through process context. However as this is only used through
> > test harness it is responsibility for test harness not to introduce hangs
> > through both debug interface and through hangcheck mechanism at the same time.
> >
> > Remove gpu_error.work and let the hangcheck work do the tasks it used to.
> >
> > Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
>
> For our own sanity, we need to stick some form of that comment in
> i915_set_wedged(), so that when we do inevitably blow up, we can laugh
> at ourselves.
Yeah that has the potential for some self-inflicted pain. I've merged all
the other patches meanwhile, thanks.
-Daniel
>
> Otherwise, lgtm.
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-01-28 9:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 16:03 [PATCH 1/4] drm/i915: Convert hangcheck from a timer into a delayed work item Mika Kuoppala
2015-01-26 16:03 ` [PATCH 2/4] drm/i915: Display current hangcheck status in debugfs Mika Kuoppala
2015-01-26 16:03 ` [PATCH 3/4] drm/i915: Remove nested work in gpu error handling Mika Kuoppala
2015-01-27 9:53 ` Chris Wilson
2015-01-28 9:37 ` Daniel Vetter [this message]
2015-01-28 15:03 ` [PATCH] " Mika Kuoppala
2015-01-28 15:30 ` Chris Wilson
2015-01-29 17:03 ` Daniel Vetter
2015-02-02 9:17 ` Chris Wilson
2015-02-02 9:38 ` Daniel Vetter
2015-02-02 10:08 ` Chris Wilson
2015-02-03 14:05 ` Mika Kuoppala
2015-01-26 16:03 ` [PATCH 4/4] drm/i915: Be consistent on printing seqnos Mika Kuoppala
2015-01-27 9:52 ` Chris Wilson
2015-01-28 11:59 ` shuang.he
2015-02-03 12:23 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150128093718.GO4764@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox