From: Damien Lespiau <damien.lespiau@intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [igt PATCH] gen9: fix gem_render_copy 3d state setup
Date: Thu, 29 Jan 2015 10:51:07 +0000 [thread overview]
Message-ID: <20150129105107.GG29338@strange.ger.corp.intel.com> (raw)
In-Reply-To: <1422518599-28680-1-git-send-email-imre.deak@intel.com>
On Thu, Jan 29, 2015 at 12:03:19AM -0800, Imre Deak wrote:
> Without emitting the default 3DSTATE_WM_DEPTH_STENCIL state the test
> will fail.
>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
Question: Wasn't the golden context supposed to paper over those?
--
Damien
> ---
> lib/rendercopy_gen9.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/lib/rendercopy_gen9.c b/lib/rendercopy_gen9.c
> index e20a84f..b7b133c 100644
> --- a/lib/rendercopy_gen9.c
> +++ b/lib/rendercopy_gen9.c
> @@ -821,7 +821,13 @@ gen8_emit_ps(struct intel_batchbuffer *batch, uint32_t kernel) {
> }
>
> static void
> -gen8_emit_depth(struct intel_batchbuffer *batch) {
> +gen9_emit_depth(struct intel_batchbuffer *batch)
> +{
> + OUT_BATCH(GEN8_3DSTATE_WM_DEPTH_STENCIL | (4 - 2));
> + OUT_BATCH(0);
> + OUT_BATCH(0);
> + OUT_BATCH(0);
> +
> OUT_BATCH(GEN7_3DSTATE_DEPTH_BUFFER | (8-2));
> OUT_BATCH(0);
> OUT_BATCH(0);
> @@ -999,7 +1005,7 @@ void gen9_render_copyfunc(struct intel_batchbuffer *batch,
> OUT_BATCH(GEN6_3DSTATE_SCISSOR_STATE_POINTERS);
> OUT_BATCH(scissor_state);
>
> - gen8_emit_depth(batch);
> + gen9_emit_depth(batch);
>
> gen7_emit_clear(batch);
>
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-01-29 10:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 8:03 [igt PATCH] gen9: fix gem_render_copy 3d state setup Imre Deak
2015-01-29 10:51 ` Damien Lespiau [this message]
2015-01-29 11:01 ` Imre Deak
2015-01-29 11:12 ` Chris Wilson
2015-01-29 11:17 ` Damien Lespiau
2015-01-29 11:32 ` Chris Wilson
2015-01-29 11:37 ` Damien Lespiau
2015-01-29 14:15 ` Mika Kuoppala
2015-01-30 16:22 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150129105107.GG29338@strange.ger.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox