Re: [PATCH 1/3] drm/i915/skl: Split the SKL PCI ids by GT

Daniel Vetter
2015-01-30T16:24:11Z

On Thu, Jan 29, 2015 at 02:11:13PM -0600, Jeff McGee wrote:
> On Thu, Jan 29, 2015 at 02:13:38PM +0000, Damien Lespiau wrote:
> > We need to have a separate GT3 struct intel_device_info to declare they
> > have a second VCS. Let's start by splitting the PCI ids per-GT.
> >
> Would it be a good idea to do more programmatic population of
> these fields, rather than creating an entire new instance of the
> struct just to alter one field? This relates to our other
> conversation about the memory consumed by the 30+ device infos
> and the concern when adding new fields.

Broken record maintainer blurb:

Please provide hard data when justifying memory savings in the kmd. I see
a lot of people throwing around ideas and it seems a general concern, but
like with everything else we need to strike a cost/benefit balance and opt
for the most efficient way to save these bytes.

Which usually means shrinking down one of the runtime structs we allocate
by the thousands.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch