Re: [PATCH 1/3] drm/i915/skl: Split the SKL PCI ids by GT

Jani Nikula
2015-01-30T07:29:14Z

On Thu, 29 Jan 2015, Jeff McGee <jeff.mcgee@intel.com> wrote:
> On Thu, Jan 29, 2015 at 02:13:38PM +0000, Damien Lespiau wrote:
>> We need to have a separate GT3 struct intel_device_info to declare they
>> have a second VCS. Let's start by splitting the PCI ids per-GT.
>>
> Would it be a good idea to do more programmatic population of
> these fields, rather than creating an entire new instance of the
> struct just to alter one field? This relates to our other
> conversation about the memory consumed by the 30+ device infos
> and the concern when adding new fields.

From a debugging perspective, I do like the way it is. You can look at
or search the info structs and you know which platforms have what, no
thinking involved.

On a related note, I'm contemplating sending a patch to obliterate the
_INTEL_BDW_M and _INTEL_BDW_D macros from i915_pciids.h because it hides
the IDs from a simple grep.

See how I try to optimize space and time resources - of my brain!

BR,
Jani.

--
Jani Nikula, Intel Open Source Technology Center