Re: [PATCH 3/3] drm/i915/skl: Remove the check enforcing VCS2 to be gen8 only

Rodrigo Vivi
2015-02-04T01:55:47Z

Good catch!

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

On Thu, Jan 29, 2015 at 6:13 AM, Damien Lespiau
<damien.lespiau@intel.com> wrote:
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ringbuffer.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> index d393026..bbe439d 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> @@ -2630,19 +2630,13 @@ int intel_init_bsd_ring_buffer(struct drm_device *dev)
> }
>
> /**
> - * Initialize the second BSD ring for Broadwell GT3.
> - * It is noted that this only exists on Broadwell GT3.
> + * Initialize the second BSD ring (eg. Broadwell GT3, Skylake GT3)
> */
> int intel_init_bsd2_ring_buffer(struct drm_device *dev)
> {
> struct drm_i915_private *dev_priv = dev->dev_private;
> struct intel_engine_cs *ring = &dev_priv->ring[VCS2];
>
> - if ((INTEL_INFO(dev)->gen != 8)) {
> - DRM_ERROR("No dual-BSD ring on non-BDW machine\n");
> - return -EINVAL;
> - }
> -
> ring->name = "bsd2 ring";
> ring->id = VCS2;
>
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br