Re: [PATCH 1/3] drm/i915/skl: Split the SKL PCI ids by GT

Rodrigo Vivi
2015-02-04T01:51:29Z

On Thu, Jan 29, 2015 at 6:13 AM, Damien Lespiau
<damien.lespiau@intel.com> wrote:
> We need to have a separate GT3 struct intel_device_info to declare they
> have a second VCS. Let's start by splitting the PCI ids per-GT.
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
> include/drm/i915_pciids.h | 28 +++++++++++++++++++---------
> 1 file changed, 19 insertions(+), 9 deletions(-)
>
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index 180ad0e..38a7c80 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -259,21 +259,31 @@
> INTEL_VGA_DEVICE(0x22b2, info), \
> INTEL_VGA_DEVICE(0x22b3, info)
>
> -#define INTEL_SKL_IDS(info) \
> - INTEL_VGA_DEVICE(0x1916, info), /* ULT GT2 */ \
> +#define INTEL_SKL_GT1_IDS(info) \
> INTEL_VGA_DEVICE(0x1906, info), /* ULT GT1 */ \
> - INTEL_VGA_DEVICE(0x1926, info), /* ULT GT3 */ \
> - INTEL_VGA_DEVICE(0x1921, info), /* ULT GT2F */ \
> INTEL_VGA_DEVICE(0x190E, info), /* ULX GT1 */ \
> + INTEL_VGA_DEVICE(0x1902, info), /* DT GT1 */ \

spec shows this id as GT2 DT

> + INTEL_VGA_DEVICE(0x190B, info), /* Halo GT1 */ \
> + INTEL_VGA_DEVICE(0x190A, info) /* SRV GT1 */

couldn't find those 2 on spec

> +
> +#define INTEL_SKL_GT2_IDS(info) \
> + INTEL_VGA_DEVICE(0x1916, info), /* ULT GT2 */ \
> + INTEL_VGA_DEVICE(0x1921, info), /* ULT GT2F */ \
> INTEL_VGA_DEVICE(0x191E, info), /* ULX GT2 */ \
> INTEL_VGA_DEVICE(0x1912, info), /* DT GT2 */ \
> - INTEL_VGA_DEVICE(0x1902, info), /* DT GT1 */ \
> INTEL_VGA_DEVICE(0x191B, info), /* Halo GT2 */ \
> - INTEL_VGA_DEVICE(0x192B, info), /* Halo GT3 */ \
> - INTEL_VGA_DEVICE(0x190B, info), /* Halo GT1 */ \

> INTEL_VGA_DEVICE(0x191A, info), /* SRV GT2 */ \
couldn't find this on spec

> - INTEL_VGA_DEVICE(0x192A, info), /* SRV GT3 */ \
> - INTEL_VGA_DEVICE(0x190A, info), /* SRV GT1 */ \
> INTEL_VGA_DEVICE(0x191D, info) /* WKS GT2 */
>
> +#define INTEL_SKL_GT3_IDS(info) \
> + INTEL_VGA_DEVICE(0x1926, info), /* ULT GT3 */ \
> + INTEL_VGA_DEVICE(0x192B, info), /* Halo GT3 */ \

> + INTEL_VGA_DEVICE(0x192A, info) /* SRV GT3 */ \
couldn't find this on spec

> +
> +#define INTEL_SKL_IDS(info) \
> + INTEL_SKL_GT1_IDS(info), \
> + INTEL_SKL_GT2_IDS(info), \
> + INTEL_SKL_GT3_IDS(info)
> +
> +
> #endif /* _I915_PCIIDS_H */
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Also I've seem some ids there that aren't here...

I know this patch doesn't introduce the those IDs I couldn't fine
so with 0x1902 fixed on v2 or on follow-up or explained consider this one here:

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br