From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC 5/6] drm/i915: Allow fb modifier to set framebuffer tiling Date: Mon, 2 Feb 2015 10:54:30 +0100 Message-ID: <20150202095430.GT14009@phenom.ffwll.local> References: <1422639418-28845-1-git-send-email-tvrtko.ursulin@linux.intel.com> <1422639418-28845-6-git-send-email-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-we0-f171.google.com (mail-we0-f171.google.com [74.125.82.171]) by gabe.freedesktop.org (Postfix) with ESMTP id BD7DD89B06 for ; Mon, 2 Feb 2015 01:53:08 -0800 (PST) Received: by mail-we0-f171.google.com with SMTP id k11so35547522wes.2 for ; Mon, 02 Feb 2015 01:53:08 -0800 (PST) Content-Disposition: inline In-Reply-To: <1422639418-28845-6-git-send-email-tvrtko.ursulin@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBKYW4gMzAsIDIwMTUgYXQgMDU6MzY6NTdQTSArMDAwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gRnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4K PiAKPiBVc2UgdGhlIGZiIG1vZGlmaWVyIGlmIGl0IHdhcyBzcGVjaWZpZWQgb3ZlciBvYmplY3Qg dGlsaW5nIG1vZGUuCj4gCj4gU2lnbmVkLW9mZi1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51 cnN1bGluQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jIHwgNDAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tCj4gIDEgZmls ZSBjaGFuZ2VkLCAzMyBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCBlMjJhZmJlLi5jYTY5ZGEwIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC0xMjY3MSw2ICsxMjY3MSwyMCBA QCBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9mcmFtZWJ1ZmZlcl9mdW5jcyBpbnRlbF9mYl9mdW5j cyA9IHsKPiAgCS5jcmVhdGVfaGFuZGxlID0gaW50ZWxfdXNlcl9mcmFtZWJ1ZmZlcl9jcmVhdGVf aGFuZGxlLAo+ICB9Owo+ICAKPiArc3RhdGljIHVuc2lnbmVkIGludAo+ICtpbnRlbF9mYl9tb2Rp Zmllcl90b190aWxpbmcodTY0IG1vZGlmaWVyKQo+ICt7Cj4gKwlzd2l0Y2ggKG1vZGlmaWVyKSB7 Cj4gKwljYXNlIEk5MTVfRk9STUFUX01PRF9YX1RJTEVEOgo+ICsJCXJldHVybiBJOTE1X1RJTElO R19YOwo+ICsJZGVmYXVsdDoKPiArCWNhc2UgSTkxNV9GT1JNQVRfTU9EX05PTkU6Cj4gKwkJYnJl YWs7Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIEk5MTVfVElMSU5HX05PTkU7Cj4gK30KPiArCj4gIHN0 YXRpYyBpbnQgaW50ZWxfZnJhbWVidWZmZXJfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ ICAJCQkJICBzdHJ1Y3QgaW50ZWxfZnJhbWVidWZmZXIgKmludGVsX2ZiLAo+ICAJCQkJICBzdHJ1 Y3QgZHJtX21vZGVfZmJfY21kMiAqbW9kZV9jbWQsCj4gQEAgLTEyNjc4LDExICsxMjY5MiwyMyBA QCBzdGF0aWMgaW50IGludGVsX2ZyYW1lYnVmZmVyX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRl diwKPiAgewo+ICAJaW50IGFsaWduZWRfaGVpZ2h0Owo+ICAJaW50IHBpdGNoX2xpbWl0Owo+ICsJ dW5zaWduZWQgaW50IHRpbGluZ19tb2RlID0gb2JqLT50aWxpbmdfbW9kZTsKPiAgCWludCByZXQ7 Cj4gIAo+ICAJV0FSTl9PTighbXV0ZXhfaXNfbG9ja2VkKCZkZXYtPnN0cnVjdF9tdXRleCkpOwo+ ICAKPiAtCWlmIChvYmotPnRpbGluZ19tb2RlID09IEk5MTVfVElMSU5HX1kpIHsKPiArCWlmICht b2RlX2NtZC0+ZmxhZ3MgJiBEUk1fTU9ERV9GQl9NT0RJRklFUlMpIHsKPiArCQl0aWxpbmdfbW9k ZSA9Cj4gKwkJCWludGVsX2ZiX21vZGlmaWVyX3RvX3RpbGluZyhtb2RlX2NtZC0+bW9kaWZpZXJb MF0pOwo+ICsJCWlmICh0aWxpbmdfbW9kZSAhPSBvYmotPnRpbGluZ19tb2RlICYmCj4gKwkJCW9i ai0+dGlsaW5nX21vZGUgIT0gSTkxNV9USUxJTkdfTk9ORSkgewo+ICsJCQlEUk1fRVJST1IoIlRp bGluZyBtb2RpZmllciBtaXNtYXRjaCAldSB2cyBvYmogJXUhXG4iLAo+ICsJCQkJCXRpbGluZ19t b2RlLCBvYmotPnRpbGluZ19tb2RlKTsKPiArCQkJcmV0dXJuIC1FSU5WQUw7Cj4gKwkJfQo+ICsJ fQoKQWgsIGhlcmUgY29tZXMgdGhlIG1hZ2ljLiBJIHRoaW5rIHRoaXMgbWlnaHQgYmUgc2ltcGxl ciBpZiB3ZSBqdXN0IHVzZQotPm1vZGlmaWVyIChhbmQgZml4IGl0IHVwIGlmIEZCX01PRElGSUVS UyBpc24ndCBzZXQpLgoKQnR3IGFub3RoZXIgcmVhc29uIGZvciB0aGlzIHNwbGl0IGlzIHRoYXQg dGhpcyB3YXkgd2UgaGF2ZSBhIGNsZWFyCnNlcGFyYXRpb24gYmV0d2VlbiB0aGUgdGlsaW5nIG1v ZGVzIHN1cHBvcnRlZCBnZW5lcmFsbHkgKGFzIGZiIG1vZGlmaWVycykKYW5kIHRoZSB0aWxpbmcg bW9kZXMgc3VwcG9ydGVkIGJ5IGZlbmNlcy4gSXQgbWlnaHQgdGhlcmVmb3JlIG1ha2Ugc2Vuc2Ug dG8KcmVuYW1lIG9iai0+dGlsaW5nX21vZGUgd2l0aCBhIGNvY2NpIHBhdGNoIHRvIG9iai0+ZmVu Y2luZ19tb2RlIG9yCi0+ZmVuY2VfdGlsaW5nX21vZGUpLiBUbyBtYWtlIGl0IHJlYWxseSBjbGVh ciB0aGF0IGl0J3MganVzdCBhYm91dCB0aGUKZ2xvYmFsIGd0dCBmZW5jZXMgYW5kIG5vdGhpbmcg bW9yZS4KLURhbmllbAoKPiArCj4gKwlpZiAodGlsaW5nX21vZGUgPT0gSTkxNV9USUxJTkdfWSkg ewo+ICAJCURSTV9ERUJVRygiaGFyZHdhcmUgZG9lcyBub3Qgc3VwcG9ydCB0aWxpbmcgWVxuIik7 Cj4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gIAl9Cj4gQEAgLTEyNjk2LDEyICsxMjcyMiwxMiBAQCBz dGF0aWMgaW50IGludGVsX2ZyYW1lYnVmZmVyX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwK PiAgCWlmIChJTlRFTF9JTkZPKGRldiktPmdlbiA+PSA1ICYmICFJU19WQUxMRVlWSUVXKGRldikp IHsKPiAgCQlwaXRjaF9saW1pdCA9IDMyKjEwMjQ7Cj4gIAl9IGVsc2UgaWYgKElOVEVMX0lORk8o ZGV2KS0+Z2VuID49IDQpIHsKPiAtCQlpZiAob2JqLT50aWxpbmdfbW9kZSkKPiArCQlpZiAodGls aW5nX21vZGUpCj4gIAkJCXBpdGNoX2xpbWl0ID0gMTYqMTAyNDsKPiAgCQllbHNlCj4gIAkJCXBp dGNoX2xpbWl0ID0gMzIqMTAyNDsKPiAgCX0gZWxzZSBpZiAoSU5URUxfSU5GTyhkZXYpLT5nZW4g Pj0gMykgewo+IC0JCWlmIChvYmotPnRpbGluZ19tb2RlKQo+ICsJCWlmICh0aWxpbmdfbW9kZSkK PiAgCQkJcGl0Y2hfbGltaXQgPSA4KjEwMjQ7Cj4gIAkJZWxzZQo+ICAJCQlwaXRjaF9saW1pdCA9 IDE2KjEwMjQ7Cj4gQEAgLTEyNzExLDEyICsxMjczNywxMiBAQCBzdGF0aWMgaW50IGludGVsX2Zy YW1lYnVmZmVyX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCj4gIAlpZiAobW9kZV9j bWQtPnBpdGNoZXNbMF0gPiBwaXRjaF9saW1pdCkgewo+ICAJCURSTV9ERUJVRygiJXMgcGl0Y2gg KCVkKSBtdXN0IGJlIGF0IGxlc3MgdGhhbiAlZFxuIiwKPiAtCQkJICBvYmotPnRpbGluZ19tb2Rl ID8gInRpbGVkIiA6ICJsaW5lYXIiLAo+ICsJCQkgIHRpbGluZ19tb2RlID8gInRpbGVkIiA6ICJs aW5lYXIiLAo+ICAJCQkgIG1vZGVfY21kLT5waXRjaGVzWzBdLCBwaXRjaF9saW1pdCk7Cj4gIAkJ cmV0dXJuIC1FSU5WQUw7Cj4gIAl9Cj4gIAo+IC0JaWYgKG9iai0+dGlsaW5nX21vZGUgIT0gSTkx NV9USUxJTkdfTk9ORSAmJgo+ICsJaWYgKHRpbGluZ19tb2RlICE9IEk5MTVfVElMSU5HX05PTkUg JiYgb2JqLT5zdHJpZGUgJiYKPiAgCSAgICBtb2RlX2NtZC0+cGl0Y2hlc1swXSAhPSBvYmotPnN0 cmlkZSkgewo+ICAJCURSTV9ERUJVRygicGl0Y2ggKCVkKSBtdXN0IG1hdGNoIHRpbGluZyBzdHJp ZGUgKCVkKVxuIiwKPiAgCQkJICBtb2RlX2NtZC0+cGl0Y2hlc1swXSwgb2JqLT5zdHJpZGUpOwo+ IEBAIC0xMjc3MSw3ICsxMjc5Nyw3IEBAIHN0YXRpYyBpbnQgaW50ZWxfZnJhbWVidWZmZXJfaW5p dChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJCXJldHVybiAtRUlOVkFMOwo+ICAKPiAgCWFs aWduZWRfaGVpZ2h0ID0gaW50ZWxfZmJfYWxpZ25faGVpZ2h0KGRldiwgbW9kZV9jbWQtPmhlaWdo dCwKPiAtCQkJCQkgICAgICAgb2JqLT50aWxpbmdfbW9kZSk7Cj4gKwkJCQkJICAgICAgIHRpbGlu Z19tb2RlKTsKPiAgCS8qIEZJWE1FIGRybSBoZWxwZXIgZm9yIHNpemUgY2hlY2tzIChlc3BlY2lh bGx5IHBsYW5hciBmb3JtYXRzKT8gKi8KPiAgCWlmIChvYmotPmJhc2Uuc2l6ZSA8IGFsaWduZWRf aGVpZ2h0ICogbW9kZV9jbWQtPnBpdGNoZXNbMF0pCj4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gQEAg LTEyNzc5LDcgKzEyODA1LDcgQEAgc3RhdGljIGludCBpbnRlbF9mcmFtZWJ1ZmZlcl9pbml0KHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAlkcm1faGVscGVyX21vZGVfZmlsbF9mYl9zdHJ1Y3Qo JmludGVsX2ZiLT5iYXNlLCBtb2RlX2NtZCk7Cj4gIAlpbnRlbF9mYi0+b2JqID0gb2JqOwo+ICAJ aW50ZWxfZmItPm9iai0+ZnJhbWVidWZmZXJfcmVmZXJlbmNlcysrOwo+IC0JaW50ZWxfZmItPnRp bGluZ19tb2RlID0gb2JqLT50aWxpbmdfbW9kZTsKPiArCWludGVsX2ZiLT50aWxpbmdfbW9kZSA9 IHRpbGluZ19tb2RlOwo+ICAKPiAgCXJldCA9IGRybV9mcmFtZWJ1ZmZlcl9pbml0KGRldiwgJmlu dGVsX2ZiLT5iYXNlLCAmaW50ZWxfZmJfZnVuY3MpOwo+ICAJaWYgKHJldCkgewo+IC0tIAo+IDIu Mi4yCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K PiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y Zwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlv bgorNDEgKDApIDc5IDM2NSA1NyA0OCAtIGh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==