From: Daniel Vetter <daniel@ffwll.ch>
To: Ed Maste <emaste@freebsd.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: Multiple declarations for intel_fbc_enabled
Date: Mon, 2 Feb 2015 18:46:10 +0100 [thread overview]
Message-ID: <20150202174610.GC14009@phenom.ffwll.local> (raw)
In-Reply-To: <CAPyFy2Dr19BbeLb39DP+H0PVZTuOdmfgnhE2hQ6yhvtmgrmHTA@mail.gmail.com>
On Mon, Feb 02, 2015 at 11:40:13AM -0500, Ed Maste wrote:
> A FreeBSD developer discovered that intel_fbc_enabled has a
> declaration in two headers:
>
> sys/dev/drm2/i915/i915_drv.h:extern bool intel_fbc_enabled(struct
> drm_device *dev);
> sys/dev/drm2/i915/intel_drv.h:extern bool intel_fbc_enabled(struct
> drm_device *dev);
>
> We have a slightly older version of the i915 driver on FreeBSD, but I
> see that this is still the case in Linux (although the "extern" has
> been removed from one of them). Commit 85208be added the one in
> intel_drv.h and didn't remove the existing one.
Seems to be fixed already with
commit 7ff0ebcc1e30e3216c8c62ee71f59ac830b10364
Author: Rodrigo Vivi <rodrigo.vivi@intel.com>
Date: Mon Dec 8 14:09:10 2014 -0200
drm/i915: Move FBC stuff to intel_fbc.c
which will be in 3.20. Thanks for reporting anyway.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-02-02 17:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 16:40 Multiple declarations for intel_fbc_enabled Ed Maste
2015-02-02 17:46 ` Daniel Vetter [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-02-02 15:42 Ed Maste
2015-02-04 13:27 ` Jani Nikula
2015-02-05 2:24 ` Ed Maste
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150202174610.GC14009@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=emaste@freebsd.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox