From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Roper Subject: Re: [PATCH i-g-t] kms_cursor_crc: Kernel now checks for integer overflow Date: Tue, 3 Feb 2015 07:36:54 -0800 Message-ID: <20150203153654.GG21349@intel.com> References: <1422915648-752-1-git-send-email-matthew.d.roper@intel.com> <87wq3zxdww.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 9F1B36E09B for ; Tue, 3 Feb 2015 07:36:57 -0800 (PST) Content-Disposition: inline In-Reply-To: <87wq3zxdww.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBGZWIgMDMsIDIwMTUgYXQgMDQ6MzM6NTFQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gVHVlLCAwMyBGZWIgMjAxNSwgTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGlu dGVsLmNvbT4gd3JvdGU6Cj4gPiBBcyBvZiBrZXJuZWwgY29tbWl0Cj4gPgo+ID4gICAgIGNvbW1p dCBhNjc5MDY0YTdlOWU4Nzk5MTc3YTY0YTMxNjY4YTM0YTFiYzZhNGYxCj4gPiAgICAgQXV0aG9y OiBNYXR0IFJvcGVyIDxtYXR0aGV3LmQucm9wZXJAaW50ZWwuY29tPgo+ID4gICAgIERhdGU6ICAg RnJpIEphbiAzMCAxNjoyMjozNyAyMDE1IC0wODAwCj4gPgo+ID4gICAgICAgICBkcm0vaTkxNTog U3dpdGNoIHBsYW5lcyBmcm9tIHRyYW5zaXRpb25hbCBoZWxwZXJzIHRvIGZ1bGwgYXRvbWljIGhl bHBlcnMKPiA+Cj4gPiB0aGUga2VybmVsIG5vdyBjaGVja3MgZm9yIGN1cnNvciBjb29yZGluYXRl cyB0aGF0IHdvdWxkIHJlc3VsdCBpbgo+ID4gaW50ZWdlciBvdmVyZmxvdyBhbmQgcmV0dXJucyAt RVJBTkdFLCBzaW1pbGFyIHRvIHRoZSBjaGVja2luZyB0aGF0IHdhcwo+ID4gYWxyZWFkeSBkb25l IGZvciBvdGhlciBwbGFuZSB0eXBlcy4gIFdlIHVwZGF0ZSBrbXNfY3Vyc29yX2NyYyBoZXJlIHRv Cj4gPiByZWZsZWN0IHRoaXMgc21hbGwgYmVoYXZpb3IgY2hhbmdlOgo+ID4gICogQ2hlY2sgZm9y IHN1Y2Nlc3MgYXQgZXh0cmVtZSBib3VuZGFyeSBjb25kaXRpb25zIElOVF9NQVgte3dpZHRoLGhl aWdodH0KPiA+ICAgIHJhdGhlciB0aGFuIElOVF9NQVgKPiA+ICAqIEFkZCBuZXcgY2hlY2sgZm9y IHN1Y2Nlc3MgYXQgU0hSVF9NQVg7IGlmIHRoZSBkcml2ZXIgd2VyZSB0bwo+ID4gICAgaW50ZXJu YWxseSB1c2Ugc2hvcnQgdmFsdWVzIGFuZCBvdmVyZmxvdywgd2UgY291bGQgaGF2ZSB0aGUgY3Vy c29yCj4gPiAgICByZWFwcGVhciBvbiB0aGUgc2NyZWVuLgo+ID4gICogQWRkIGEgdGVzdCBmb3Ig ZmFpbHVyZSB3aXRoIHByb3BlciBlcnJvciBjb2RlIGF0IElOVF9NQVgte3dpZHRoLGhlaWdodH0r MQo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IE1hdHQgUm9wZXIgPG1hdHRoZXcuZC5yb3BlckBpbnRl bC5jb20+Cj4gCj4gCj4gQnVnemlsbGE6IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hv d19idWcuY2dpP2lkPTg4OTE3Cj4gCj4gPwoKWWVwLCB0aGlzIHNob3VsZCBmaXggdGhhdCBvbmUu ICBHb29kIGNhdGNoLgoKCk1hdHQKCj4gCj4gCj4gPiAtLS0KPiA+ICB0ZXN0cy9rbXNfY3Vyc29y X2NyYy5jIHwgMjkgKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KPiA+ICAxIGZpbGUgY2hh bmdlZCwgMjggaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4KPiA+IGRpZmYgLS1naXQg YS90ZXN0cy9rbXNfY3Vyc29yX2NyYy5jIGIvdGVzdHMva21zX2N1cnNvcl9jcmMuYwo+ID4gaW5k ZXggZTEzOTBhNy4uNjRmZWExMiAxMDA2NDQKPiA+IC0tLSBhL3Rlc3RzL2ttc19jdXJzb3JfY3Jj LmMKPiA+ICsrKyBiL3Rlc3RzL2ttc19jdXJzb3JfY3JjLmMKPiA+IEBAIC0xMzksNiArMTM5LDI5 IEBAIHN0YXRpYyB2b2lkIGRvX3NpbmdsZV90ZXN0KGRhdGFfdCAqZGF0YSwgaW50IHgsIGludCB5 KQo+ID4gIAlpZ3RfYXNzZXJ0KGlndF9jcmNfZXF1YWwoJmNyYywgJnJlZl9jcmMpKTsKPiA+ICB9 Cj4gPiAgCj4gPiArc3RhdGljIHZvaWQgZG9fZmFpbF90ZXN0KGRhdGFfdCAqZGF0YSwgaW50IHgs IGludCB5LCBpbnQgZXhwZWN0KQo+ID4gK3sKPiA+ICsJaWd0X2Rpc3BsYXlfdCAqZGlzcGxheSA9 ICZkYXRhLT5kaXNwbGF5Owo+ID4gKwlpZ3RfcGxhbmVfdCAqY3Vyc29yOwo+ID4gKwljYWlyb190 ICpjciA9IGlndF9nZXRfY2Fpcm9fY3R4KGRhdGEtPmRybV9mZCwgJmRhdGEtPnByaW1hcnlfZmIp Owo+ID4gKwlpbnQgcmV0Owo+ID4gKwo+ID4gKwlpZ3RfcHJpbnRfYWN0aXZpdHkoKTsKPiA+ICsK PiA+ICsJLyogSGFyZHdhcmUgdGVzdCAqLwo+ID4gKwlpZ3RfcGFpbnRfdGVzdF9wYXR0ZXJuKGNy LCBkYXRhLT5zY3JlZW53LCBkYXRhLT5zY3JlZW5oKTsKPiA+ICsJY3Vyc29yX2VuYWJsZShkYXRh KTsKPiA+ICsJY3Vyc29yID0gaWd0X291dHB1dF9nZXRfcGxhbmUoZGF0YS0+b3V0cHV0LCBJR1Rf UExBTkVfQ1VSU09SKTsKPiA+ICsJaWd0X3BsYW5lX3NldF9wb3NpdGlvbihjdXJzb3IsIHgsIHkp Owo+ID4gKwlyZXQgPSBpZ3RfZGlzcGxheV90cnlfY29tbWl0MihkaXNwbGF5LCBDT01NSVRfTEVH QUNZKTsKPiA+ICsKPiA+ICsJaWd0X3BsYW5lX3NldF9wb3NpdGlvbihjdXJzb3IsIDAsIDApOwo+ ID4gKwljdXJzb3JfZGlzYWJsZShkYXRhKTsKPiA+ICsJaWd0X2Rpc3BsYXlfY29tbWl0KGRpc3Bs YXkpOwo+ID4gKwo+ID4gKwlpZ3RfYXNzZXJ0KHJldCA9PSBleHBlY3QpOwo+ID4gK30KPiA+ICsK PiA+ICBzdGF0aWMgdm9pZCBkb190ZXN0KGRhdGFfdCAqZGF0YSwKPiA+ICAJCSAgICBpbnQgbGVm dCwgaW50IHJpZ2h0LCBpbnQgdG9wLCBpbnQgYm90dG9tKQo+ID4gIHsKPiA+IEBAIC0yMDEsNyAr MjI0LDExIEBAIHN0YXRpYyB2b2lkIHRlc3RfY3JjX29mZnNjcmVlbihkYXRhX3QgKmRhdGEpCj4g PiAgCWRvX3Rlc3QoZGF0YSwgbGVmdCAtIChjdXJzb3Jfdys1MTIpLCByaWdodCArIChjdXJzb3Jf dys1MTIpLCB0b3AgLSAoY3Vyc29yX2grNTEyKSwgYm90dG9tICsgKGN1cnNvcl9oKzUxMikpOwo+ ID4gIAo+ID4gIAkvKiBnbyBudXRzICovCj4gPiAtCWRvX3Rlc3QoZGF0YSwgSU5UX01JTiwgSU5U X01BWCwgSU5UX01JTiwgSU5UX01BWCk7Cj4gPiArCWRvX3Rlc3QoZGF0YSwgSU5UX01JTiwgSU5U X01BWCAtIGN1cnNvcl93LCBJTlRfTUlOLCBJTlRfTUFYIC0gY3Vyc29yX2gpOwo+ID4gKwlkb190 ZXN0KGRhdGEsIFNIUlRfTUlOLCBTSFJUX01BWCwgU0hSVF9NSU4sIFNIUlRfTUFYKTsKPiA+ICsK PiA+ICsJLyogTWFrZSBzdXJlIHdlIGdldCAtRVJBTkdFIG9uIGludGVnZXIgb3ZlcmZsb3cgKi8K PiA+ICsJZG9fZmFpbF90ZXN0KGRhdGEsIElOVF9NQVggLSBjdXJzb3JfdyArIDEsIElOVF9NQVgg LSBjdXJzb3JfaCArIDEsIC1FUkFOR0UpOwo+ID4gIH0KPiA+ICAKPiA+ICBzdGF0aWMgdm9pZCB0 ZXN0X2NyY19zbGlkaW5nKGRhdGFfdCAqZGF0YSkKPiA+IC0tIAo+ID4gMS44LjUuMQo+ID4KPiA+ IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiBJbnRl bC1nZnggbWFpbGluZyBsaXN0Cj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4g PiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cj4gCj4gLS0gCj4gSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2Vu dGVyCgotLSAKTWF0dCBSb3BlcgpHcmFwaGljcyBTb2Z0d2FyZSBFbmdpbmVlcgpJb1RHIFBsYXRm b3JtIEVuYWJsaW5nICYgRGV2ZWxvcG1lbnQKSW50ZWwgQ29ycG9yYXRpb24KKDkxNikgMzU2LTI3 OTUKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK