From: Daniel Vetter <daniel@ffwll.ch>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
Shobhit Kumar <shobhit.kumar@intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [Intel-gfx] [RFC v3 3/4] drm/i915: Add new panel driver based on crystal cove pmic
Date: Thu, 5 Feb 2015 10:46:50 +0100 [thread overview]
Message-ID: <20150205094650.GS14009@phenom.ffwll.local> (raw)
In-Reply-To: <20150203131651.GG15068@ulmo.nvidia.com>
On Tue, Feb 03, 2015 at 02:16:53PM +0100, Thierry Reding wrote:
> On Wed, Jan 21, 2015 at 04:48:12PM +0530, Shobhit Kumar wrote:
> > diff --git a/drivers/gpu/drm/i915/intel-panel-crystalcove.c b/drivers/gpu/drm/i915/intel-panel-crystalcove.c
> [...]
> > +#define PMIC_PANEL_EN 0x52
> > +#define PMIC_PWM_EN 0x51
> > +#define PMIC_BKL_EN 0x4B
> > +#define PMIC_PWM_LEVEL 0x4E
>
> These look like they should be GPIOs/regulators and a PWM instead. So I
> think you'd need to further split up the MFD device to accomodate for
> this.
I've had some extension discussion with Thierry on irc and I agree that
using gpio/pwm interfaces will suit better. In addition both gpio and pwm
subsystem already have magic register/lookup support (which works outside
of devicetree or the new acpi tables, which I didn't know). So we'll avoid
writing our own inter-module boilerplate.
Shobhit, Jani&I also chatted about this topic on irc and I think the rough
direction is hopefully clear now.
Just a quick mail here for the record so that the irc discussion won't get
lost.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-02-05 9:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 11:18 [RFC v3 0/4] Crystal Cove PMIC based Panel and Backlight Control Shobhit Kumar
2015-01-21 11:18 ` [RFC v3 1/4] drm: Add support to find drm_panel by name Shobhit Kumar
2015-02-03 13:00 ` Thierry Reding
2015-02-04 11:14 ` [PATCH] " Shobhit Kumar
2015-02-04 14:01 ` shuang.he
2015-01-21 11:18 ` [RFC v3 2/4] mfd: Add a new cell device for panel controlled by crystal cove pmic Shobhit Kumar
2015-02-03 13:05 ` Thierry Reding
2015-02-04 5:59 ` Shobhit Kumar
2015-01-21 11:18 ` [RFC v3 3/4] drm/i915: Add new panel driver based on " Shobhit Kumar
2015-02-03 13:16 ` Thierry Reding
2015-02-04 6:55 ` Shobhit Kumar
2015-02-05 9:46 ` Daniel Vetter [this message]
2015-01-21 11:18 ` [RFC v3 4/4] drm/i915: Enable DSI panel enable/disable based on PMIC Shobhit Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150205094650.GS14009@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=shobhit.kumar@intel.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox