From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Jani Nikula <jani.nikula@intel.com>,
intel-gfx@lists.freedesktop.org,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [PATCH] drm/i915/fbc: fix the check for already reserved fbc size
Date: Thu, 5 Feb 2015 15:27:21 +0100 [thread overview]
Message-ID: <20150205142721.GY14009@phenom.ffwll.local> (raw)
In-Reply-To: <20150205100605.GH10991@nuc-i3427.alporthouse.com>
On Thu, Feb 05, 2015 at 10:06:05AM +0000, Chris Wilson wrote:
> On Thu, Feb 05, 2015 at 12:04:27PM +0200, Jani Nikula wrote:
> > The check for previously reserved stolen space size for FBC in
> > i915_gem_stolen_setup_compression() did not take the compression
> > threshold into account. Fix this by storing and comparing to
> > uncompressed size instead.
> >
> > The bug has been introduced in
> >
> > commit 5e59f7175f96550ede91f58d267d2b551cb6fbba
> > Author: Ben Widawsky <benjamin.widawsky@intel.com>
> > Date: Mon Jun 30 10:41:24 2014 -0700
> >
> > drm/i915: Try harder to get FBC
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88975
> > Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Ben Widawsky <benjamin.widawsky@intel.com>
> > Cc: stable@vger.kernel.org # 3.17+
Dropped since fbc isn't enabled by default.
> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Thanks, I think uncompressed_size clarifies exactly what we want to
> compare against (is this allocation request any bigger or smaller than
> the last request). Then if we need the final size for anything we can
> add it without further confusion.
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-02-05 14:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 10:04 [PATCH] drm/i915/fbc: fix the check for already reserved fbc size Jani Nikula
2015-02-05 10:06 ` Chris Wilson
2015-02-05 14:27 ` Daniel Vetter [this message]
2015-02-05 13:27 ` shuang.he
2015-02-05 17:08 ` Ben Widawsky
2015-02-06 8:09 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150205142721.GY14009@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=benjamin.widawsky@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox