Re: [PATCH 03/10] drm/i915: gen 9 h/w w/a (WaDisablePartialInstShootdown)

[Damien Lespiau <damien.lespiau@intel.com>]

On Thu, Feb 05, 2015 at 10:47:18AM +0000, Nick Hoath wrote:
> From: "Hoath, Nicholas" <nicholas.hoath@intel.com>
> 
> Add:
> WaDisablePartialInstShootdown

Just an editor note: that's not really additional information compared
to the subject of the patch. Also subject message could be a bit more
direct and mention SKL:

  drm/i915/skl: Implement WaDisablePartialInstShootdown

> v1: Dont add WaDisableThreadStallDopClockGating as not SKL WA. (Found by Damien Lespiau)

v2, v1 was the original patch. Commit messages should also be wrapped
like emails, so 90 chars is too long.

Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

> Signed-off-by: Nick Hoath <nicholas.hoath@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_ringbuffer.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> index fbfe65a..b869f1c 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> @@ -875,6 +875,13 @@ static int chv_init_workarounds(struct intel_engine_cs *ring)
>  
>  static int gen9_init_workarounds(struct intel_engine_cs *ring)
>  {
> +	struct drm_device *dev = ring->dev;
> +	struct drm_i915_private *dev_priv = dev->dev_private;
> +
> +	/* WaDisablePartialInstShootdown:skl */
> +	WA_SET_BIT_MASKED(GEN8_ROW_CHICKEN,
> +			  PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE);
> +
>  	return 0;
>  }
>  
> -- 
> 2.1.1
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx