From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Roper Subject: Re: [PATCH 5/5] drm/i915: Fix atomic state when reusing the firmware fb Date: Thu, 5 Feb 2015 11:12:20 -0800 Message-ID: <20150205191220.GA9625@intel.com> References: <1423156939-15705-1-git-send-email-damien.lespiau@intel.com> <1423156939-15705-6-git-send-email-damien.lespiau@intel.com> <20150205181026.GB25532@intel.com> <20150205185806.GK16525@strange.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id B9A506E268 for ; Thu, 5 Feb 2015 11:12:22 -0800 (PST) Content-Disposition: inline In-Reply-To: <20150205185806.GK16525@strange.ger.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBGZWIgMDUsIDIwMTUgYXQgMDY6NTg6MDZQTSArMDAwMCwgRGFtaWVuIExlc3BpYXUg d3JvdGU6Cj4gT24gVGh1LCBGZWIgMDUsIDIwMTUgYXQgMTA6MTA6MjZBTSAtMDgwMCwgTWF0dCBS b3BlciB3cm90ZToKPiA+IE9uIFRodSwgRmViIDA1LCAyMDE1IGF0IDA1OjIyOjE5UE0gKzAwMDAs IERhbWllbiBMZXNwaWF1IHdyb3RlOgo+ID4gPiBSaWdodCBub3csIHdlIGdldCBhIHdhcm5pbmcg d2hlbiB0YWtpbmcgb3ZlciB0aGUgZmlybXdhcmUgZmI6Cj4gPiA+IAo+ID4gPiAgIFtkcm06ZHJt X2F0b21pY19wbGFuZV9jaGVja10gRkIgc2V0IGJ1dCBubyBDUlRDCj4gPiA+IAo+ID4gPiB3aXRo IHRoZSBmb2xsb3dpbmcgYmFja3RyYWNlOgo+ID4gPiAKPiA+ID4gICBbPGZmZmZmZmZmYTAxMDMz OWQ+XSBkcm1fYXRvbWljX2NoZWNrX29ubHkrMHgzNWQvMHg1MTAgW2RybV0KPiA+ID4gICBbPGZm ZmZmZmZmYTAxMDM1Njc+XSBkcm1fYXRvbWljX2NvbW1pdCsweDE3LzB4NjAgW2RybV0KPiA+ID4g ICBbPGZmZmZmZmZmYTAwYTZjY2Q+XSBkcm1fYXRvbWljX2hlbHBlcl9wbGFuZV9zZXRfcHJvcGVy dHkrMHg4ZC8weGQwIFtkcm1fa21zX2hlbHBlcl0KPiA+ID4gICBbPGZmZmZmZmZmYTAwZjFmZWQ+ XSBkcm1fbW9kZV9wbGFuZV9zZXRfb2JqX3Byb3ArMHgyZC8weDkwIFtkcm1dCj4gPiA+ICAgWzxm ZmZmZmZmZmEwMGE4YTFiPl0gcmVzdG9yZV9mYmRldl9tb2RlKzB4NmIvMHhmMCBbZHJtX2ttc19o ZWxwZXJdCj4gPiA+ICAgWzxmZmZmZmZmZmEwMGFhOTY5Pl0gZHJtX2ZiX2hlbHBlcl9yZXN0b3Jl X2ZiZGV2X21vZGVfdW5sb2NrZWQrMHgyOS8weDgwIFtkcm1fa21zX2hlbHBlcl0KPiA+ID4gICBb PGZmZmZmZmZmYTAwYWE5ZTI+XSBkcm1fZmJfaGVscGVyX3NldF9wYXIrMHgyMi8weDUwIFtkcm1f a21zX2hlbHBlcl0KPiA+ID4gICBbPGZmZmZmZmZmYTA1MGE3MWE+XSBpbnRlbF9mYmRldl9zZXRf cGFyKzB4MWEvMHg2MCBbaTkxNV0KPiA+ID4gICBbPGZmZmZmZmZmODEzYWQ0NDQ+XSBmYmNvbl9p bml0KzB4NGY0LzB4NTgwCj4gPiA+IAo+ID4gPiBUaGF0J3MgYmVjYXVzZSB3ZSB1cGRhdGUgdGhl IHBsYW5lIHN0YXRlIHdpdGggdGhlIGZiIGZyb20gdGhlIGZpcm13YXJlLCBidXQgd2UKPiA+ID4g bmV2ZXIgYXNzb2NpYXRlIHRoZSBwbGFuZSB0byB0aGF0IENSVEMuCj4gPiA+IAo+ID4gPiBXZSBk b24ndCBxdWl0ZSBoYXZlIHRoZSBmdWxsIERSTSB0YWtlIG92ZXIgZnJvbSBIVyBzdGF0ZSBqdXN0 IHlldCwgc28KPiA+ID4gZmFrZSBlbm91Z2ggb2YgdGhlIHBsYW5lIGF0b21pYyBzdGF0ZSB0byBw YXNzIHRoZSBjaGVja3MuCj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBEYW1pZW4gTGVzcGlh dSA8ZGFtaWVuLmxlc3BpYXVAaW50ZWwuY29tPgo+ID4gPiAtLS0KPiA+ID4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDkgKysrKysrKy0tCj4gPiA+ICAxIGZpbGUgY2hh bmdlZCwgNyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+ID4gPiAKPiA+ID4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gPiBpbmRleCAwZDA3NTM1Li5lZWQxYzBjIDEw MDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+ ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiA+IEBAIC0y NDM5LDggKzI0MzksMTIgQEAgaW50ZWxfZmluZF9wbGFuZV9vYmooc3RydWN0IGludGVsX2NydGMg KmludGVsX2NydGMsCj4gPiA+ICAJCXJldHVybjsKPiA+ID4gIAo+ID4gPiAgCWlmIChpbnRlbF9h bGxvY19wbGFuZV9vYmooaW50ZWxfY3J0YywgcGxhbmVfY29uZmlnKSkgewo+ID4gPiAtCQlpbnRl bF9jcnRjLT5iYXNlLnByaW1hcnktPmZiID0gJnBsYW5lX2NvbmZpZy0+ZmItPmJhc2U7Cj4gPiA+ IC0JCXVwZGF0ZV9zdGF0ZV9mYihpbnRlbF9jcnRjLT5iYXNlLnByaW1hcnkpOwo+ID4gPiArCQlz dHJ1Y3QgZHJtX3BsYW5lICpwcmltYXJ5ID0gaW50ZWxfY3J0Yy0+YmFzZS5wcmltYXJ5Owo+ID4g PiArCj4gPiA+ICsJCXByaW1hcnktPmZiID0gJnBsYW5lX2NvbmZpZy0+ZmItPmJhc2U7Cj4gPiA+ ICsJCXByaW1hcnktPnN0YXRlLT5jcnRjID0gJmludGVsX2NydGMtPmJhc2U7Cj4gPiAKPiA+IFdv dWxkCj4gPiAKPiA+ICAgICAgICAgZHJtX2F0b21pY19zZXRfY3J0Y19mb3JfcGxhbmUocHJpbWFy eS0+c3RhdGUsICZpbnRlbF9jcnRjLT5iYXNlKQo+ID4gCj4gPiBiZSBiZXR0ZXIgaGVyZSBzbyB0 aGF0IHRoZSB2YXJpb3VzIGJpdG1hc2tzIGdldCB1cGRhdGVkPwo+IAo+IFNvLCB0aGlzIGlzIHdo YXQgSSB0cmllZCBmaXJzdCwgYnV0IGl0IHdhcyBvb3BzaW5nIGluOgo+IAo+IDB4MWZkMzEgaXMg aW4gZHJtX2F0b21pY19nZXRfY3J0Y19zdGF0ZSAoZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMu YzoyMDUpLgo+IDIwMAkJaW50IHJldCwgaW5kZXg7Cj4gMjAxCQlzdHJ1Y3QgZHJtX2NydGNfc3Rh dGUgKmNydGNfc3RhdGU7Cj4gMjAyCQo+IDIwMwkJaW5kZXggPSBkcm1fY3J0Y19pbmRleChjcnRj KTsKPiAyMDQJCj4gMjA1CQlpZiAoc3RhdGUtPmNydGNfc3RhdGVzW2luZGV4XSkKPiAyMDYJCQly ZXR1cm4gc3RhdGUtPmNydGNfc3RhdGVzW2luZGV4XTsKPiAyMDcJCj4gMjA4CQlyZXQgPSBkcm1f bW9kZXNldF9sb2NrKCZjcnRjLT5tdXRleCwgc3RhdGUtPmFjcXVpcmVfY3R4KTsKPiAyMDkJCWlm IChyZXQpCj4gCj4gUHJlc3VtYWJseSBiZWNhdXNlIHdlIGRvbid0IGhhdmUgYSBhdG9taWMgbW9k ZXNldCBjb250ZXh0IHNldHVwIGluCj4gLT5zdGF0ZSB3aGVuIGluaXRpYWxseSByZWFkaW5nIG91 dCB0aGUgaHcgc3RhdGUuCj4gCj4gSSB3ZW50IGZvciB0aGUgc2hvcnRlc3Qgd2F5IHRvIG1ha2Ug dGhlIHdhcm5pbmdzIHN0b3AuCgpBaCwgeW91J3JlIHJpZ2h0LiAgV2UncmUgbm90IGluIHRoZSBt aWRkbGUgb2YgYW4gYXRvbWljIG9wZXJhdGlvbiwgc28gd2UKb25seSBoYXZlIGEgcGxhbmVfc3Rh dGUgYW5kIG5vdCBhIHRvcC1sZXZlbCBkcm1fYXRvbWljX3N0YXRlIHRvIHdvcmsKd2l0aC4KCkkg dGhpbmsgd2hhdCB5b3UgaGF2ZSBoZXJlIHNob3VsZCBiZSBmaW5lLgoKCj4gPiAKPiA+ID4gKwkJ dXBkYXRlX3N0YXRlX2ZiKHByaW1hcnkpOwo+ID4gPiArCj4gPiA+ICAJCXJldHVybjsKPiA+ID4g IAl9Cj4gPiA+ICAKPiA+ID4gQEAgLTI0NjksNiArMjQ3Myw3IEBAIGludGVsX2ZpbmRfcGxhbmVf b2JqKHN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjLAo+ID4gPiAgCj4gPiA+ICAJCQlkcm1f ZnJhbWVidWZmZXJfcmVmZXJlbmNlKGMtPnByaW1hcnktPmZiKTsKPiA+ID4gIAkJCWludGVsX2Ny dGMtPmJhc2UucHJpbWFyeS0+ZmIgPSBjLT5wcmltYXJ5LT5mYjsKPiA+ID4gKwkJCWMtPnN0YXRl LT5jcnRjID0gJmludGVsX2NydGMtPmJhc2U7Cj4gPiAKPiA+IEknbSBub3Qgc3VyZSBJIHVuZGVy c3RhbmQgdGhpcyBsaW5lLiAgYy0+c3RhdGUgaXMgdGhlIGNydGMgc3RhdGUgZm9yIHRoZQo+ID4g b3RoZXIgQ1JUQyB3ZSdyZSBnb2luZyB0byBzaGFyZSB3aXRoIHdpdGggKGFuZCBoYXMgYSBiYWNr cG9pbnRlciBvZgo+ID4gYy0+c3RhdGUtPmNydGMgPSBjKS4gIFdhcyB0aGlzIHN1cHBvc2VkIHRv IGJlIHNvbWV0aGluZyBsaWtlCj4gPiAKPiA+ICAgICAgICAgZHJtX2F0b21pY19zZXRfY3J0Y19m b3JfcGxhbmUoaW50ZWxfY3J0Yy0+YmFzZS5wcmltYXJ5LT5zdGF0ZSwKPiA+ICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgJmludGVsX2NydGMtPmJhc2UpCj4gPiAKPiA+IGlu c3RlYWQ/ICBJJ20gbm90IHN1cmUgaWYgdXBkYXRpbmcgdGhlIG90aGVyIGNydGMgKHRoYXQgd2Un cmUgc2hhcmluZwo+ID4gd2l0aCkgd2FzIGEgbWlzdGFrZSBoZXJlLgo+IAo+IEkgZGlkIG1lYW4g dG8gd3JpdGU6Cj4gCWludGVsX2NydGMtPmJhc2UucHJpbWFyeS0+c3RhdGUtPmNydGMgPSAmaW50 ZWxfY3J0Yy0+YmFzZTsKCk9rYXksIHRoYXQgbG9va3MgZ29vZCB0byBtZS4KCkkgdGhpbmsgdGhl IG9ubHkgdGhpbmcgd2UgbmVlZCB0byBjbG9zZSBvbiBpcyBWaWxsZSdzIGNvbmNlcm4gYWJvdXQg dGhlCnBsYW5lIHdpbmRpbmcgdXAgd2l0aCBub24tTlVMTCBmYiBhbmQgY3J0YyBwb2ludGVycyBl dmVuIHRob3VnaCBhIGNyYXp5CmZpcm13YXJlIG9yIGJvb3Rsb2FkZXIgc29tZWhvdyBsZWZ0IHRo ZSBwbGFuZSB0dXJuZWQgb2ZmLiAgSSdtIG5vdCBzdXBlcgpmYW1pbGlhciB3aXRoIHRoZSBmYXN0 Ym9vdCBzdHVmZiwgYnV0IG1heWJlIG91cgpnZXRfaW5pdGlhbF9wbGFuZV9jb25maWcoKSBjYWxs cyBuZWVkIGEgdGVzdCB0byBlbnN1cmUgdGhlIHBsYW5lIGlzCmFjdHVhbGx5IHR1cm5lZCBvbiBi ZWZvcmUgdGhleSBzdGFydCB0cnlpbmcgdG8gcmVhZCBvdXQgdGhlIEZCIGJhc2UgYW5kCnN1Y2g/ CgoKTWF0dAoKPiAKPiAtLSAKPiBEYW1pZW4KCi0tIApNYXR0IFJvcGVyCkdyYXBoaWNzIFNvZnR3 YXJlIEVuZ2luZWVyCklvVEcgUGxhdGZvcm0gRW5hYmxpbmcgJiBEZXZlbG9wbWVudApJbnRlbCBD b3Jwb3JhdGlvbgooOTE2KSAzNTYtMjc5NQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAo=