From: Damien Lespiau <damien.lespiau@intel.com>
To: Nick Hoath <nicholas.hoath@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: gen 9 h/w w/a Fix stepping check
Date: Fri, 6 Feb 2015 11:52:42 +0000 [thread overview]
Message-ID: <20150206115242.GB27140@strange.ger.corp.intel.com> (raw)
In-Reply-To: <1423222204-4238-2-git-send-email-nicholas.hoath@intel.com>
On Fri, Feb 06, 2015 at 11:30:03AM +0000, Nick Hoath wrote:
> Fixed the stepping check on WaDisableDgMirrorFixInHalfSliceChicken5
> to be for the correct SOC (Skylake)
>
> Signed-off-by: Nick Hoath <nicholas.hoath@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ringbuffer.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> index 573b80f..fb71e33 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> @@ -886,7 +886,8 @@ static int gen9_init_workarounds(struct intel_engine_cs *ring)
> WA_SET_BIT_MASKED(HALF_SLICE_CHICKEN3,
> GEN9_DISABLE_OCL_OOB_SUPPRESS_LOGIC);
>
> - if (INTEL_REVID(dev) == SKL_REVID_A0) {
> + if (INTEL_REVID(dev) >= SKL_REVID_A0 &&
> + INTEL_REVID(dev) <= SKL_REVID_B0) {
x >= 0 && x <= 1 looks really better as x == 0 || x == 1
Otherwise:
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
> /*
> * WaDisableDgMirrorFixInHalfSliceChicken5:skl
> * This is a pre-production w/a.
> --
> 2.1.1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-02-06 11:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 11:30 [PATCH 0/2] gen 9 h/w w/a cleanup Nick Hoath
2015-02-06 11:30 ` [PATCH 1/2] drm/i915: gen 9 h/w w/a Fix stepping check Nick Hoath
2015-02-06 11:52 ` Damien Lespiau [this message]
2015-02-09 18:16 ` Daniel Vetter
2015-02-06 11:30 ` [PATCH 2/2] drm/i915: gen 9 h/w w/a (WaEnableForceRestoreInCtxtDescForVCS) Nick Hoath
2015-02-06 11:58 ` Damien Lespiau
2015-02-07 13:35 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150206115242.GB27140@strange.ger.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nicholas.hoath@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox