From: Damien Lespiau <damien.lespiau@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915/bdw: Implement WaForceContextSaveRestoreNonCoherent
Date: Tue, 10 Feb 2015 10:31:10 +0000 [thread overview]
Message-ID: <20150210103110.GA3517@strange.ger.corp.intel.com> (raw)
In-Reply-To: <20150209211426.GE9837@nuc-i3427.alporthouse.com>
On Mon, Feb 09, 2015 at 09:14:26PM +0000, Chris Wilson wrote:
> On Mon, Feb 09, 2015 at 07:25:56PM +0000, Damien Lespiau wrote:
> > v2: Reorder defines (Ben)
>
> Bikeshed time?
Oh no, why did I give in the first time? now I'm being bullied!
> > /* WaCatErrorRejectionIssue */
> > #define GEN7_SQ_CHICKEN_MBCUNIT_CONFIG 0x9030
> > diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> > index 46486a5..a9cde64 100644
> > --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> > +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> > @@ -790,9 +790,11 @@ static int bdw_init_workarounds(struct intel_engine_cs *ring)
> > */
> > /* WaForceEnableNonCoherent:bdw */
> > /* WaHdcDisableFetchWhenMasked:bdw */
> > + /* WaForceContextSaveRestoreNonCoherent:bdw */
> > /* WaDisableFenceDestinationToSLM:bdw (GT3 pre-production) */
> > WA_SET_BIT_MASKED(HDC_CHICKEN0,
> > HDC_FORCE_NON_COHERENT |
> > + HDC_FORCE_CONTEXT_SAVE_RESTORE_NON_COHERENT |
> > HDC_DONOT_FETCH_MEM_WHEN_MASKED |
> > (IS_BDW_GT3(dev) ? HDC_FENCE_DEST_SLM_DISABLE : 0));
>
> This is nicer as:
> WA_SET_BIT_MASKED(HDC_CHICKEN0,
> /* WaForceEnableNonCoherent:bdw */
> HDC_FORCE_NON_COHERENT |
> + /* WaForceContextSaveRestoreNonCoherent:bdw */
> + HDC_FORCE_CONTEXT_SAVE_RESTORE_NON_COHERENT |
> /* WaHdcDisableFetchWhenMasked:bdw */
> HDC_DONOT_FETCH_MEM_WHEN_MASKED |
> /* WaDisableFenceDestinationToSLM:bdw (GT3 pre-production) */
> (IS_BDW_GT3(dev) ? HDC_FENCE_DEST_SLM_DISABLE : 0));
>
> Indeed, that shows that you misorded your comment! ;-)
Ah, but there is a line over 80 characters there! not acceptable!
--
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-02-10 10:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 19:25 [PATCH v2] drm/i915/bdw: Implement WaForceContextSaveRestoreNonCoherent Damien Lespiau
2015-02-09 21:14 ` Chris Wilson
2015-02-10 10:31 ` [PATCH v3] " Damien Lespiau
2015-02-10 11:57 ` Daniel Vetter
2015-02-10 10:31 ` Damien Lespiau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150210103110.GA3517@strange.ger.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox