From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3] drm/i915/bdw: Implement WaForceContextSaveRestoreNonCoherent
Date: Tue, 10 Feb 2015 12:57:37 +0100 [thread overview]
Message-ID: <20150210115737.GL24485@phenom.ffwll.local> (raw)
In-Reply-To: <1423564260-6231-1-git-send-email-damien.lespiau@intel.com>
On Tue, Feb 10, 2015 at 10:31:00AM +0000, Damien Lespiau wrote:
> v2: Reorder defines (Ben)
> v3: More bikesheds, this time re-ordering comments! (Chris)
>
> Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Queued for -next, thanks for the patch.
-Daniel
> ---
> drivers/gpu/drm/i915/i915_reg.h | 5 +++--
> drivers/gpu/drm/i915/intel_ringbuffer.c | 8 +++++---
> 2 files changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index b4abd50..4b8450d 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -5273,10 +5273,11 @@ enum skl_disp_power_wells {
>
> /* GEN8 chicken */
> #define HDC_CHICKEN0 0x7300
> -#define HDC_FORCE_NON_COHERENT (1<<4)
> -#define HDC_DONOT_FETCH_MEM_WHEN_MASKED (1<<11)
> #define HDC_FENCE_DEST_SLM_DISABLE (1<<14)
> +#define HDC_DONOT_FETCH_MEM_WHEN_MASKED (1<<11)
> #define HDC_BARRIER_PERFORMANCE_DISABLE (1<<10)
> +#define HDC_FORCE_CONTEXT_SAVE_RESTORE_NON_COHERENT (1<<5)
> +#define HDC_FORCE_NON_COHERENT (1<<4)
>
> /* WaCatErrorRejectionIssue */
> #define GEN7_SQ_CHICKEN_MBCUNIT_CONFIG 0x9030
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> index 93365fe..443e19c 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> @@ -788,12 +788,14 @@ static int bdw_init_workarounds(struct intel_engine_cs *ring)
> * workaround for for a possible hang in the unlikely event a TLB
> * invalidation occurs during a PSD flush.
> */
> - /* WaForceEnableNonCoherent:bdw */
> - /* WaHdcDisableFetchWhenMasked:bdw */
> - /* WaDisableFenceDestinationToSLM:bdw (GT3 pre-production) */
> WA_SET_BIT_MASKED(HDC_CHICKEN0,
> + /* WaForceEnableNonCoherent:bdw */
> HDC_FORCE_NON_COHERENT |
> + /* WaForceContextSaveRestoreNonCoherent:bdw */
> + HDC_FORCE_CONTEXT_SAVE_RESTORE_NON_COHERENT |
> + /* WaHdcDisableFetchWhenMasked:bdw */
> HDC_DONOT_FETCH_MEM_WHEN_MASKED |
> + /* WaDisableFenceDestinationToSLM:bdw (pre-prod) */
> (IS_BDW_GT3(dev) ? HDC_FENCE_DEST_SLM_DISABLE : 0));
>
> /* From the Haswell PRM, Command Reference: Registers, CACHE_MODE_0:
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-02-10 11:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 19:25 [PATCH v2] drm/i915/bdw: Implement WaForceContextSaveRestoreNonCoherent Damien Lespiau
2015-02-09 21:14 ` Chris Wilson
2015-02-10 10:31 ` [PATCH v3] " Damien Lespiau
2015-02-10 11:57 ` Daniel Vetter [this message]
2015-02-10 10:31 ` [PATCH v2] " Damien Lespiau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150210115737.GL24485@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox