From: Damien Lespiau <damien.lespiau@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 04/15] drm/i915: Parse VBT PSR block.
Date: Tue, 10 Feb 2015 19:26:06 +0000 [thread overview]
Message-ID: <20150210192606.GD8920@strange.ger.corp.intel.com> (raw)
In-Reply-To: <1415983961-4485-4-git-send-email-rodrigo.vivi@intel.com>
On Fri, Nov 14, 2014 at 08:52:30AM -0800, Rodrigo Vivi wrote:
> +struct psr_table {
> + /* Feature bits */
> + u8 full_link:1;
> + u8 require_aux_to_wakeup:1;
> + u8 feature_bits_rsvd:6;
> +
> + /* Wait times */
> + u8 idle_frames:4;
> + u8 lines_to_wait:3;
> + u8 wait_times_rsvd:1;
> +
> + /* TP wake up time in multiple of 100 */
> + u16 tp1_wakeup_time;
> + u16 tp2_tp3_wakeup_time;
> +} __packed;
...
> + /* Allowed VBT values goes from 0 to 15 */
> + dev_priv->vbt.psr.idle_frames = psr_table->idle_frames < 0 ? 0 :
> + psr_table->idle_frames > 15 ? 15 : psr_table->idle_frames;
smatch gives a warning here saying those conditions are always true.
psr_table->idle_frames being 4 bits in a bitfield, we can see that
smatch may well be right.
--
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-02-10 19:26 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 16:52 [PATCH 01/15] drm/i915: Make dp aux pack/unpack public outside intel_dp.c Rodrigo Vivi
2014-11-14 16:52 ` [PATCH 02/15] drm/i915: Introduce intel_psr.c Rodrigo Vivi
2014-11-18 18:16 ` R, Durgadoss
2014-11-14 16:52 ` [PATCH 03/15] drm/i915: Add PSR docbook Rodrigo Vivi
2014-11-18 18:18 ` R, Durgadoss
2014-11-14 16:52 ` [PATCH 04/15] drm/i915: Parse VBT PSR block Rodrigo Vivi
2015-02-10 19:26 ` Damien Lespiau [this message]
2014-11-14 16:52 ` [PATCH 05/15] drm/i915: HSW/BDW PSR Set idle_frames = VBT + 1 Rodrigo Vivi
2014-11-14 16:52 ` [PATCH 06/15] drm/i915: PSR get full link off x standby from VBT Rodrigo Vivi
2014-11-18 18:21 ` R, Durgadoss
2014-11-21 18:46 ` Daniel Vetter
2014-11-14 16:52 ` [PATCH 07/15] drm/i915: PSR skip aux on wake up as defined by VBT Rodrigo Vivi
2014-11-17 18:48 ` Rodrigo Vivi
2014-11-14 16:52 ` [PATCH 08/15] drm/i915: remove PSR BDW single frame update Rodrigo Vivi
2014-11-18 18:23 ` R, Durgadoss
2014-11-19 15:34 ` [PATCH] " Rodrigo Vivi
2014-11-21 14:55 ` shuang.he
2014-11-14 16:52 ` [PATCH 09/15] drm/i915: Fix intel_psr_is_enabled function and document it Rodrigo Vivi
2014-11-18 18:24 ` R, Durgadoss
2014-11-19 13:51 ` Daniel Vetter
2014-11-19 15:34 ` [PATCH] drm/i915: Remove intel_psr_is_enabled function Rodrigo Vivi
2014-11-20 5:56 ` R, Durgadoss
2014-11-20 10:22 ` Rodrigo Vivi
2014-11-21 13:12 ` shuang.he
2014-11-21 18:29 ` Daniel Vetter
2014-11-21 11:35 ` Rodrigo Vivi
2014-11-21 18:28 ` shuang.he
2014-11-21 13:14 ` shuang.he
2014-11-14 16:52 ` [PATCH 10/15] drm/i915: Add PSR registers for PSR VLV/CHV Rodrigo Vivi
2014-11-18 18:27 ` R, Durgadoss
2014-11-14 16:52 ` [PATCH 11/15] drm/i915: PSR VLV/CHV: Introduce setup, enable and disable functions Rodrigo Vivi
2014-11-18 18:32 ` R, Durgadoss
2014-11-19 18:20 ` Rodrigo Vivi
2014-11-19 19:22 ` R, Durgadoss
2014-11-19 15:37 ` [PATCH] " Rodrigo Vivi
2014-11-20 5:54 ` R, Durgadoss
2014-11-19 22:30 ` [PATCH 11/15] " Rodrigo Vivi
2014-11-14 16:52 ` [PATCH 12/15] drm/i915: VLV/CHV PSR Software timer mode Rodrigo Vivi
2014-11-18 18:36 ` R, Durgadoss
2014-11-19 15:37 ` [PATCH] " Rodrigo Vivi
2014-11-20 5:52 ` R, Durgadoss
2014-11-14 16:52 ` [PATCH 13/15] drm/i915: VLV/CHV PSR: Increase wait delay time before active PSR Rodrigo Vivi
2014-11-18 18:37 ` R, Durgadoss
2014-11-19 15:38 ` [PATCH] " Rodrigo Vivi
2014-11-21 18:45 ` Daniel Vetter
2014-11-21 22:00 ` Vivi, Rodrigo
2014-11-24 9:22 ` Daniel Vetter
2014-11-22 9:28 ` [PATCH] drm/i915: VLV/CHV PSR: Increase wait delay time shuang.he
2014-11-14 16:52 ` [PATCH 14/15] drm/i915: VLV/CHV PSR debugfs Rodrigo Vivi
2014-11-18 18:40 ` R, Durgadoss
2014-11-14 16:52 ` [PATCH 15/15] drm/i915: Enable PSR for Baytrail and Braswell Rodrigo Vivi
2014-11-15 9:47 ` [PATCH 15/15] drm/i915: Enable PSR for Baytrail and shuang.he
2014-11-17 18:18 ` [PATCH 15/15] drm/i915: Enable PSR for Baytrail and Braswell Daniel Vetter
2014-11-17 18:30 ` Rodrigo Vivi
2014-11-17 18:51 ` Daniel Vetter
2014-11-17 19:12 ` Rodrigo Vivi
2014-11-17 20:18 ` Daniel Vetter
2014-11-20 17:25 ` Rodrigo Vivi
2014-11-20 17:58 ` R, Durgadoss
2014-11-20 11:44 ` [PATCH] " Rodrigo Vivi
2014-11-22 17:08 ` shuang.he
2014-11-17 18:14 ` [PATCH 01/15] drm/i915: Make dp aux pack/unpack public outside intel_dp.c Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150210192606.GD8920@strange.ger.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox