Re: [PATCH] tests/kms_addfb: Add support for fb modifiers

[Daniel Vetter <daniel@ffwll.ch>]

On Wed, Feb 11, 2015 at 09:51:22AM +0000, Tvrtko Ursulin wrote:
> 
> On 02/11/2015 08:15 AM, Daniel Vetter wrote:
> >On Tue, Feb 10, 2015 at 05:17:34PM +0000, Tvrtko Ursulin wrote:
> >>From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >>
> >>Just a few basic tests to make sure fb modifiers can be used and
> >>behave sanely when mixed with the old set_tiling API.
> >>
> >>v2:
> >>    * Review feedback from Daniel Vetter:
> >>       1. Move cap detection into the subtest so skipping works.
> >>       2. Added some gtkdoc comments.
> >>       3. Two more test cases.
> >>       4. Removed unused parts for now.
> >>
> >>v3:
> >>    * Removed two tests which do not make sense any more after the
> >>      fb modifier rewrite.
> >>
> >>Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >>---
> >>  lib/ioctl_wrappers.c | 17 +++++++++++++
> >>  lib/ioctl_wrappers.h | 37 ++++++++++++++++++++++++++++
> >>  tests/kms_addfb.c    | 68 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> >>  3 files changed, 122 insertions(+)
> >>
> >>diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
> >>index 19a457a..0a7841a 100644
> >>--- a/lib/ioctl_wrappers.c
> >>+++ b/lib/ioctl_wrappers.c
> >>@@ -1091,3 +1091,20 @@ int gem_context_has_param(int fd, uint64_t param)
> >>
> >>  	return gem_context_get_param(fd, &p) == 0;
> >>  }
> >>+
> >>+void igt_require_fb_modifiers(int fd)
> >
> >gtkdoc is missing here.
> 
> It's in the header - has to be in .c ?

Yeah we generally put them all into the .c file. Increases the chance that
when someone changes the code they update docs. And having them all
together makes it easier to keep the wording consistent for same concepts.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx