From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/i915: Reject garbage in unsed ctx create/destroy fields
Date: Wed, 11 Feb 2015 12:28:17 +0100 [thread overview]
Message-ID: <20150211112817.GP24485@phenom.ffwll.local> (raw)
In-Reply-To: <20150211100133.GI18032@nuc-i3427.alporthouse.com>
On Wed, Feb 11, 2015 at 10:01:33AM +0000, Chris Wilson wrote:
> On Wed, Feb 11, 2015 at 08:44:47AM +0100, Daniel Vetter wrote:
> > Forgotten ever since, but luckily we're at least good at memset.
> >
> > Testecase: igt/gem_ctx_create/invalid-pad
> > Testecase: igt/gem_ctx_bad_destroy/invalid-pad
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
>
> I wonder if we used mbz instead of pad, we would have a slightly more
> obvious reminder to zero the fields.
>
> Looks like pad is only cleared fortuituosly in current userspace though.
Oops, VG_CLEAR isn't as good as I've thought. Time to write more patches I
guess. But I expect that most compile libdrm with valgrind support, so I
still think we could try this out for 3.21 and see what happens ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-02-11 11:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 7:44 [PATCH] drm/i915: Reject garbage in unsed ctx create/destroy fields Daniel Vetter
2015-02-11 10:01 ` Chris Wilson
2015-02-11 11:28 ` Daniel Vetter [this message]
2015-02-11 14:00 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150211112817.GP24485@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox