From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 02/10] drm/i915: Make intel_ring_setup_status_page() static
Date: Wed, 11 Feb 2015 17:05:22 +0100 [thread overview]
Message-ID: <20150211160521.GV24485@phenom.ffwll.local> (raw)
In-Reply-To: <20150211134619.GC2885@strange.ger.corp.intel.com>
On Wed, Feb 11, 2015 at 01:46:19PM +0000, Damien Lespiau wrote:
> On Tue, Feb 10, 2015 at 07:32:17PM +0000, Damien Lespiau wrote:
> > This function is only used in intel_ringbuffer.c, so restrict it to that
> > file. The function was moved around to avoid a forward declaration and
> > group it with its user.
> >
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_ringbuffer.c | 124 ++++++++++++++++----------------
> > drivers/gpu/drm/i915/intel_ringbuffer.h | 1 -
> > 2 files changed, 62 insertions(+), 63 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> > index 0631780..0a7b1af 100644
> > --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> > +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> > @@ -502,6 +502,68 @@ static void ring_setup_phys_status_page(struct intel_engine_cs *ring)
> > I915_WRITE(HWS_PGA, addr);
> > }
> >
> > +void intel_ring_setup_status_page(struct intel_engine_cs *ring)
> > +{
>
> I've actually manged to screw this one up. Daniel could you ammend this?
> or do you want a new patch? (fengguang's 0day bot even generated a patch
> for us).
Already squashed in the 0day bot bugfix ;-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-02-11 16:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 19:32 [PATCH 00/10] Random cleanups Damien Lespiau
2015-02-10 19:32 ` [PATCH 01/10] drm/i915: Garbage collect orphaned prototypes Damien Lespiau
2015-02-10 19:32 ` [PATCH 02/10] drm/i915: Make intel_ring_setup_status_page() static Damien Lespiau
2015-02-11 13:46 ` Damien Lespiau
2015-02-11 16:05 ` Daniel Vetter [this message]
2015-02-10 19:32 ` [PATCH 03/10] drm/i915: Remove intel_dsi_cmd.h Damien Lespiau
2015-02-11 9:15 ` Jani Nikula
2015-02-10 19:32 ` [PATCH 04/10] drm/i915: Make intel_lr_context_render_state_init() static Damien Lespiau
2015-02-10 19:32 ` [PATCH 05/10] drm/i915: Make intel_logical_ring_begin() static Damien Lespiau
2015-02-10 19:32 ` [PATCH 06/10] drm/i915: Make intel_logical_ring_advance_and_submit() static Damien Lespiau
2015-02-10 19:32 ` [PATCH 07/10] drm/i915: Make intel_dp_check_link_status() static Damien Lespiau
2015-02-10 19:32 ` [PATCH 08/10] drm/i915: Make intel_dp_unpack_aux() static Damien Lespiau
2015-02-10 19:32 ` [PATCH 09/10] drm/i915: MAke intel_unpin_fb_obj() static Damien Lespiau
2015-02-10 19:32 ` [PATCH 10/10] drm/i915: Remove the IS_SNB_G1 define Damien Lespiau
2015-02-11 11:35 ` shuang.he
2015-02-11 8:12 ` [PATCH 00/10] Random cleanups Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150211160521.GV24485@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=damien.lespiau@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox