From: Damien Lespiau <damien.lespiau@intel.com>
To: "Goel, Akash" <akash.goel@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/7] drm/i915/skl: Added new macros
Date: Tue, 17 Feb 2015 15:26:01 +0000 [thread overview]
Message-ID: <20150217152601.GA26302@strange.ger.corp.intel.com> (raw)
In-Reply-To: <8BF5CF93467D8C498F250C96583BC09C10D0D2B6@BGSMSX103.gar.corp.intel.com>
How about GT_INTERVAL_FROM_US()? GT_EVALUATION_COUNTER_FROM_US()?
something along these lines I guess.
--
Damien
On Tue, Feb 17, 2015 at 03:20:53PM +0000, Goel, Akash wrote:
> Thanks for the review. Agree it's not an appropriate name.
> Please kindly suggest one.
> 'GT_TIME_COUNTER_UNITS_FROM_PERIOD' ??
>
> Best regards
> Akash
>
> -----Original Message-----
> From: Lespiau, Damien
> Sent: Tuesday, February 17, 2015 8:10 PM
> To: Goel, Akash
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [PATCH 1/7] drm/i915/skl: Added new macros
>
> On Fri, Feb 06, 2015 at 08:26:32PM +0530, akash.goel@intel.com wrote:
> > +#define FREQ_1_28_US(us) (((us) * 100) >> 7)
> > +#define FREQ_1_33_US(us) (((us) * 3) >> 2)
> > +#define GT_FREQ_FROM_PERIOD(us, dev) (IS_GEN9(dev) ? \
> > + FREQ_1_33_US(us) : \
> > + FREQ_1_28_US(us))
>
> I'm not sure why you call that GT_FREQ when it looks like a time for evaluation intervals.
>
> --
> Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-02-17 15:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 14:56 [PATCH 0/7] Added missing changes for Turbo feature on SKL akash.goel
2015-02-06 14:56 ` [PATCH 1/7] drm/i915/skl: Added new macros akash.goel
2015-02-16 19:05 ` Damien Lespiau
2015-02-17 14:40 ` Damien Lespiau
2015-02-17 15:20 ` Goel, Akash
2015-02-17 15:26 ` Damien Lespiau [this message]
2015-02-17 15:32 ` Goel, Akash
2015-02-23 16:21 ` Daniel Vetter
2015-02-23 16:22 ` Damien Lespiau
2015-02-06 14:56 ` [PATCH 2/7] drm/i915/skl: Updated the gen6_set_rps function akash.goel
2015-02-17 14:31 ` Damien Lespiau
2015-02-17 15:08 ` Damien Lespiau
2015-02-06 14:56 ` [PATCH 3/7] drm/i915/skl: Restructured the gen6_set_rps_thresholds function akash.goel
2015-02-06 15:48 ` Chris Wilson
2015-02-09 4:51 ` Akash Goel
2015-02-06 14:56 ` [PATCH 4/7] drm/i915/skl: Updated the gen6_rps_limits function akash.goel
2015-02-06 15:43 ` Chris Wilson
2015-02-09 4:56 ` Akash Goel
2015-02-09 11:03 ` Chris Wilson
2015-02-09 11:33 ` Akash Goel
2015-02-17 14:44 ` Damien Lespiau
2015-02-17 15:01 ` Damien Lespiau
2015-02-17 15:10 ` Damien Lespiau
2015-02-06 14:56 ` [PATCH 5/7] drm/i915/skl: Updated the gen9_enable_rps function akash.goel
2015-02-17 15:47 ` Damien Lespiau
2015-02-18 4:59 ` Akash Goel
2015-02-06 14:56 ` [PATCH 6/7] drm/i915/skl: Updated the 'i915_frequency_info' debugs function akash.goel
2015-02-17 15:38 ` Damien Lespiau
2015-02-18 6:47 ` Akash Goel
2015-02-06 14:56 ` [PATCH 7/7] drm/i915/skl: Enabling processing of Turbo interrupts akash.goel
2015-02-06 19:40 ` shuang.he
2015-02-17 15:38 ` Damien Lespiau
2015-02-17 15:51 ` [PATCH 0/7] Added missing changes for Turbo feature on SKL Damien Lespiau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150217152601.GA26302@strange.ger.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=akash.goel@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox