From: Daniel Vetter <daniel@ffwll.ch>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: Ander Conselvan de Oliveira
<ander.conselvan.de.oliveira@intel.com>,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Fix the CRTC_STEREO_DOUBLE_ONLY define to include stero modes
Date: Sun, 22 Feb 2015 12:56:39 +0100 [thread overview]
Message-ID: <20150222115639.GR24485@phenom.ffwll.local> (raw)
In-Reply-To: <20150217180527.GV25792@intel.com>
On Tue, Feb 17, 2015 at 10:05:27AM -0800, Matt Roper wrote:
> On Mon, Feb 16, 2015 at 03:12:31PM +0000, Damien Lespiau wrote:
> > The CRTC_STEREO_DOUBLE_ONLY define was introduced in commit:
> >
> > commit ecb7e16bf187bc369cf6a5cd108582c01329980d
> > Author: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > Date: Mon Dec 1 15:40:09 2014 -0800
> >
> > drm: add helper to get crtc timings (v5)
> >
> > but if we want the stereo h/v adjustments, we need to set the
> > CRTC_STEREO_DOUBLE flag. Otherwise, we'll get the wrong h/v for frame packing
> > stereo 3d modes.
> >
> > Cc: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > Cc: Matt Roper <matthew.d.roper@intel.com>
> > Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
>
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Applied to drm-misc, thanks for patch&review. Yay for no-one using stereo
mode and yay for lack of igt :(
-Daniel
>
> > ---
> > include/drm/drm_modes.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h
> > index d92f6dd..0616188 100644
> > --- a/include/drm/drm_modes.h
> > +++ b/include/drm/drm_modes.h
> > @@ -92,7 +92,7 @@ enum drm_mode_status {
> > #define CRTC_STEREO_DOUBLE (1 << 1) /* adjust timings for stereo modes */
> > #define CRTC_NO_DBLSCAN (1 << 2) /* don't adjust doublescan */
> > #define CRTC_NO_VSCAN (1 << 3) /* don't adjust doublescan */
> > -#define CRTC_STEREO_DOUBLE_ONLY (CRTC_NO_DBLSCAN | CRTC_NO_VSCAN)
> > +#define CRTC_STEREO_DOUBLE_ONLY (CRTC_STEREO_DOUBLE | CRTC_NO_DBLSCAN | CRTC_NO_VSCAN)
> >
> > #define DRM_MODE_FLAG_3D_MAX DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALF
> >
> > --
> > 1.8.3.1
> >
>
> --
> Matt Roper
> Graphics Software Engineer
> IoTG Platform Enabling & Development
> Intel Corporation
> (916) 356-2795
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-02-22 11:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 15:12 [PATCH] drm: Fix the CRTC_STEREO_DOUBLE_ONLY define to include stero modes Damien Lespiau
2015-02-17 0:41 ` shuang.he
2015-02-17 18:05 ` Matt Roper
2015-02-22 11:56 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150222115639.GR24485@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ander.conselvan.de.oliveira@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox