Re: [PATCH 1/7] drm/i915/skl: Added new macros

[Daniel Vetter <daniel@ffwll.ch>]

On Tue, Feb 17, 2015 at 03:32:35PM +0000, Goel, Akash wrote:
> Will prefer GT_INTERVAL_FROM_US, as GT_EVALUATION_COUNTER_FROM_US would be more specific.

Is there a new patch with revised #defines? I haven't yet caught up with
mail ...
-Daniel

> 
> Best regards
> Akash
> 
> -----Original Message-----
> From: Lespiau, Damien 
> Sent: Tuesday, February 17, 2015 8:56 PM
> To: Goel, Akash
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [PATCH 1/7] drm/i915/skl: Added new macros
> 
> How about GT_INTERVAL_FROM_US()? GT_EVALUATION_COUNTER_FROM_US()?
> something along these lines I guess.
> 
> -- 
> Damien
> 
> On Tue, Feb 17, 2015 at 03:20:53PM +0000, Goel, Akash wrote:
> > Thanks for the review. Agree it's not an appropriate name. 
> > Please kindly suggest one.  
> > 'GT_TIME_COUNTER_UNITS_FROM_PERIOD' ??
> > 
> > Best regards
> > Akash
> > 
> > -----Original Message-----
> > From: Lespiau, Damien 
> > Sent: Tuesday, February 17, 2015 8:10 PM
> > To: Goel, Akash
> > Cc: intel-gfx@lists.freedesktop.org
> > Subject: Re: [PATCH 1/7] drm/i915/skl: Added new macros
> > 
> > On Fri, Feb 06, 2015 at 08:26:32PM +0530, akash.goel@intel.com wrote:
> > > +#define FREQ_1_28_US(us)	(((us) * 100) >> 7)
> > > +#define FREQ_1_33_US(us)	(((us) * 3)   >> 2)
> > > +#define GT_FREQ_FROM_PERIOD(us, dev) (IS_GEN9(dev) ? \
> > > +				FREQ_1_33_US(us) : \
> > > +				FREQ_1_28_US(us))
> > 
> > I'm not sure why you call that GT_FREQ when it looks like a time for evaluation intervals.
> > 
> > --
> > Damien
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx