From: Daniel Vetter <daniel@ffwll.ch>
To: Thomas Wood <thomas.wood@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 1/4] tests: improve pipe enumeration
Date: Tue, 24 Feb 2015 00:47:11 +0100 [thread overview]
Message-ID: <20150223234711.GC24485@phenom.ffwll.local> (raw)
In-Reply-To: <1424279176-5000-1-git-send-email-thomas.wood@intel.com>
On Wed, Feb 18, 2015 at 05:06:13PM +0000, Thomas Wood wrote:
> Signed-off-by: Thomas Wood <thomas.wood@intel.com>
> ---
> tests/kms_flip_event_leak.c | 2 +-
> tests/kms_plane.c | 2 +-
> tests/kms_universal_plane.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_flip_event_leak.c b/tests/kms_flip_event_leak.c
> index 8a5e6db..ea4ce4c 100644
> --- a/tests/kms_flip_event_leak.c
> +++ b/tests/kms_flip_event_leak.c
> @@ -119,7 +119,7 @@ igt_simple_main
>
> igt_display_init(&data.display, data.drm_fd);
>
> - for (pipe = 0; pipe < 3; pipe++) {
> + for_each_pipe(&data.display, pipe) {
> for_each_connected_output(&data.display, output) {
> if (test(&data, pipe, output))
> valid_tests++;
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index c94eac0..8a08f20 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -399,7 +399,7 @@ igt_main
> igt_display_init(&data.display, data.drm_fd);
> }
>
> - for (int pipe = 0; pipe < 3; pipe++)
> + for (int pipe = 0; pipe < I915_MAX_PIPES; pipe++)
Should we maybe add a for_each_possible_pipe for this kind of stuff?
Just an idea, but should be quick to implement if we also add a new
semantic patch to lib/igt.cocci to match it.
-Daniel
> run_tests_for_pipe(&data, pipe);
>
> igt_fixture {
> diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
> index 04ff840..6a05584 100644
> --- a/tests/kms_universal_plane.c
> +++ b/tests/kms_universal_plane.c
> @@ -569,7 +569,7 @@ igt_main
> igt_require(data.display.has_universal_planes);
> }
>
> - for (int pipe = 0; pipe < 3; pipe++)
> + for (int pipe = 0; pipe < I915_MAX_PIPES; pipe++)
> run_tests_for_pipe(&data, pipe);
>
> igt_fixture {
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-02-23 23:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 17:06 [PATCH i-g-t 1/4] tests: improve pipe enumeration Thomas Wood
2015-02-18 17:06 ` [PATCH i-g-t 2/4] lib: use defines for igt_simple_init and igt_subtest_init Thomas Wood
2015-02-23 23:49 ` Daniel Vetter
2015-02-24 9:45 ` Thomas Wood
2015-02-18 17:06 ` [PATCH i-g-t 3/4] lib: remove handled option arguments from argv Thomas Wood
2015-02-18 17:06 ` [PATCH i-g-t 4/4] tests: remove extra file Thomas Wood
2015-02-23 23:47 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150223234711.GC24485@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=thomas.wood@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox