Re: [PATCH] drm/i915/skl: handle all pixel formats in skylake_update_primary_plane()

From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/skl: handle all pixel formats in skylake_update_primary_plane()
Date: Tue, 24 Feb 2015 14:28:40 +0200	[thread overview]
Message-ID: <20150224122840.GL11371@intel.com> (raw)
In-Reply-To: <87385wrcoh.fsf@intel.com>

On Mon, Feb 23, 2015 at 03:15:58PM +0200, Jani Nikula wrote:
> On Mon, 16 Feb 2015, Damien Lespiau <damien.lespiau@intel.com> wrote:
> > On Tue, Feb 10, 2015 at 01:15:49PM +0200, Jani Nikula wrote:
> >> skylake_update_primary_plane() did not handle all pixel formats returned
> >> by skl_format_to_fourcc(). Handle alpha similar to skl_update_plane().
> >> 
> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89052
> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >
> > Given the discussion with Ville, it's quite likely we'll default to
> > alpha blending for pre-multiplied fbs (for plane supporting alpha), even
> > with the blending properties added. In that context, we can provide a
> > single, fixed, (but useful) blending mode before we get to implement the
> > full thing. So:
> >
> > Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
> 
> Pushed to drm-intel-fixes, thanks for the review.

Well, the patch still isn't quite right. intel_primary_formats_gen4[]
defines which formats the core will let slip through into the driver,
and even with this patch we're not handling them all.

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx