Re: [PATCH] drm/i915: Fix frontbuffer false positve.

Matt Roper
2015-02-24T18:45:12Z

On Tue, Feb 24, 2015 at 10:36:32AM -0800, Rodrigo Vivi wrote:
> Atomic bits needs to be set when cursor check function is returning 0
> and intel_crtc is active.
>
> v2: When putting more debug prints I notice the solution was simpler
> than I thought. AMS design is solid, just this return was wrong.
> Sorry for the noise.
>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 8ccf033..5fb83ba 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12198,7 +12198,7 @@ intel_check_cursor_plane(struct drm_plane *plane,
> }
>
> if (fb == crtc->cursor->fb)
> - return 0;
> + goto finish;
>
> if (fb->modifier[0] != DRM_FORMAT_MOD_NONE) {
> DRM_DEBUG_KMS("cursor cannot be tiled\n");
> --
> 2.1.0
>

--
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795