From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Mahesh Kumar <mahesh1.kumar@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915/skl: Make sure to allocate mininum sizes in the DDB
Date: Tue, 24 Feb 2015 21:42:25 +0100 [thread overview]
Message-ID: <20150224204225.GE24485@phenom.ffwll.local> (raw)
In-Reply-To: <20150224175658.GR11371@intel.com>
On Tue, Feb 24, 2015 at 07:56:58PM +0200, Ville Syrjälä wrote:
> On Mon, Feb 09, 2015 at 01:35:10PM +0000, Damien Lespiau wrote:
> > I overlooked the fact that we need to allocate a minimum 8 blocks and
> > that just allocating the planes depending on how much they need to fetch
> > from the DDB in proportion of how much memory bw is necessary for the
> > whole display can lead to cases where we don't respect those minima (and
> > thus overrun).
> >
> > So, instead, start by allocating 8 blocks to each active display plane
> > and then allocate the remaining blocks like before.
> >
> > v2: Rebase on top of -nightly
> >
> > Cc: Mahesh Kumar <mahesh1.kumar@intel.com>
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
>
> OK after reading through the spec the minimum[] thing makes sense, so
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-02-24 20:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 9:36 [PATCH] drm/i915/skl: Add check for minimum allocable Display Data Blocks Kumar, Mahesh
2015-02-09 13:28 ` Damien Lespiau
2015-02-09 13:35 ` [PATCH v2] drm/i915/skl: Make sure to allocate mininum sizes in the DDB Damien Lespiau
2015-02-09 13:56 ` Ville Syrjälä
2015-02-09 13:59 ` Damien Lespiau
2015-02-10 4:09 ` shuang.he
2015-02-24 17:56 ` Ville Syrjälä
2015-02-24 20:42 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150224204225.GE24485@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mahesh1.kumar@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox