From: Daniel Vetter <daniel@ffwll.ch>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 12/12] testdisplay/skl: Add command line options for Yb/Yf tiled fbs
Date: Tue, 24 Feb 2015 22:51:59 +0100 [thread overview]
Message-ID: <20150224215159.GL24485@phenom.ffwll.local> (raw)
In-Reply-To: <1424707075-27605-13-git-send-email-tvrtko.ursulin@linux.intel.com>
On Mon, Feb 23, 2015 at 03:57:55PM +0000, Tvrtko Ursulin wrote:
> From: Damien Lespiau <damien.lespiau@intel.com>
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
testdisplay is a bit an awkward test, mostly used by QA for manual
testing. I think we also need some basic kms_setmode subtest to use the
new tiling modes on skl in one of the automated testcases. Otherwise I
fear this will bitrot fast.
-Daniel
> ---
> tests/testdisplay.c | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/tests/testdisplay.c b/tests/testdisplay.c
> index 64ce4d7..dab9e12 100644
> --- a/tests/testdisplay.c
> +++ b/tests/testdisplay.c
> @@ -51,6 +51,7 @@
>
> #include <cairo.h>
> #include <errno.h>
> +#include <getopt.h>
> #include <math.h>
> #include <stdint.h>
> #include <stdbool.h>
> @@ -71,8 +72,10 @@
> #include <stdlib.h>
> #include <signal.h>
>
> -#define SUBTEST_OPTS 1
> +#define SUBTEST_OPTS 1
> #define HELP_DESCRIPTION 2
> +#define Yb_OPT 3
> +#define Yf_OPT 4
>
> static int tio_fd;
> struct termios saved_tio;
> @@ -544,7 +547,7 @@ int update_display(void)
> return 1;
> }
>
> -static char optstr[] = "3hiaf:s:d:p:mrto:j:";
> +static char optstr[] = "3hiaf:s:d:p:mrto:j:y";
>
> static void __attribute__((noreturn)) usage(char *name, char opt)
> {
> @@ -645,6 +648,8 @@ int main(int argc, char **argv)
> {"run-subtest", 1, 0, SUBTEST_OPTS},
> {"help-description", 0, 0, HELP_DESCRIPTION},
> {"help", 0, 0, 'h'},
> + {"yb", 0, 0, Yb_OPT},
> + {"yf", 0, 0, Yf_OPT},
> { 0, 0, 0, 0 }
> };
>
> @@ -697,6 +702,13 @@ int main(int argc, char **argv)
> case 't':
> tiling = LOCAL_I915_FORMAT_MOD_X_TILED;
> break;
> + case 'y':
> + case Yb_OPT:
> + tiling = LOCAL_I915_FORMAT_MOD_Y_TILED;
> + break;
> + case Yf_OPT:
> + tiling = LOCAL_I915_FORMAT_MOD_Yf_TILED;
> + break;
> case 'r':
> qr_code = 1;
> break;
> --
> 2.3.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-02-24 21:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 15:57 [PATCH i-g-t 00/12] Testing the Y tiled display Tvrtko Ursulin
2015-02-23 15:57 ` [PATCH i-g-t 01/12] tests/kms_addfb: Add support for fb modifiers Tvrtko Ursulin
2015-02-23 15:57 ` [PATCH i-g-t 02/12] lib: Extract igt_buf_write_to_png() from gem_render_copy Tvrtko Ursulin
2015-02-24 21:49 ` Daniel Vetter
2015-02-23 15:57 ` [PATCH i-g-t 03/12] tests/kms_addfb: Y tiled testcases Tvrtko Ursulin
2015-02-23 15:57 ` [PATCH i-g-t 04/12] lib/skl: Add gen9 specific igt_blitter_fast_copy() Tvrtko Ursulin
2015-02-23 15:57 ` [PATCH i-g-t 05/12] lib: Don't give a struct igt_buf * to fast_copy_pitch() Tvrtko Ursulin
2015-02-23 15:57 ` [PATCH i-g-t 06/12] lib: Split two helpers to build fast copy's dword0 and dword1 Tvrtko Ursulin
2015-02-23 15:57 ` [PATCH i-g-t 07/12] lib: Provide a raw version of the gen9 fast copy blits Tvrtko Ursulin
2015-02-23 15:57 ` [PATCH i-g-t 08/12] tiling: Convert framebuffer helpers to use fb modifiers Tvrtko Ursulin
2015-02-23 15:57 ` [PATCH i-g-t 09/12] lib: Add support for new extension to the ADDFB2 ioctl Tvrtko Ursulin
2015-02-23 15:57 ` [PATCH i-g-t 10/12] lib/igt_fb: Use new ADDFB2 extension for new tiling modes Tvrtko Ursulin
2015-02-23 15:57 ` [PATCH i-g-t 11/12] lib: Allow the creation of Ys/Yf tiled FBs Tvrtko Ursulin
2015-02-23 15:57 ` [PATCH i-g-t 12/12] testdisplay/skl: Add command line options for Yb/Yf tiled fbs Tvrtko Ursulin
2015-02-24 21:51 ` Daniel Vetter [this message]
2015-02-25 10:55 ` Tvrtko Ursulin
2015-02-25 15:05 ` Daniel Vetter
2015-02-24 21:53 ` [PATCH i-g-t 00/12] Testing the Y tiled display Daniel Vetter
2015-02-25 10:58 ` Tvrtko Ursulin
2015-02-25 17:08 ` [PATCH v5 01/13] tests/kms_addfb: Add support for fb modifiers Tvrtko Ursulin
2015-02-25 21:17 ` Daniel Vetter
2015-02-25 17:27 ` [PATCH v2 02/12] lib: Extract igt_buf_write_to_png() from gem_render_copy Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150224215159.GL24485@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox