Re: [PATCH i-g-t] lib/igt_kms.c: igt_require -> igt_require_f("two displays required\n")

From: Daniel Vetter <daniel@ffwll.ch>
To: Marc Herbert <marc.herbert@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] lib/igt_kms.c: igt_require -> igt_require_f("two displays required\n")
Date: Fri, 27 Feb 2015 16:06:56 +0100	[thread overview]
Message-ID: <20150227150656.GL24485@phenom.ffwll.local> (raw)
In-Reply-To: <1425005023-5041-1-git-send-email-marc.herbert@intel.com>

On Thu, Feb 26, 2015 at 06:43:43PM -0800, Marc Herbert wrote:
> The bare "Test requirement: modes" message is too cryptic, I had to go and
> read the source code to understand the missing requirement.
> 
> Signed-off-by: Marc Herbert <marc.herbert@intel.com>

Nice one, applied.

Thanks, Daniel
> ---
> 
> If there is a different message that you would like to push yourself
> then please don't mind me - I think ANY message would do.
> 
>  tests/kms_flip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index b843478..cae02e9 100644
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -1544,7 +1544,7 @@ static int run_pair(int duration, int flags)
>  
>  	/* If we have fewer than 2 connected outputs then we won't have any
>  	 * configuration at all. So skip in that case. */
> -	igt_require(modes);
> +	igt_require_f(modes, "At least two displays required\n");
>  	duration = duration * 1000 / modes;
>  	duration = max(duration, 500);
>  
> -- 
> 1.9.3
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx