From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/i915: Move watermark handling to intel_wm.c
Date: Mon, 2 Mar 2015 18:47:05 +0100 [thread overview]
Message-ID: <20150302174705.GD24485@phenom.ffwll.local> (raw)
In-Reply-To: <20150227185139.GU11371@intel.com>
On Fri, Feb 27, 2015 at 08:51:39PM +0200, Ville Syrjälä wrote:
> On Fri, Feb 27, 2015 at 07:47:46PM +0100, Daniel Vetter wrote:
> > On Fri, Feb 27, 2015 at 08:21:07PM +0200, Ville Syrjälä wrote:
> > > On Fri, Feb 27, 2015 at 08:54:19AM -0800, Matt Roper wrote:
> > > > Move watermark handling from intel_pm.c to intel_wm.c and add a little
> > > > bit of kerneldoc to exported functions. We also add a new
> > > > intel_init_wm() function to setup memory timing information and
> > > > initialize the relevant watermark vfuncs.
> > >
> > > How about delaying gratious code movement until a bunch of the in flight
> > > WM stuff has landed? This is just going to cause rebase pains all over.
> >
> > Hand-editing diffs works reasonable well ime for these kinds of extraction
> > patches. At least that's how I've done it with -internal. And git rebase
> > can sometimes help too if you crank up the rename detection threshold.
>
> All pointless extra work. Moving the code doesn't make it any better so
> I fail to see why it needs to be rushed in.
File extraction is for kerneldoc, because kerneldoc sucks. I agree it
doesn't really make the code itself better.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-02 17:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 16:54 [PATCH 0/3] Watermark atomic fixes Matt Roper
2015-02-27 16:54 ` [PATCH 1/3] drm/i915: Move watermark handling to intel_wm.c Matt Roper
2015-02-27 18:21 ` Ville Syrjälä
2015-02-27 18:47 ` Daniel Vetter
2015-02-27 18:51 ` Ville Syrjälä
2015-03-02 17:47 ` Daniel Vetter [this message]
2015-02-27 16:54 ` [PATCH 2/3] drm/i915: Kill intel_crtc->cursor_{width, height} Matt Roper
2015-02-27 16:54 ` [PATCH 3/3] drm/i915: Use plane->state->fb in watermark code Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150302174705.GD24485@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox