From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 06/23] drm/i915: Add an optional atomic state argument to intel_set_mode() Date: Wed, 4 Mar 2015 16:41:41 +0100 Message-ID: <20150304154141.GC18775@phenom.ffwll.local> References: <1425388937-1247-1-git-send-email-ander.conselvan.de.oliveira@intel.com> <1425388937-1247-7-git-send-email-ander.conselvan.de.oliveira@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTP id D918A6E684 for ; Wed, 4 Mar 2015 07:40:32 -0800 (PST) Received: by widex7 with SMTP id ex7so31737830wid.4 for ; Wed, 04 Mar 2015 07:40:32 -0800 (PST) Content-Disposition: inline In-Reply-To: <1425388937-1247-7-git-send-email-ander.conselvan.de.oliveira@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ander Conselvan de Oliveira Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXIgMDMsIDIwMTUgYXQgMDM6MjI6MDBQTSArMDIwMCwgQW5kZXIgQ29uc2VsdmFu IGRlIE9saXZlaXJhIHdyb3RlOgo+IEluIHRoZSBzZXQgY29uZmlnIG1vZGVzZXQgcGF0aCwgdGhl IGF0b21pYyBzdGF0ZSBpcyB1cGRhdGVkIHdoZW4KPiBjaGFuZ2luZyB0aGUgc3RhZ2VkIGNvbmZp ZyBpbiBpbnRlbF9tb2Rlc2V0X3N0YWdlX291dHB1dF9jb25maWcoKS4gVGhlCj4gbG9hZCBkZXRl Y3QgY29kZSBhbHNvIGNhdXNlcyBhIG1vZGVzZXQsIGJ1dCBpdCBjaGFuZ2VzIHRoZSBzdGFnZWQg Y29uZmlnCj4gYmVmb3JlIGNhbGxpbmcgaW50ZWxfc2V0X21vZGUoKS4gQSBmb2xsb3cgdXAgcGF0 Y2ggd2lsbCBjaGFuZ2UgdGhhdAo+IGZ1bmN0aW9uIHRvIGFsc28gdXBkYXRlIGEgZHJtX2F0b21p Y19zdGF0ZSwgYW5kIGl0IHdpbGwgbmVlZCB0byBiZSBhYmxlCj4gdG8gcGFzcyB0aGF0IHRvIGlu dGVsX3NldF9tb2RlKCkuCj4gCj4gU2lnbmVkLW9mZi1ieTogQW5kZXIgQ29uc2VsdmFuIGRlIE9s aXZlaXJhIDxhbmRlci5jb25zZWx2YW4uZGUub2xpdmVpcmFAaW50ZWwuY29tPgoKSG0gZ2l2ZW4g dGhpcyBwYXRjaCBhbmQgdGhlIG5lc3RpbmcgaW4gdGhlIHByZXZpb3VzIG9uZSBtYXliZSB3ZSBz aG91bGQKanVzdCBhZGQgZHJtX2F0b21pY19zdGF0ZSBzY2FmZm9sZGluZyB0byBhbGwgY2FsbGVy cyBvZiBpbnRlbF9zZXRfbW9kZT8KCkxvbmcgdGVybSB3ZSBuZWVkIHRvIHN3aXRjaCBvdmVyIHRo ZSByZXN0b3JlX21vZGUgZnVuY3Rpb24gb3ZlciB0byBhdG9taWMKYW55d2F5IChJIGhhdmUgaWRl YXMgZm9yIGdlbmVyaWMgaGVscGVycyBhbHJlYWR5KS4gQW5kIHRoZSBsb2FkIGRldGVjdApjb2Rl IG5lZWRzIHRvIHN3aXRjaCB0byBhdG9taWMgdG9vIGFueXdheS4KLURhbmllbAoKPiAtLS0KPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgMjkgKysrKysrKysrKysrKysr KystLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDEyIGRl bGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k aXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCA5 N2Q0ZGY1Li4zYzNiNWIyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ IEBAIC04Myw3ICs4Myw4IEBAIHN0YXRpYyB2b2lkIGlyb25sYWtlX3BjaF9jbG9ja19nZXQoc3Ry dWN0IGludGVsX2NydGMgKmNydGMsCj4gIAkJCQkgICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAq cGlwZV9jb25maWcpOwo+ICAKPiAgc3RhdGljIGludCBpbnRlbF9zZXRfbW9kZShzdHJ1Y3QgZHJt X2NydGMgKmNydGMsIHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICptb2RlLAo+IC0JCQkgIGludCB4 LCBpbnQgeSwgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqb2xkX2ZiKTsKPiArCQkJICBpbnQgeCwg aW50IHksIHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKm9sZF9mYiwKPiArCQkJICBzdHJ1Y3QgZHJt X2F0b21pY19zdGF0ZSAqc3RhdGUpOwo+ICBzdGF0aWMgaW50IGludGVsX2ZyYW1lYnVmZmVyX2lu aXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCQkJCSAgc3RydWN0IGludGVsX2ZyYW1lYnVm ZmVyICppZmIsCj4gIAkJCQkgIHN0cnVjdCBkcm1fbW9kZV9mYl9jbWQyICptb2RlX2NtZCwKPiBA QCAtODg1NCw3ICs4ODU1LDcgQEAgcmV0cnk6Cj4gIAkJZ290byBmYWlsOwo+ICAJfQo+ICAKPiAt CWlmIChpbnRlbF9zZXRfbW9kZShjcnRjLCBtb2RlLCAwLCAwLCBmYikpIHsKPiArCWlmIChpbnRl bF9zZXRfbW9kZShjcnRjLCBtb2RlLCAwLCAwLCBmYiwgTlVMTCkpIHsKPiAgCQlEUk1fREVCVUdf S01TKCJmYWlsZWQgdG8gc2V0IG1vZGUgb24gbG9hZC1kZXRlY3QgcGlwZVxuIik7Cj4gIAkJaWYg KG9sZC0+cmVsZWFzZV9mYikKPiAgCQkJb2xkLT5yZWxlYXNlX2ZiLT5mdW5jcy0+ZGVzdHJveShv bGQtPnJlbGVhc2VfZmIpOwo+IEBAIC04ODk4LDcgKzg4OTksNyBAQCB2b2lkIGludGVsX3JlbGVh c2VfbG9hZF9kZXRlY3RfcGlwZShzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICAJ CWludGVsX2VuY29kZXItPm5ld19jcnRjID0gTlVMTDsKPiAgCQlpbnRlbF9jcnRjLT5uZXdfZW5h YmxlZCA9IGZhbHNlOwo+ICAJCWludGVsX2NydGMtPm5ld19jb25maWcgPSBOVUxMOwo+IC0JCWlu dGVsX3NldF9tb2RlKGNydGMsIE5VTEwsIDAsIDAsIE5VTEwpOwo+ICsJCWludGVsX3NldF9tb2Rl KGNydGMsIE5VTEwsIDAsIDAsIE5VTEwsIE5VTEwpOwo+ICAKPiAgCQlpZiAob2xkLT5yZWxlYXNl X2ZiKSB7Cj4gIAkJCWRybV9mcmFtZWJ1ZmZlcl91bnJlZ2lzdGVyX3ByaXZhdGUob2xkLT5yZWxl YXNlX2ZiKTsKPiBAQCAtMTEzMTYsMTkgKzExMzE3LDIxIEBAIHN0YXRpYyBpbnQgaW50ZWxfc2V0 X21vZGVfcGlwZXMoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAKPiAgc3RhdGljIGludCBpbnRl bF9zZXRfbW9kZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gIAkJCSAgc3RydWN0IGRybV9kaXNw bGF5X21vZGUgKm1vZGUsCj4gLQkJCSAgaW50IHgsIGludCB5LCBzdHJ1Y3QgZHJtX2ZyYW1lYnVm ZmVyICpmYikKPiArCQkJICBpbnQgeCwgaW50IHksIHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZi LAo+ICsJCQkgIHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiAgewo+ICAJc3RydWN0 IGRybV9kZXZpY2UgKmRldiA9IGNydGMtPmRldjsKPiAtCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRl ICpzdGF0ZTsKPiAgCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZzsKPiAgCXVu c2lnbmVkIG1vZGVzZXRfcGlwZXMsIHByZXBhcmVfcGlwZXMsIGRpc2FibGVfcGlwZXM7Cj4gIAlp bnQgcmV0ID0gMDsKPiAgCj4gLQlzdGF0ZSA9IGRybV9hdG9taWNfc3RhdGVfYWxsb2MoZGV2KTsK PiAtCWlmICghc3RhdGUpCj4gLQkJcmV0dXJuIC1FTk9NRU07Cj4gKwlpZiAoIXN0YXRlKSB7Cj4g KwkJc3RhdGUgPSBkcm1fYXRvbWljX3N0YXRlX2FsbG9jKGRldik7Cj4gKwkJaWYgKCFzdGF0ZSkK PiArCQkJcmV0dXJuIC1FTk9NRU07Cj4gIAo+IC0Jc3RhdGUtPmFjcXVpcmVfY3R4ID0gZGV2LT5t b2RlX2NvbmZpZy5hY3F1aXJlX2N0eDsKPiArCQlzdGF0ZS0+YWNxdWlyZV9jdHggPSBkZXYtPm1v ZGVfY29uZmlnLmFjcXVpcmVfY3R4Owo+ICsJfQo+ICAKPiAgCXBpcGVfY29uZmlnID0gaW50ZWxf bW9kZXNldF9jb21wdXRlX2NvbmZpZyhjcnRjLCBtb2RlLCBmYiwgc3RhdGUsCj4gIAkJCQkJCSAg ICZtb2Rlc2V0X3BpcGVzLAo+IEBAIC0xMTM1Myw3ICsxMTM1Niw4IEBAIG91dDoKPiAgCj4gIHZv aWQgaW50ZWxfY3J0Y19yZXN0b3JlX21vZGUoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ICB7Cj4g LQlpbnRlbF9zZXRfbW9kZShjcnRjLCAmY3J0Yy0+bW9kZSwgY3J0Yy0+eCwgY3J0Yy0+eSwgY3J0 Yy0+cHJpbWFyeS0+ZmIpOwo+ICsJaW50ZWxfc2V0X21vZGUoY3J0YywgJmNydGMtPm1vZGUsIGNy dGMtPngsIGNydGMtPnksIGNydGMtPnByaW1hcnktPmZiLAo+ICsJCSAgICAgICBOVUxMKTsKPiAg fQo+ICAKPiAgI3VuZGVmIGZvcl9lYWNoX2ludGVsX2NydGNfbWFza2VkCj4gQEAgLTExODEzLDcg KzExODE3LDggQEAgZmFpbDoKPiAgCQkvKiBUcnkgdG8gcmVzdG9yZSB0aGUgY29uZmlnICovCj4g IAkJaWYgKGNvbmZpZy0+bW9kZV9jaGFuZ2VkICYmCj4gIAkJICAgIGludGVsX3NldF9tb2RlKHNh dmVfc2V0LmNydGMsIHNhdmVfc2V0Lm1vZGUsCj4gLQkJCQkgICBzYXZlX3NldC54LCBzYXZlX3Nl dC55LCBzYXZlX3NldC5mYikpCj4gKwkJCQkgICBzYXZlX3NldC54LCBzYXZlX3NldC55LCBzYXZl X3NldC5mYiwKPiArCQkJCSAgIE5VTEwpKQo+ICAJCQlEUk1fRVJST1IoImZhaWxlZCB0byByZXN0 b3JlIGNvbmZpZyBhZnRlciBtb2Rlc2V0IGZhaWx1cmVcbiIpOwo+ICAJfQo+ICAKPiBAQCAtMTM4 NTcsNyArMTM4NjIsNyBAQCB2b2lkIGludGVsX21vZGVzZXRfc2V0dXBfaHdfc3RhdGUoc3RydWN0 IGRybV9kZXZpY2UgKmRldiwKPiAgCQkJCWRldl9wcml2LT5waXBlX3RvX2NydGNfbWFwcGluZ1tw aXBlXTsKPiAgCj4gIAkJCWludGVsX3NldF9tb2RlKGNydGMsICZjcnRjLT5tb2RlLCBjcnRjLT54 LCBjcnRjLT55LAo+IC0JCQkJICAgICAgIGNydGMtPnByaW1hcnktPmZiKTsKPiArCQkJCSAgICAg ICBjcnRjLT5wcmltYXJ5LT5mYiwgTlVMTCk7Cj4gIAkJfQo+ICAJfSBlbHNlIHsKPiAgCQlpbnRl bF9tb2Rlc2V0X3VwZGF0ZV9zdGFnZWRfb3V0cHV0X3N0YXRlKGRldik7Cj4gLS0gCj4gMi4xLjAK PiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IElu dGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4g aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoK LS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCis0 MSAoMCkgNzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK