From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 20/23] drm/i915: Use atomic state in pipe_has_enabled_pch() Date: Wed, 4 Mar 2015 16:55:29 +0100 Message-ID: <20150304155529.GE18775@phenom.ffwll.local> References: <1425388937-1247-1-git-send-email-ander.conselvan.de.oliveira@intel.com> <1425388937-1247-21-git-send-email-ander.conselvan.de.oliveira@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by gabe.freedesktop.org (Postfix) with ESMTP id D44526E29F for ; Wed, 4 Mar 2015 07:54:22 -0800 (PST) Received: by wghl18 with SMTP id l18so303380wgh.5 for ; Wed, 04 Mar 2015 07:54:21 -0800 (PST) Content-Disposition: inline In-Reply-To: <1425388937-1247-21-git-send-email-ander.conselvan.de.oliveira@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ander Conselvan de Oliveira Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXIgMDMsIDIwMTUgYXQgMDM6MjI6MTRQTSArMDIwMCwgQW5kZXIgQ29uc2VsdmFu IGRlIE9saXZlaXJhIHdyb3RlOgo+IFRoaXMgZnVuY3Rpb24gaXMgY2FsbGVkIGluZGlyZWN0bHkg YnkgaW50ZWxfY3J0Y19jb21wdXRlX2NvbmZpZygpLAo+IHdoaWNoIG5lZWRzIHRvIGJlIGNvbnZl cnRlZCB0byB3b3JrIG9ubHkgd2l0aCBhbiBhdG9taWMgc3RhdGUuCj4gCj4gLS0tCj4gCj4gSSdt IG5vdCBzdXJlIHdoYXQgYXJlIHRoZSBpbXBsaWNhdGlvbnMgb2YgaWdub3JpbmcgaW50ZWxfY3J0 Yy0+YWN0aXZlIGluCj4gcGlwZV9oYXNfZW5hYmxlZF9wY2goKS4gSWYgd2UgYWxsb3cgYSBjb25m aWcgYmVjYXVzZSB0aGUgdGhpcmQgcGlwZSBpcwo+IGVuYWJsZWQgYnV0IG5vdCBhY3RpdmUsIHdv dWxkbid0IHdlIHJ1biBpbnRvIHRyb3VibGUgd2hlbiB3ZSB0cmllZCB0bwo+IGFjdGl2YXRlIHRo ZSBjcnRjPwoKT25jZSB3ZSBoYXZlIG1vcmUgb2YgYXRvbWljIHJlYWR5IGFuZCBzd2l0Y2hlZCB0 byB0aGUgaGVscGVycyAob3IKc29tZXRoaW5nIGVxdWl2YWxlbnQpIGZvciBlbmFibGluZy9kaXNh YmxpbmcgZGlzcGxheSBwaXBlcyB3ZSBuZWVkIHRvCnJlbW92ZSBvdXIgdXNhZ2Ugb2YgaW50ZWxf Y3J0Yy0+YWN0aXZlLiBNYXliZSBrZWVwIGl0IGFzIGEgZGVidWcgY2hlY2suCgpUaGUgbmV3IHJ1 bGVzIGFyZToKLSBjcnRjX3N0YXRlLT5lbmFibGUgY29udHJvbHMgcmVzb3VyY2UgYWxsb2NhdGlv biwgaS5lLiB0aGlzIGlzIHRoZSBiaXQgd2UKICBuZWVkIHRvIGxvb2sgYXQgZm9yIGNoZWNraW5n IHNoYXJlZCByZXNvdXJjZXMgYW5kIHN0dWZmIGxpa2UgdGhhdC4KLSBjcnRjX3N0YXRlLT5hY3Rp dmUgKGFuZCBhbHNvIGludGVsX2NydGMtPmFjdGl2ZSkgb25seSBjb250cm9sL3RyYWNrIHRoZQog IHBoeXNpY2FsIGFjdGl2ZSBzdGF0ZSBvZiB0aGUgcGlwZSAoY29udHJvbGxlZCBieSBkcG1zIG9y IHRoZSBuZXcgYXRvbWljCiAgYWN0aXZlIHByb3BlcnR5KS4gQ2hhbmdpbmcgY3J0Y19zdGF0ZS0+ YWN0aXZlIG1heSBuZXZlciBmYWlsLgoKSSB0aGluayB5b3VyIGNoYW5nZSBhY3R1YWxseSBmaXhl cyBhIGJ1ZyB3aXRoIHRoZSBmZGkgY29uZmlnIGNoZWNrIGNvZGU6CklmIHRoZSBvdGhlciBwaXBl IGlzIGluIGRwbXMgb2ZmIHdlIG1pZ2h0IHN0ZWFsIHRoZSBmZGkgbGFuZXMgYW5kIHRoZW4gdGhl CnN1YnNlcXVlbnQgZHBtcyBvbiBjb3VsZCBmYWlsLgoKUGVyaGFwcyBzcGxpdCBvdXQgdGhlIHJl bW92YWwgb2YgaW50ZWxfY3J0Yy0+YWN0aXZlIGZyb20gdGhlCmhhc19lbmFibGVkX3BjaCBhcyBh IGJ1Z2ZpeD8gV291bGQgYXQgbGVhc3QgaGVscCB3aXRoIHJldmlldy4KCkl0IHNob3VsZCBiZSBw b3NzaWJsZSB0byByZXByb2R1Y2UgdGhpcyBvbiBhbiBpdmIgd2l0aCB0aGUgZm9sbG93aW5nCnNl cXVlbmNlOgoKMS4gRW5hYmxlIGJpZyBtb2RlICh1c2VzIG1vcmUgdGhhbiAyIGxhbmVzKSBvbiBw aXBlIEIuCjIuIGRwbXMgb2ZmIHBpcGUgQgozLiBFbmFibGUgYmlnIG1vZGUgKHVzZXMgbW9yZSB0 aGFuIDIgbGFuZXMpIG9uIHBpcGUgQy4KNC4gZHBtcyBvbiBwaXBlIEIgc2hvdWxkIGdvIGJvb20g bm93IG9uIG9uZSBvZiB0aGUgRkRJIGNoZWNrcy4KCk1heWJlIHdlIG5lZWQgYW5vdGhlciBtb2Rl c2V0IG9uIHBpcGUgQyB0byBoaXQgdGhlbSB0aG91Z2ggb3Igc29tZXRoaW5nCmxpa2UgdGhhdCwg d2UgZG9uJ3QgaGF2ZSBmdWxsIGNoZWNrcyBpbiB0aGUgZHBtcyBwYXRjaC4KClRoYW5rcywgRGFu aWVsCgo+IAo+IFNpZ25lZC1vZmYtYnk6IEFuZGVyIENvbnNlbHZhbiBkZSBPbGl2ZWlyYSA8YW5k ZXIuY29uc2VsdmFuLmRlLm9saXZlaXJhQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgMjIgKysrKysrKysrKysrKysrLS0tLS0tLQo+ICAx IGZpbGUgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggNjQ3NTFiNi4uNTE4OTAzZSAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtMzE1MCwxMCArMzE1MCw5 IEBAIHN0YXRpYyB2b2lkIGludGVsX2ZkaV9ub3JtYWxfdHJhaW4oc3RydWN0IGRybV9jcnRjICpj cnRjKQo+ICAJCQkgICBGRElfRkVfRVJSQ19FTkFCTEUpOwo+ICB9Cj4gIAo+IC1zdGF0aWMgYm9v bCBwaXBlX2hhc19lbmFibGVkX3BjaChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiArc3RhdGlj IGJvb2wgcGlwZV9oYXNfZW5hYmxlZF9wY2goc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNf c3RhdGUpCj4gIHsKPiAtCXJldHVybiBjcnRjLT5iYXNlLnN0YXRlLT5lbmFibGUgJiYgY3J0Yy0+ YWN0aXZlICYmCj4gLQkJY3J0Yy0+Y29uZmlnLT5oYXNfcGNoX2VuY29kZXI7Cj4gKwlyZXR1cm4g Y3J0Y19zdGF0ZS0+YmFzZS5lbmFibGUgJiYgY3J0Y19zdGF0ZS0+aGFzX3BjaF9lbmNvZGVyOwo+ ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZCBpdmJfbW9kZXNldF9nbG9iYWxfcmVzb3VyY2VzKHN0cnVj dCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiBAQCAtMzE2NCwxNSArMzE2MywyMSBAQCBzdGF0 aWMgdm9pZCBpdmJfbW9kZXNldF9nbG9iYWxfcmVzb3VyY2VzKHN0cnVjdCBkcm1fYXRvbWljX3N0 YXRlICpzdGF0ZSkKPiAgCQl0b19pbnRlbF9jcnRjKGRldl9wcml2LT5waXBlX3RvX2NydGNfbWFw cGluZ1tQSVBFX0JdKTsKPiAgCXN0cnVjdCBpbnRlbF9jcnRjICpwaXBlX0NfY3J0YyA9Cj4gIAkJ dG9faW50ZWxfY3J0YyhkZXZfcHJpdi0+cGlwZV90b19jcnRjX21hcHBpbmdbUElQRV9DXSk7Cj4g KwlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9CX2NydGNfc3RhdGUsICpwaXBlX0NfY3J0 Y19zdGF0ZTsKPiAgCXVpbnQzMl90IHRlbXA7Cj4gIAo+ICsJcGlwZV9CX2NydGNfc3RhdGUgPSBp bnRlbF9hdG9taWNfZ2V0X2NydGNfc3RhdGUoc3RhdGUsIHBpcGVfQl9jcnRjKTsKPiArCXBpcGVf Q19jcnRjX3N0YXRlID0gaW50ZWxfYXRvbWljX2dldF9jcnRjX3N0YXRlKHN0YXRlLCBwaXBlX0Nf Y3J0Yyk7Cj4gKwlpZiAoV0FSTl9PTihJU19FUlIocGlwZV9CX2NydGNfc3RhdGUpIHx8IElTX0VS UihwaXBlX0NfY3J0Y19zdGF0ZSkpKQo+ICsJCXJldHVybjsKPiArCj4gIAkvKgo+ICAJICogV2hl biBldmVyeXRoaW5nIGlzIG9mZiBkaXNhYmxlIGZkaSBDIHNvIHRoYXQgd2UgY291bGQgZW5hYmxl IGZkaSBCCj4gIAkgKiB3aXRoIGFsbCBsYW5lcy4gTm90ZSB0aGF0IHdlIGRvbid0IGNhcmUgYWJv dXQgZW5hYmxlZCBwaXBlcyB3aXRob3V0Cj4gIAkgKiBhbiBlbmFibGVkIHBjaCBlbmNvZGVyLgo+ ICAJICovCj4gLQlpZiAoIXBpcGVfaGFzX2VuYWJsZWRfcGNoKHBpcGVfQl9jcnRjKSAmJgo+IC0J ICAgICFwaXBlX2hhc19lbmFibGVkX3BjaChwaXBlX0NfY3J0YykpIHsKPiArCWlmICghcGlwZV9o YXNfZW5hYmxlZF9wY2gocGlwZV9CX2NydGNfc3RhdGUpICYmCj4gKwkgICAgIXBpcGVfaGFzX2Vu YWJsZWRfcGNoKHBpcGVfQ19jcnRjX3N0YXRlKSkgewo+ICAJCVdBUk5fT04oSTkxNV9SRUFEKEZE SV9SWF9DVEwoUElQRV9CKSkgJiBGRElfUlhfRU5BQkxFKTsKPiAgCQlXQVJOX09OKEk5MTVfUkVB RChGRElfUlhfQ1RMKFBJUEVfQykpICYgRkRJX1JYX0VOQUJMRSk7Cj4gIAo+IEBAIC01NTI4LDYg KzU1MzMsOSBAQCBzdGF0aWMgYm9vbCBpcm9ubGFrZV9jaGVja19mZGlfbGFuZXMoc3RydWN0IGRy bV9kZXZpY2UgKmRldiwgZW51bSBwaXBlIHBpcGUsCj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+ICAJc3RydWN0IGludGVsX2NydGMgKnBp cGVfQl9jcnRjID0KPiAgCQl0b19pbnRlbF9jcnRjKGRldl9wcml2LT5waXBlX3RvX2NydGNfbWFw cGluZ1tQSVBFX0JdKTsKPiArCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX0JfY3J0Y19z dGF0ZSA9Cj4gKwkJaW50ZWxfYXRvbWljX2dldF9jcnRjX3N0YXRlKHBpcGVfY29uZmlnLT5iYXNl LnN0YXRlLAo+ICsJCQkJCSAgICBwaXBlX0JfY3J0Yyk7Cj4gIAo+ICAJRFJNX0RFQlVHX0tNUygi Y2hlY2tpbmcgZmRpIGNvbmZpZyBvbiBwaXBlICVjLCBsYW5lcyAlaVxuIiwKPiAgCQkgICAgICBw aXBlX25hbWUocGlwZSksIHBpcGVfY29uZmlnLT5mZGlfbGFuZXMpOwo+IEBAIC01NTYzLDggKzU1 NzEsOCBAQCBzdGF0aWMgYm9vbCBpcm9ubGFrZV9jaGVja19mZGlfbGFuZXMoc3RydWN0IGRybV9k ZXZpY2UgKmRldiwgZW51bSBwaXBlIHBpcGUsCj4gIAkJfQo+ICAJCXJldHVybiB0cnVlOwo+ICAJ Y2FzZSBQSVBFX0M6Cj4gLQkJaWYgKCFwaXBlX2hhc19lbmFibGVkX3BjaChwaXBlX0JfY3J0Yykg fHwKPiAtCQkgICAgcGlwZV9CX2NydGMtPmNvbmZpZy0+ZmRpX2xhbmVzIDw9IDIpIHsKPiArCQlp ZiAoIXBpcGVfaGFzX2VuYWJsZWRfcGNoKHBpcGVfQl9jcnRjX3N0YXRlKSB8fAo+ICsJCSAgICBw aXBlX0JfY3J0Y19zdGF0ZS0+ZmRpX2xhbmVzIDw9IDIpIHsKPiAgCQkJaWYgKHBpcGVfY29uZmln LT5mZGlfbGFuZXMgPiAyKSB7Cj4gIAkJCQlEUk1fREVCVUdfS01TKCJpbnZhbGlkIHNoYXJlZCBm ZGkgbGFuZSBjb25maWcgb24gcGlwZSAlYzogJWkgbGFuZXNcbiIsCj4gIAkJCQkJICAgICAgcGlw ZV9uYW1lKHBpcGUpLCBwaXBlX2NvbmZpZy0+ZmRpX2xhbmVzKTsKPiAtLSAKPiAyLjEuMAo+IAo+ IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRw Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAK RGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KKzQxICgw KSA3OSAzNjUgNTcgNDggLSBodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=