From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm/i915: Don't require primary->fb in intel_crtc_active() Date: Wed, 4 Mar 2015 20:21:16 +0200 Message-ID: <20150304182116.GV11371@intel.com> References: <1425435313-31711-1-git-send-email-matthew.d.roper@intel.com> <20150304094542.GK11371@intel.com> <20150304161307.GH18775@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 6F8E689C9C for ; Wed, 4 Mar 2015 10:21:21 -0800 (PST) Content-Disposition: inline In-Reply-To: <20150304161307.GH18775@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXIgMDQsIDIwMTUgYXQgMDU6MTM6MDdQTSArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBXZWQsIE1hciAwNCwgMjAxNSBhdCAxMTo0NTo0MkFNICswMjAwLCBWaWxsZSBT eXJqw6Rsw6Qgd3JvdGU6Cj4gPiBPbiBUdWUsIE1hciAwMywgMjAxNSBhdCAwNjoxNToxMlBNIC0w ODAwLCBNYXR0IFJvcGVyIHdyb3RlOgo+ID4gPiBVbml2ZXJzYWwgcGxhbmVzIGFsbG93IHVzIHRv IGhhdmUgYW4gYWN0aXZlIENSVEMgd2l0aG91dCBhIHByaW1hcnkgcGxhbmUKPiA+ID4gZnJhbWVi dWZmZXIgYm91bmQuICBEcm9wIHRoZSB0ZXN0IGZvciBwcmltYXJ5LT5mYiBmcm9tCj4gPiA+IGlu dGVsX2NydGNfYWN0aXZlKCkgc2luY2Ugd2UgY2FuIGNsZWFybHkgaGF2ZSBhY3RpdmUgQ1JUQydz IHdpdGhvdXQgYQo+ID4gPiBmcmFtZWJ1ZmZlciwgYW5kIHRoaXMgY2hlY2sgaXMgbm93IGludGVy ZmVyaW5nIHdpdGggd2F0ZXJtYXJrCj4gPiA+IGNhbGN1bGF0aW9ucyB3aGVuIHdlIHRyeSB0byBy ZS1lbmFibGUgdGhlIHByaW1hcnkgcGxhbmUuCj4gPiA+IAo+ID4gPiBOb3RlIHRoYXQgY29tbWl0 Cj4gPiA+IAo+ID4gPiAgICAgICAgIGNvbW1pdCAwZmRhNjU2ODBlOTI1NDVjYWVhNWJlNzgwNWE3 ZjBhNjE3ZmI2YzIwCj4gPiA+ICAgICAgICAgQXV0aG9yOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtv LnVyc3VsaW5AaW50ZWwuY29tPgo+ID4gPiAgICAgICAgIERhdGU6ICAgRnJpIEZlYiAyNyAxNTox MjozNSAyMDE1ICswMDAwCj4gPiA+IAo+ID4gPiAgICAgICAgICAgICBkcm0vaTkxNS9za2w6IFVw ZGF0ZSB3YXRlcm1hcmtzIGZvciBZIHRpbGluZwo+ID4gPiAKPiA+ID4gYWRkcyBhIHRlc3QgZm9y IHByaW1hcnkgcGxhbmUgZW5hYmxlL2Rpc2FibGUgdG8gdHJpZ2dlciBhIHdhdGVybWFyawo+ID4g PiB1cGRhdGUgKHByZXZpb3VzbHkgd2UgaWdub3JlZCB1cGRhdGVzIHRvIHByaW1hcnkgcGxhbmVz LCB3aGljaCB3YXNuJ3QKPiA+ID4gcmVhbGx5IGNvcnJlY3QsIGJ1dCB3ZSBnb3QgbHVja3kgc2lu Y2Ugd2UgYWx3YXlzIHByZXRlbmRlZCB0aGUgcHJpbWFyeQo+ID4gPiBwbGFuZSB3YXMgb24pLiAg VHZydGtvJ3MgcGF0Y2ggdHJpZXMgdG8gdXBkYXRlIHdhdGVybWFya3Mgd2hlbiB3ZQo+ID4gPiBy ZS1lbmFibGUgdGhlIHByaW1hcnkgcGxhbmUsIGJ1dCB0aGF0IHdhdGVybWFyayBjb21wdXRhdGlv biBnZXRzIGFib3J0ZWQKPiA+ID4gZWFybHkgYmVjYXVzZSBpbnRlbF9jcnRjX2FjdGl2ZSgpIGFs d2F5cyByZXR1cm5zIGZhbHNlIHdoZW4gdGhlIHByaW1hcnkKPiA+ID4gcGxhbmUgaXMgZGlzYWJs ZWQ7IHRoaXMgbGVhZHMgdG8gd2F0ZXJtYXJrIHVuZGVycnVucyAoYXQgbGVhc3Qgb24KPiA+ID4g cGxhdGZvcm1zIHdpdGggSUxLLXN0eWxlIHdhdGVybWFyayBjb2RlKS4KPiA+IAo+ID4gSSB0aGlu ayB0aGlzIHdpbGwgbWFrZSBhIGJ1bmNoIG9mIHRoZSBvbGQgcGxhdGZvcm1zIGJsb3cgdXAuIFdl bGwsIEkKPiA+IHRoaW5rIHRoZXkgbWlnaHQgYWxyZWFkeSBibG93IHVwIHNpbmNlIHRoZXkgbm93 IGxvb2sgYXQgY3J0Yy0+c3RhdGUtPmZiCj4gPiBiYXNlZCBvbiB0aGUgcmVzdWx0IG9mIGludGVs X2NydGNfYWN0aXZlKCkuIFNvIEkgYmVsaWV2ZSBtb3JlIGZpeGVzIGFyZQo+ID4gbmVlZGVkIGFs bCBvdmVyIHRoZSB3bSBjb2RlIGF0IGxlYXN0Lgo+ID4gCj4gPiBJbiBmYWN0IGxvb2tpbmcgYXQg dGhlIGNvZGUsIEkgdGhpbmsgbW9zdCAob3IgYWxsPykgb2YgdGhlIGNhbGwgc2l0ZXMgaW4KPiA+ IHRoZSBpbiB0aGUgaWxrKyB3bSBjb2RlIHNob3VsZCBqdXN0IGJlIHVzaW5nIGNydGMtPmFjdGl2 ZS4gU28gZm9yIHNvbWUKPiA+IGV4dHJhIHNhZmV0eSBpdCBtaWdodCBtYWtlIHNlbnNlIHRvIGRv IGxlYXZlIGludGVsX2NydGNfYWN0aXZlKCkgYWxvbmUKPiA+IGZvciBub3csIG9yIGluIGZhY3Qg d2Ugc2hvdWxkIG1heWJlIGNoYW5nZSBpdCB0byBhbHNvIGxvb2sgYXQKPiA+IHByaW1hcnktPnN0 YXRlLT5mYiBpbnN0ZWFkLiBUaGF0IHNob3VsZCBtb3JlIG9yIGxlc3Mga2VlcCB0aGUgb2xkCj4g PiBwbGF0Zm9ybXMgaW4gdGhlIHNhbWUgc3RhdGUgYXMgdGhleSB3ZXJlIGJlZm9yZSwgd2hpbGUg bGV0dGluZyBuZXcKPiA+IHBsYXRmb3JtcyBoYW5kbGUgZWFjaCBwbGFuZSBwcm9wZXJseS4KPiAK PiBpbnRlbF9jcnRjLT5hY3RpdmUgc2hvdWxkbid0IGJlIHVzZWQgYW55d2hlcmUgaW4gc3RhdGUg Y29tcHV0YXRpb24gY29kZS4KPiBUaGUgb25seSB0aGluZyB5b3UncmUgYWxsb3dlZCB0byBsb29r IGF0IGlzIGNydGNfc3RhdGUtPmVuYWJsZSBpbiB0aGUKPiBhdG9taWMgd29ybGQuCgpXZSdsbCB3 YW50IGNydGMtPmFjdGl2ZSBpbiBhIGJ1bmNoIG9mIHBsYWNlcyBpbiB0aGUgaWxrKyB3bSBjb2Rl CnNpbmNlIGl0J3MgYWN0dWFsbHkgaW50ZXJzdGVkIGluIHRoZSBjdXJyZW50IHN0YXRlLCBub3Qg dGhlIGZ1dHVyZQpzdGF0ZS4KClRoZSB3YXkgaXQgc2hvdWxkIHdvcmsgKGFmdGVyIGdldHRpbmcg bXkgcmVtYWluaW5nIGlsaysgd20gcGF0Y2hlcwpyZXdvcmtlZCttZXJnZWQpOgoKMS4gQ29tcHV0 ZSBuZXcgd2F0ZXJtYXJrcyBmb3IgdGhpcyBzcGVjaWZpYyBwaXBlIHVzaW5nIHRoZSBmdXR1cmUg cGxhbmUvY3J0YyBzdGF0ZS4KICAgV2UgZG9uJ3QgY29uc2lkZXIgYXQgYWxsIGhvdyBtYW55IHBp cGVzIHdpbGwgYmUgYWN0aXZlIG9yIGFyZSBhY3RpdmUgY3VycmVudGx5LAogICBhcyB0aG9zZSBh cmUgbm90IHZhcmlhYmxlcyBpbiBvdXIgYWN0dWFsIHdhdGVybWFyayBlcXVhdGlvbnMuCjIuIEZh aWwgdGhlIG9wZXJhdGlvbiBpZiBMUDAgY29tZXMgb3V0IGludmFsaWQuIExQMCBsaW1pdHMgZG8g bm90IGRlcGVuZAogICBvbiB0aGUgbnVtYmVyIG9mIGFjdGl2ZSBwaXBlcywgc28gYSBmYWlsdXJl IHRvIG1lZXQgdGhlIExQMCBsaW1pdHMgaXMKICAgYWx3YXlzIGZhdGFsLiBMUDErIGxpbWl0cyB3 ZSBjYW4gaWdub3JlIGF0IHRoaXMgc3RhZ2Ugc2luY2UgTFAxKyBhcmUKICAgb3B0aW9uYWwuCjMu IE1lcmdlIHRoZSB3YXRlcm1hcmtzIGNvbXB1dGVkIGF0IHN0ZXAgMSB3aXRoIHRoZSBjdXJyZW50 IHdhdGVybWFya3MKICAgb24gdGhlIHBpcGUgYW5kIHN0b3JlIHRoZSByZXN1bHQgYXMgdGhlIGN1 cnJlbnQgd2F0ZXJtYXJrcyBvbiB0aGlzIHBpcGUuCiAgIFRoZXNlIGFyZSB3aGF0IEkgY2FsbGVk ICJpbnRlcm1lZGlhdGUgd2F0ZXJtYXJrcyIgYW5kIGFyZSBuZWVkZWQgZHVlCiAgIHRvIGxhY2sg b2YgZG91YmxlIGJ1ZmZlcmVkIHdhdGVybWFyayByZWdpc3RlcnMuCjQuIE1lcmdlIHRoZSBjdXJy ZW50IHdhdGVybWFya3MgZnJvbSBhbGwgY3VycmVudGx5IGFjdGl2ZSBwaXBlcywgYXBwbHlpbmcK ICAgd2hhdGV2ZXIgZXh0cmEgbGltaXRzIGFyZSBpbXBvc2VkIGJ5IHRoZSBudW1iZXIgb2YgYWN0 aXZlIHBpcGVzIChlZy4KICAgZGlzYWxsb3cgTFAxKyBvbiBpbGsvc25iL2l2YiB3aXRoIG11bHRp cGxlIHBpcGVzKSBhbmQgd3JpdGUgdGhlIHJlc3VsdAogICB0byB0aGUgaGFyZHdhcmUgcmVnaXN0 ZXJzCjUuIENvbW1pdCB0aGUgcGxhbmUvY3J0YyBzdGF0ZQo2LiBXYWl0IHVudGlsIHRoZSBoYXJk d2FyZSBwbGFuZS9jcnRjIHN0YXRlIGhhcyBjaGFuZ2VkIChpZS4gdW50aWwgdGhlCiAgIG5leHQg dmJsYW5rKQo3LiBTdG9yZSB0aGUgd2F0ZXJtYXJrcyBjb21wdXRlZCBhdCBzdGVwIDEgYXMgdGhl IGN1cnJlbnQgd2F0ZXJtYXJrcwogICBvZiB0aGUgcGlwZSwgcmVwbGFjaW5nIHRoZSAiaW50ZXJt ZWRpYXRlIHdhdGVybWFya3MiIGZyb20gc3RlcCAzCjguIDxzYW1lIGFzIHN0ZXAgND4KClNvIHN0 ZXAgMSBpcyBwcmV0dHkgbXVjaCB0aGUgb25seSBwbGFjZSB3aGVyZSB3ZSBzaG91bGQgY29uc2lk ZXIgdGhlCmZ1dHVyZSBzdGF0ZSBhcyBvcHBvc2VkIHRvIHRoZSBjdXJyZW50IHN0YXRlIG9mIHRo ZSBoYXJkd2FyZS4KIAotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=