From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm/i915: Don't require primary->fb in intel_crtc_active() Date: Thu, 5 Mar 2015 14:48:33 +0200 Message-ID: <20150305124833.GD11371@intel.com> References: <1425435313-31711-1-git-send-email-matthew.d.roper@intel.com> <20150304094542.GK11371@intel.com> <20150304161307.GH18775@phenom.ffwll.local> <20150304182116.GV11371@intel.com> <20150305122017.GW18775@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id E275F6E7AA for ; Thu, 5 Mar 2015 04:48:37 -0800 (PST) Content-Disposition: inline In-Reply-To: <20150305122017.GW18775@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXIgMDUsIDIwMTUgYXQgMDE6MjA6MTdQTSArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBXZWQsIE1hciAwNCwgMjAxNSBhdCAwODoyMToxNlBNICswMjAwLCBWaWxsZSBT eXJqw6Rsw6Qgd3JvdGU6Cj4gPiBPbiBXZWQsIE1hciAwNCwgMjAxNSBhdCAwNToxMzowN1BNICsw MTAwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ID4gPiBPbiBXZWQsIE1hciAwNCwgMjAxNSBhdCAx MTo0NTo0MkFNICswMjAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gPiA+ID4gT24gVHVlLCBN YXIgMDMsIDIwMTUgYXQgMDY6MTU6MTJQTSAtMDgwMCwgTWF0dCBSb3BlciB3cm90ZToKPiA+ID4g PiA+IFVuaXZlcnNhbCBwbGFuZXMgYWxsb3cgdXMgdG8gaGF2ZSBhbiBhY3RpdmUgQ1JUQyB3aXRo b3V0IGEgcHJpbWFyeSBwbGFuZQo+ID4gPiA+ID4gZnJhbWVidWZmZXIgYm91bmQuICBEcm9wIHRo ZSB0ZXN0IGZvciBwcmltYXJ5LT5mYiBmcm9tCj4gPiA+ID4gPiBpbnRlbF9jcnRjX2FjdGl2ZSgp IHNpbmNlIHdlIGNhbiBjbGVhcmx5IGhhdmUgYWN0aXZlIENSVEMncyB3aXRob3V0IGEKPiA+ID4g PiA+IGZyYW1lYnVmZmVyLCBhbmQgdGhpcyBjaGVjayBpcyBub3cgaW50ZXJmZXJpbmcgd2l0aCB3 YXRlcm1hcmsKPiA+ID4gPiA+IGNhbGN1bGF0aW9ucyB3aGVuIHdlIHRyeSB0byByZS1lbmFibGUg dGhlIHByaW1hcnkgcGxhbmUuCj4gPiA+ID4gPiAKPiA+ID4gPiA+IE5vdGUgdGhhdCBjb21taXQK PiA+ID4gPiA+IAo+ID4gPiA+ID4gICAgICAgICBjb21taXQgMGZkYTY1NjgwZTkyNTQ1Y2FlYTVi ZTc4MDVhN2YwYTYxN2ZiNmMyMAo+ID4gPiA+ID4gICAgICAgICBBdXRob3I6IFR2cnRrbyBVcnN1 bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gPiA+ID4gPiAgICAgICAgIERhdGU6ICAg RnJpIEZlYiAyNyAxNToxMjozNSAyMDE1ICswMDAwCj4gPiA+ID4gPiAKPiA+ID4gPiA+ICAgICAg ICAgICAgIGRybS9pOTE1L3NrbDogVXBkYXRlIHdhdGVybWFya3MgZm9yIFkgdGlsaW5nCj4gPiA+ ID4gPiAKPiA+ID4gPiA+IGFkZHMgYSB0ZXN0IGZvciBwcmltYXJ5IHBsYW5lIGVuYWJsZS9kaXNh YmxlIHRvIHRyaWdnZXIgYSB3YXRlcm1hcmsKPiA+ID4gPiA+IHVwZGF0ZSAocHJldmlvdXNseSB3 ZSBpZ25vcmVkIHVwZGF0ZXMgdG8gcHJpbWFyeSBwbGFuZXMsIHdoaWNoIHdhc24ndAo+ID4gPiA+ ID4gcmVhbGx5IGNvcnJlY3QsIGJ1dCB3ZSBnb3QgbHVja3kgc2luY2Ugd2UgYWx3YXlzIHByZXRl bmRlZCB0aGUgcHJpbWFyeQo+ID4gPiA+ID4gcGxhbmUgd2FzIG9uKS4gIFR2cnRrbydzIHBhdGNo IHRyaWVzIHRvIHVwZGF0ZSB3YXRlcm1hcmtzIHdoZW4gd2UKPiA+ID4gPiA+IHJlLWVuYWJsZSB0 aGUgcHJpbWFyeSBwbGFuZSwgYnV0IHRoYXQgd2F0ZXJtYXJrIGNvbXB1dGF0aW9uIGdldHMgYWJv cnRlZAo+ID4gPiA+ID4gZWFybHkgYmVjYXVzZSBpbnRlbF9jcnRjX2FjdGl2ZSgpIGFsd2F5cyBy ZXR1cm5zIGZhbHNlIHdoZW4gdGhlIHByaW1hcnkKPiA+ID4gPiA+IHBsYW5lIGlzIGRpc2FibGVk OyB0aGlzIGxlYWRzIHRvIHdhdGVybWFyayB1bmRlcnJ1bnMgKGF0IGxlYXN0IG9uCj4gPiA+ID4g PiBwbGF0Zm9ybXMgd2l0aCBJTEstc3R5bGUgd2F0ZXJtYXJrIGNvZGUpLgo+ID4gPiA+IAo+ID4g PiA+IEkgdGhpbmsgdGhpcyB3aWxsIG1ha2UgYSBidW5jaCBvZiB0aGUgb2xkIHBsYXRmb3JtcyBi bG93IHVwLiBXZWxsLCBJCj4gPiA+ID4gdGhpbmsgdGhleSBtaWdodCBhbHJlYWR5IGJsb3cgdXAg c2luY2UgdGhleSBub3cgbG9vayBhdCBjcnRjLT5zdGF0ZS0+ZmIKPiA+ID4gPiBiYXNlZCBvbiB0 aGUgcmVzdWx0IG9mIGludGVsX2NydGNfYWN0aXZlKCkuIFNvIEkgYmVsaWV2ZSBtb3JlIGZpeGVz IGFyZQo+ID4gPiA+IG5lZWRlZCBhbGwgb3ZlciB0aGUgd20gY29kZSBhdCBsZWFzdC4KPiA+ID4g PiAKPiA+ID4gPiBJbiBmYWN0IGxvb2tpbmcgYXQgdGhlIGNvZGUsIEkgdGhpbmsgbW9zdCAob3Ig YWxsPykgb2YgdGhlIGNhbGwgc2l0ZXMgaW4KPiA+ID4gPiB0aGUgaW4gdGhlIGlsaysgd20gY29k ZSBzaG91bGQganVzdCBiZSB1c2luZyBjcnRjLT5hY3RpdmUuIFNvIGZvciBzb21lCj4gPiA+ID4g ZXh0cmEgc2FmZXR5IGl0IG1pZ2h0IG1ha2Ugc2Vuc2UgdG8gZG8gbGVhdmUgaW50ZWxfY3J0Y19h Y3RpdmUoKSBhbG9uZQo+ID4gPiA+IGZvciBub3csIG9yIGluIGZhY3Qgd2Ugc2hvdWxkIG1heWJl IGNoYW5nZSBpdCB0byBhbHNvIGxvb2sgYXQKPiA+ID4gPiBwcmltYXJ5LT5zdGF0ZS0+ZmIgaW5z dGVhZC4gVGhhdCBzaG91bGQgbW9yZSBvciBsZXNzIGtlZXAgdGhlIG9sZAo+ID4gPiA+IHBsYXRm b3JtcyBpbiB0aGUgc2FtZSBzdGF0ZSBhcyB0aGV5IHdlcmUgYmVmb3JlLCB3aGlsZSBsZXR0aW5n IG5ldwo+ID4gPiA+IHBsYXRmb3JtcyBoYW5kbGUgZWFjaCBwbGFuZSBwcm9wZXJseS4KPiA+ID4g Cj4gPiA+IGludGVsX2NydGMtPmFjdGl2ZSBzaG91bGRuJ3QgYmUgdXNlZCBhbnl3aGVyZSBpbiBz dGF0ZSBjb21wdXRhdGlvbiBjb2RlLgo+ID4gPiBUaGUgb25seSB0aGluZyB5b3UncmUgYWxsb3dl ZCB0byBsb29rIGF0IGlzIGNydGNfc3RhdGUtPmVuYWJsZSBpbiB0aGUKPiA+ID4gYXRvbWljIHdv cmxkLgo+ID4gCj4gPiBXZSdsbCB3YW50IGNydGMtPmFjdGl2ZSBpbiBhIGJ1bmNoIG9mIHBsYWNl cyBpbiB0aGUgaWxrKyB3bSBjb2RlCj4gPiBzaW5jZSBpdCdzIGFjdHVhbGx5IGludGVyc3RlZCBp biB0aGUgY3VycmVudCBzdGF0ZSwgbm90IHRoZSBmdXR1cmUKPiA+IHN0YXRlLgo+ID4gCj4gPiBU aGUgd2F5IGl0IHNob3VsZCB3b3JrIChhZnRlciBnZXR0aW5nIG15IHJlbWFpbmluZyBpbGsrIHdt IHBhdGNoZXMKPiA+IHJld29ya2VkK21lcmdlZCk6Cj4gPiAKPiA+IDEuIENvbXB1dGUgbmV3IHdh dGVybWFya3MgZm9yIHRoaXMgc3BlY2lmaWMgcGlwZSB1c2luZyB0aGUgZnV0dXJlIHBsYW5lL2Ny dGMgc3RhdGUuCj4gPiAgICBXZSBkb24ndCBjb25zaWRlciBhdCBhbGwgaG93IG1hbnkgcGlwZXMg d2lsbCBiZSBhY3RpdmUgb3IgYXJlIGFjdGl2ZSBjdXJyZW50bHksCj4gPiAgICBhcyB0aG9zZSBh cmUgbm90IHZhcmlhYmxlcyBpbiBvdXIgYWN0dWFsIHdhdGVybWFyayBlcXVhdGlvbnMuCj4gPiAy LiBGYWlsIHRoZSBvcGVyYXRpb24gaWYgTFAwIGNvbWVzIG91dCBpbnZhbGlkLiBMUDAgbGltaXRz IGRvIG5vdCBkZXBlbmQKPiA+ICAgIG9uIHRoZSBudW1iZXIgb2YgYWN0aXZlIHBpcGVzLCBzbyBh IGZhaWx1cmUgdG8gbWVldCB0aGUgTFAwIGxpbWl0cyBpcwo+ID4gICAgYWx3YXlzIGZhdGFsLiBM UDErIGxpbWl0cyB3ZSBjYW4gaWdub3JlIGF0IHRoaXMgc3RhZ2Ugc2luY2UgTFAxKyBhcmUKPiA+ ICAgIG9wdGlvbmFsLgo+ID4gMy4gTWVyZ2UgdGhlIHdhdGVybWFya3MgY29tcHV0ZWQgYXQgc3Rl cCAxIHdpdGggdGhlIGN1cnJlbnQgd2F0ZXJtYXJrcwo+ID4gICAgb24gdGhlIHBpcGUgYW5kIHN0 b3JlIHRoZSByZXN1bHQgYXMgdGhlIGN1cnJlbnQgd2F0ZXJtYXJrcyBvbiB0aGlzIHBpcGUuCj4g PiAgICBUaGVzZSBhcmUgd2hhdCBJIGNhbGxlZCAiaW50ZXJtZWRpYXRlIHdhdGVybWFya3MiIGFu ZCBhcmUgbmVlZGVkIGR1ZQo+ID4gICAgdG8gbGFjayBvZiBkb3VibGUgYnVmZmVyZWQgd2F0ZXJt YXJrIHJlZ2lzdGVycy4KPiA+IDQuIE1lcmdlIHRoZSBjdXJyZW50IHdhdGVybWFya3MgZnJvbSBh bGwgY3VycmVudGx5IGFjdGl2ZSBwaXBlcywgYXBwbHlpbmcKPiA+ICAgIHdoYXRldmVyIGV4dHJh IGxpbWl0cyBhcmUgaW1wb3NlZCBieSB0aGUgbnVtYmVyIG9mIGFjdGl2ZSBwaXBlcyAoZWcuCj4g PiAgICBkaXNhbGxvdyBMUDErIG9uIGlsay9zbmIvaXZiIHdpdGggbXVsdGlwbGUgcGlwZXMpIGFu ZCB3cml0ZSB0aGUgcmVzdWx0Cj4gPiAgICB0byB0aGUgaGFyZHdhcmUgcmVnaXN0ZXJzCj4gPiA1 LiBDb21taXQgdGhlIHBsYW5lL2NydGMgc3RhdGUKPiA+IDYuIFdhaXQgdW50aWwgdGhlIGhhcmR3 YXJlIHBsYW5lL2NydGMgc3RhdGUgaGFzIGNoYW5nZWQgKGllLiB1bnRpbCB0aGUKPiA+ICAgIG5l eHQgdmJsYW5rKQo+ID4gNy4gU3RvcmUgdGhlIHdhdGVybWFya3MgY29tcHV0ZWQgYXQgc3RlcCAx IGFzIHRoZSBjdXJyZW50IHdhdGVybWFya3MKPiA+ICAgIG9mIHRoZSBwaXBlLCByZXBsYWNpbmcg dGhlICJpbnRlcm1lZGlhdGUgd2F0ZXJtYXJrcyIgZnJvbSBzdGVwIDMKPiA+IDguIDxzYW1lIGFz IHN0ZXAgND4KPiA+IAo+ID4gU28gc3RlcCAxIGlzIHByZXR0eSBtdWNoIHRoZSBvbmx5IHBsYWNl IHdoZXJlIHdlIHNob3VsZCBjb25zaWRlciB0aGUKPiA+IGZ1dHVyZSBzdGF0ZSBhcyBvcHBvc2Vk IHRvIHRoZSBjdXJyZW50IHN0YXRlIG9mIHRoZSBoYXJkd2FyZS4KPiAKPiBZZWFoIHRoYXQncyBh IHZhbGlkIHVzZS1jYXNlLCBidXQgeW91IGluc3RlYWQgd2FudCB0byBsb29rIGF0Cj4gY3J0Y19z dGF0ZS0+YWN0aXZlLiBpbnRlbF9jcnRjLT5hY3RpdmUgd2lsbCBqdXN0IGJlIGEgY29uc2lzdGVu Y3kgY2hlY2sgaW4KPiB0aGUgZW5kIHJlYWxseS4gQW5kIHNpbmNlIGNydGNfc3RhdGUtPmFjdGl2 ZSBpcyBzZXQgY29ycmVjdGx5IGV2ZW4gaW4gdGhlCj4gY2hlY2sgcGhhc2Ugb2YgdGhlIG1vZGVz ZXQgd2UgY291bGQgY29tcHV0ZSB0aGUgZmluYWwgd2F0ZXJtYXJrcyByaWdodAo+IGF3YXkuCgpE dXJpbmcgY3J0YyBlbmFibGUvZGlzYWJsZSB3ZSBtYXkgbmVlZCB0byBkbyBhIHdhdGVybWFyayB1 cGRhdGVzIGxpa2Ugc286CgplbmFibGU6CjEuIGFjdGl2ZT10cnVlCjIuIHVwZGF0ZSB3YXRlcm1h cmtzCjMuIGVuYWJsZSBwaXBlCgpkaXNhYmxlOgoxLiBkaXNhYmxlIHBpcGUKMi4gYWN0aXZlPWZh bHNlCjMuIHVwZGF0ZSB3YXRlcm1hcmtzCgpTbyBpZiBjcnRjX3N0YXRlLT5hY3RpdmUgd29ya3Mg Zm9yIHRoYXQgdGhlbiB3ZSBjYW4gdXNlIGl0LgoKQnV0IEkgdGhpbmsgd2Ugc3RpbGwgd2FudCB0 byBrZWVwIGRvaW5nIHdoYXQgSSBsaXN0ZWQgc2luY2Ugd2UgZG9uJ3QKd2FudCB0byBnbyByZWNv bXB1dGluZyB0aGUgd2F0ZXJtYXJrcyBmb3IgZXZlcnkgcGlwZSB3aGVuIG9ubHkgb25lIHBpcGUK bmVlZHMgdXBkYXRpbmcuIEZvciBvbmUsIHRoYXQgd291bGQgaW52b2x2ZSB0YWtpbmcgbG9ja3Mg b24gYWxsIHRoZQpjcnRjcy9wbGFuZXMgd2hpY2ggc291bmRzIGxpa2Ugc29tZXRoaW5nIHRvIGF2 b2lkLiBUaGVyZSBhcmUgYWxzbyBvdGhlcgpmYWN0b3JzIGJlc2lkZXMgdGhlIG51bWJlciBvZiBh Y3RpdmUgcGlwZXMgYWZmZWN0aW5nIGhvdyB3ZSBtZXJnZSB0aGUKd2F0ZXJtYXJrcyBzbyBJIGNh bid0IGFjY2VwdCBhbnkgImJ1dCBhbGwgbG9ja3MgYXJlIGhlbGQgYXQgbW9kZXNldCIKZXhjdXNl IGhlcmUgOikKCklmIHdlIHJlY29tcHV0ZSB0aGUgd2F0ZXJtYXJrcyBvbmx5IGZvciB0aGUgc3Bl Y2lmaWMgcGlwZSB3ZSdyZSBjaGFuZ2luZwp3ZSBhbHJlYWR5IGhhdmUgdGhlIHJlcXVpcmVkIGxv Y2tzLiBBbnkgc2hhcmVkIHdtIHN0YXRlIHdpbGwgYmUgcHJvdGVjdGVkCmJ5IGRldl9wcml2LT53 bS5tdXRleC4KCj4gaW50ZWxfY3J0Yy0+YWN0aXZlIGlzIG9ubHkgc2V0IHdoaWxlIGNvbW1pdHRp bmcgdGhlIHN0YXRlIHRvIGh3Lgo+IAo+IFRoaXMgaXMgaW1wb3J0YW50IGZyb20gYSBsb2NraW5n IHBvdiBzaW5jZSBzdGF0ZSBvYmplY3RzIG11c3QgYmUgaW52YXJpYW50Cj4gb25jZSBjb21taXR0 ZWQgdG8gZm9vLT5zdGF0ZSBwb2ludGVycy4gU28geW91J2QgZW5kIHVwIHdpdGggc29tZQo+IGlu dGVyZXN0aW5nIGJvb2sta2VlcGluZyBwcm9ibGVtcyBJIGV4cGVjdC4gV2UnbGwgc2VlLgo+IC1E YW5pZWwKPiAtLSAKPiBEYW5pZWwgVmV0dGVyCj4gU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENv cnBvcmF0aW9uCj4gKzQxICgwKSA3OSAzNjUgNTcgNDggLSBodHRwOi8vYmxvZy5mZndsbC5jaAoK LS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK