* [PATCH] drm/i915/skl: port A fuse straps don't work on early SKL steppings
@ 2015-03-06 23:53 Jesse Barnes
2015-03-07 0:09 ` Damien Lespiau
2015-03-07 3:21 ` shuang.he
0 siblings, 2 replies; 6+ messages in thread
From: Jesse Barnes @ 2015-03-06 23:53 UTC (permalink / raw)
To: intel-gfx
So try to enumerate eDP unconditionally in those cases.
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
drivers/gpu/drm/i915/intel_display.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 597c10b..8820e8a 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -12563,10 +12563,15 @@ static void intel_setup_outputs(struct drm_device *dev)
if (HAS_DDI(dev)) {
int found;
- /* Haswell uses DDI functions to detect digital outputs */
+ /*
+ * Haswell uses DDI functions to detect digital outputs.
+ * On SKL pre-D0 the strap isn't connected, so we assume
+ * it's there.
+ */
found = I915_READ(DDI_BUF_CTL_A) & DDI_INIT_DISPLAY_DETECTED;
/* DDI A only supports eDP */
- if (found)
+ if (found ||
+ (IS_SKYLAKE(dev) && INTEL_REVID(dev) < SKL_REVID_D0))
intel_ddi_init(dev, PORT_A);
/* DDI B, C and D detection is indicated by the SFUSE_STRAP
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/skl: port A fuse straps don't work on early SKL steppings
2015-03-06 23:53 [PATCH] drm/i915/skl: port A fuse straps don't work on early SKL steppings Jesse Barnes
@ 2015-03-07 0:09 ` Damien Lespiau
2015-03-09 9:03 ` Daniel Vetter
2015-03-07 3:21 ` shuang.he
1 sibling, 1 reply; 6+ messages in thread
From: Damien Lespiau @ 2015-03-07 0:09 UTC (permalink / raw)
To: Jesse Barnes; +Cc: intel-gfx
On Fri, Mar 06, 2015 at 03:53:32PM -0800, Jesse Barnes wrote:
> So try to enumerate eDP unconditionally in those cases.
>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
That's WaIgnoreDDIAStrap, I assumed it actually worked since my eDP
panel was detected... I see it listed without a stepping check but I
guess you have a good source for that one.
So, maybe with the WaIgnoreDDIAStrap mention:
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
--
Damien
> ---
> drivers/gpu/drm/i915/intel_display.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 597c10b..8820e8a 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12563,10 +12563,15 @@ static void intel_setup_outputs(struct drm_device *dev)
> if (HAS_DDI(dev)) {
> int found;
>
> - /* Haswell uses DDI functions to detect digital outputs */
> + /*
> + * Haswell uses DDI functions to detect digital outputs.
> + * On SKL pre-D0 the strap isn't connected, so we assume
> + * it's there.
> + */
> found = I915_READ(DDI_BUF_CTL_A) & DDI_INIT_DISPLAY_DETECTED;
> /* DDI A only supports eDP */
> - if (found)
> + if (found ||
> + (IS_SKYLAKE(dev) && INTEL_REVID(dev) < SKL_REVID_D0))
> intel_ddi_init(dev, PORT_A);
>
> /* DDI B, C and D detection is indicated by the SFUSE_STRAP
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/skl: port A fuse straps don't work on early SKL steppings
2015-03-06 23:53 [PATCH] drm/i915/skl: port A fuse straps don't work on early SKL steppings Jesse Barnes
2015-03-07 0:09 ` Damien Lespiau
@ 2015-03-07 3:21 ` shuang.he
1 sibling, 0 replies; 6+ messages in thread
From: shuang.he @ 2015-03-07 3:21 UTC (permalink / raw)
To: shuang.he, ethan.gao, intel-gfx, jbarnes
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
Task id: 5909
-------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV -5 275/275 270/275
ILK 307/307 307/307
SNB -1 284/284 283/284
IVB 375/375 375/375
BYT 294/294 294/294
HSW 385/385 385/385
BDW -3 314/314 311/314
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
*PNV igt_gen3_render_tiledx_blits FAIL(1)PASS(6) FAIL(1)NRUN(1)
PNV igt_gen3_render_tiledy_blits FAIL(1)PASS(3) FAIL(1)PASS(1)
PNV igt_gem_fence_thrash_bo-write-verify-threaded-none FAIL(1)CRASH(1)PASS(1) CRASH(1)PASS(1)
*PNV igt_gem_partial_pwrite_pread_reads PASS(2) NRUN(1)PASS(1)
*PNV igt_gem_userptr_blits_forked-unsync-multifd-mempressure-normal PASS(2) NRUN(1)
*SNB igt_gem_fence_thrash_bo-write-verify-x PASS(2) DMESG_WARN(1)PASS(1)
*BDW igt_drv_debugfs_reader PASS(4) DMESG_WARN(1)PASS(1)
*BDW igt_drv_hangman_error-state-sysfs-entry PASS(4) TIMEOUT(1)PASS(1)
*BDW igt_gem_gtt_hog PASS(6) DMESG_WARN(1)PASS(1)
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/skl: port A fuse straps don't work on early SKL steppings
2015-03-07 0:09 ` Damien Lespiau
@ 2015-03-09 9:03 ` Daniel Vetter
2015-03-09 15:18 ` Jesse Barnes
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2015-03-09 9:03 UTC (permalink / raw)
To: Damien Lespiau; +Cc: intel-gfx
On Sat, Mar 07, 2015 at 12:09:08AM +0000, Damien Lespiau wrote:
> On Fri, Mar 06, 2015 at 03:53:32PM -0800, Jesse Barnes wrote:
> > So try to enumerate eDP unconditionally in those cases.
> >
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> That's WaIgnoreDDIAStrap, I assumed it actually worked since my eDP
> panel was detected... I see it listed without a stepping check but I
> guess you have a good source for that one.
>
> So, maybe with the WaIgnoreDDIAStrap mention:
Done ...
>
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
>
and applied, thanks.
-Daniel
> --
> Damien
>
> > ---
> > drivers/gpu/drm/i915/intel_display.c | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index 597c10b..8820e8a 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -12563,10 +12563,15 @@ static void intel_setup_outputs(struct drm_device *dev)
> > if (HAS_DDI(dev)) {
> > int found;
> >
> > - /* Haswell uses DDI functions to detect digital outputs */
> > + /*
> > + * Haswell uses DDI functions to detect digital outputs.
> > + * On SKL pre-D0 the strap isn't connected, so we assume
> > + * it's there.
> > + */
> > found = I915_READ(DDI_BUF_CTL_A) & DDI_INIT_DISPLAY_DETECTED;
> > /* DDI A only supports eDP */
> > - if (found)
> > + if (found ||
> > + (IS_SKYLAKE(dev) && INTEL_REVID(dev) < SKL_REVID_D0))
> > intel_ddi_init(dev, PORT_A);
> >
> > /* DDI B, C and D detection is indicated by the SFUSE_STRAP
> > --
> > 1.9.1
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/skl: port A fuse straps don't work on early SKL steppings
2015-03-09 9:03 ` Daniel Vetter
@ 2015-03-09 15:18 ` Jesse Barnes
2015-03-09 15:56 ` Damien Lespiau
0 siblings, 1 reply; 6+ messages in thread
From: Jesse Barnes @ 2015-03-09 15:18 UTC (permalink / raw)
To: Daniel Vetter, Damien Lespiau; +Cc: intel-gfx
On 03/09/2015 02:03 AM, Daniel Vetter wrote:
> On Sat, Mar 07, 2015 at 12:09:08AM +0000, Damien Lespiau wrote:
>> On Fri, Mar 06, 2015 at 03:53:32PM -0800, Jesse Barnes wrote:
>>> So try to enumerate eDP unconditionally in those cases.
>>>
>>> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>>
>> That's WaIgnoreDDIAStrap, I assumed it actually worked since my eDP
>> panel was detected... I see it listed without a stepping check but I
>> guess you have a good source for that one.
>>
>> So, maybe with the WaIgnoreDDIAStrap mention:
>
> Done ...
>>
>> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
>>
> and applied, thanks.
Cool, thanks. I didn't see the wa named in the bspec (or even mentioned
until I pinged Art); I suppose this one came from the wa db?
Thanks,
Jesse
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/skl: port A fuse straps don't work on early SKL steppings
2015-03-09 15:18 ` Jesse Barnes
@ 2015-03-09 15:56 ` Damien Lespiau
0 siblings, 0 replies; 6+ messages in thread
From: Damien Lespiau @ 2015-03-09 15:56 UTC (permalink / raw)
To: Jesse Barnes; +Cc: intel-gfx
On Mon, Mar 09, 2015 at 08:18:05AM -0700, Jesse Barnes wrote:
> On 03/09/2015 02:03 AM, Daniel Vetter wrote:
> > On Sat, Mar 07, 2015 at 12:09:08AM +0000, Damien Lespiau wrote:
> >> On Fri, Mar 06, 2015 at 03:53:32PM -0800, Jesse Barnes wrote:
> >>> So try to enumerate eDP unconditionally in those cases.
> >>>
> >>> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> >>
> >> That's WaIgnoreDDIAStrap, I assumed it actually worked since my eDP
> >> panel was detected... I see it listed without a stepping check but I
> >> guess you have a good source for that one.
> >>
> >> So, maybe with the WaIgnoreDDIAStrap mention:
> >
> > Done ...
> >>
> >> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
> >>
> > and applied, thanks.
>
> Cool, thanks. I didn't see the wa named in the bspec (or even mentioned
> until I pinged Art); I suppose this one came from the wa db?
Indeed.
--
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-09 15:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-06 23:53 [PATCH] drm/i915/skl: port A fuse straps don't work on early SKL steppings Jesse Barnes
2015-03-07 0:09 ` Damien Lespiau
2015-03-09 9:03 ` Daniel Vetter
2015-03-09 15:18 ` Jesse Barnes
2015-03-09 15:56 ` Damien Lespiau
2015-03-07 3:21 ` shuang.he
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox