Re: [PATCH 1/9] drm/i915: Remove debug prints from primary plane update funcs

Jesse Barnes
2015-03-10T15:54:37Z

On 03/10/2015 04:15 AM, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> These are now called from the plane commit hooks, so they really need to
> be fast or else we risk atomic update failures. So kill the debug prints
> which are slowing things down massively.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index c3a5888..1d5107e 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -2658,9 +2658,6 @@ static void i9xx_update_primary_plane(struct drm_crtc *crtc,
>
> I915_WRITE(reg, dspcntr);
>
> - DRM_DEBUG_KMS("Writing base %08lX %08lX %d %d %d\n",
> - i915_gem_obj_ggtt_offset(obj), linear_offset, x, y,
> - fb->pitches[0]);
> I915_WRITE(DSPSTRIDE(plane), fb->pitches[0]);
> if (INTEL_INFO(dev)->gen >= 4) {
> I915_WRITE(DSPSURF(plane),
> @@ -2762,9 +2759,6 @@ static void ironlake_update_primary_plane(struct drm_crtc *crtc,
>
> I915_WRITE(reg, dspcntr);
>
> - DRM_DEBUG_KMS("Writing base %08lX %08lX %d %d %d\n",
> - i915_gem_obj_ggtt_offset(obj), linear_offset, x, y,
> - fb->pitches[0]);
> I915_WRITE(DSPSTRIDE(plane), fb->pitches[0]);
> I915_WRITE(DSPSURF(plane),
> i915_gem_obj_ggtt_offset(obj) + intel_crtc->dspaddr_offset);
> @@ -2890,11 +2884,6 @@ static void skylake_update_primary_plane(struct drm_crtc *crtc,
>
> I915_WRITE(PLANE_CTL(pipe, 0), plane_ctl);
>
> - DRM_DEBUG_KMS("Writing base %08lX %d,%d,%d,%d pitch=%d\n",
> - i915_gem_obj_ggtt_offset(obj),
> - x, y, fb->width, fb->height,
> - fb->pitches[0]);
> -
> I915_WRITE(PLANE_POS(pipe, 0), 0);
> I915_WRITE(PLANE_OFFSET(pipe, 0), (y << 16) | x);
> I915_WRITE(PLANE_SIZE(pipe, 0),
>

Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>