From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 4/9] drm/i915: Make derived plane state correct after crtc_enable Date: Wed, 11 Mar 2015 10:52:29 +0100 Message-ID: <20150311095229.GZ3800@phenom.ffwll.local> References: <1425986129-15547-1-git-send-email-ville.syrjala@linux.intel.com> <1425986129-15547-5-git-send-email-ville.syrjala@linux.intel.com> <20150310170151.GH27526@intel.com> <20150310175713.GJ11371@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-we0-f176.google.com (mail-we0-f176.google.com [74.125.82.176]) by gabe.freedesktop.org (Postfix) with ESMTP id 53E636E80F for ; Wed, 11 Mar 2015 02:50:50 -0700 (PDT) Received: by wesk11 with SMTP id k11so7811104wes.13 for ; Wed, 11 Mar 2015 02:50:49 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20150310175713.GJ11371@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXIgMTAsIDIwMTUgYXQgMDc6NTc6MTNQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFR1ZSwgTWFyIDEwLCAyMDE1IGF0IDEwOjAxOjUxQU0gLTA3MDAsIE1hdHQg Um9wZXIgd3JvdGU6Cj4gPiBPbiBUdWUsIE1hciAxMCwgMjAxNSBhdCAwMToxNToyNFBNICswMjAw LCB2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbSB3cm90ZToKPiA+ID4gRnJvbTogVmlsbGUg U3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+ID4gLXN0YXRpYyB2 b2lkIGRpc2FibGVfcGxhbmVfaW50ZXJuYWwoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUpCj4gPiA+ ICtzdGF0aWMgdm9pZCBfaW50ZWxfY3J0Y19lbmFibGVfcGxhbmVzKHN0cnVjdCBpbnRlbF9jcnRj ICpjcnRjKQo+ID4gPiAgewo+ID4gPiAtCXN0cnVjdCBpbnRlbF9wbGFuZSAqaW50ZWxfcGxhbmUg PSB0b19pbnRlbF9wbGFuZShwbGFuZSk7Cj4gPiA+IC0Jc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAq c3RhdGUgPQo+ID4gPiAtCQlwbGFuZS0+ZnVuY3MtPmF0b21pY19kdXBsaWNhdGVfc3RhdGUocGxh bmUpOwo+ID4gPiAtCXN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqaW50ZWxfc3RhdGUgPSB0b19p bnRlbF9wbGFuZV9zdGF0ZShzdGF0ZSk7Cj4gPiA+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9 IGNydGMtPmJhc2UuZGV2Owo+ID4gPiArCWVudW0gcGlwZSBwaXBlID0gY3J0Yy0+cGlwZTsKPiA+ ID4gKwlzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lOwo+ID4gPiArCWNvbnN0IHN0cnVjdCBkcm1f Y3J0Y19oZWxwZXJfZnVuY3MgKmNydGNfZnVuY3MgPQo+ID4gPiArCQljcnRjLT5iYXNlLmhlbHBl cl9wcml2YXRlOwo+ID4gPiAgCj4gPiA+IC0JaW50ZWxfc3RhdGUtPnZpc2libGUgPSBmYWxzZTsK PiA+ID4gLQlpbnRlbF9wbGFuZS0+Y29tbWl0X3BsYW5lKHBsYW5lLCBpbnRlbF9zdGF0ZSk7Cj4g PiA+ICsJZm9yX2VhY2hfaW50ZWxfcGxhbmUoZGV2LCBwbGFuZSkgewo+ID4gPiArCQljb25zdCBz dHJ1Y3QgZHJtX3BsYW5lX2hlbHBlcl9mdW5jcyAqZnVuY3MgPQo+ID4gPiArCQkJcGxhbmUtPmJh c2UuaGVscGVyX3ByaXZhdGU7Cj4gPiA+ICsJCXN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqc3Rh dGUgPQo+ID4gPiArCQkJdG9faW50ZWxfcGxhbmVfc3RhdGUocGxhbmUtPmJhc2Uuc3RhdGUpOwo+ ID4gPiAgCj4gPiA+IC0JaW50ZWxfcGxhbmVfZGVzdHJveV9zdGF0ZShwbGFuZSwgc3RhdGUpOwo+ ID4gPiArCQlpZiAocGxhbmUtPnBpcGUgIT0gcGlwZSkKPiA+ID4gKwkJCWNvbnRpbnVlOwo+ID4g PiArCj4gPiA+ICsJCWlmIChmdW5jcy0+YXRvbWljX2NoZWNrKCZwbGFuZS0+YmFzZSwgJnN0YXRl LT5iYXNlKSkKPiA+IAo+ID4gTWF5YmUgYWRkIGEgV0FSTl9PTigpIGhlcmU/ICBJJ20gYXNzdW1p bmcgdGhhdCB0aGlzIHNob3VsZG4ndCByZWFsbHkgYmUKPiA+IHBvc3NpYmxlIHNpbmNlIGlmIHRo aXMgZmFpbHMgaXQgbWVhbnMgd2UndmUgYWxyZWFkeSBwcmV2aW91c2x5IGRvbmUgYQo+ID4gY29t bWl0IG9mIGludmFsaWQgc3RhdGUgb24gYSBwcmV2aW91cyBhdG9taWMgdHJhbnNhY3Rpb24uICBC dXQgaWYgaXQKPiA+IGRvZXMgc29tZWhvdyBoYXBwZW4sIHRoZSBXQVJOIHdpbGwgZ2l2ZSB1cyBh IGNsdWUgd2h5IHRoZSBwbGFuZSBjb250ZW50cwo+ID4gc2ltcGx5IGRpZG4ndCBzaG93IHVwLgo+ IAo+IEkgY2FuIHRoaW5rIG9mIG9uZSB3YXkgdG8gbWFrZSBpdCBmYWlsLiBUaGF0IGlzLCBmaXJz dCBzZXQgYSBzbWFsbGVyCj4gbW9kZSB3aXRoIHRoZSBwcmltYXJ5IHBsYW5lIChhbmQgZmIpIGNv bmZpZ3VyZWQgdG8gY292ZXIgdGhhdCBmdWxseSwgYW5kCj4gdGhlbiBzd2l0Y2ggdG8gYSBsYXJn ZXIgbW9kZSB3aXRob3V0IHJlY29uZmlndXJpbmcgdGhlIHByaW1hcnkgcGxhbmUuIElmCj4gdGhl IGhhcmR3YXJlIHJlcXVpcmVzIHRoZSBwcmltYXJ5IHBsYW5lIHRvIGJlIGZ1bGxzY3JlZW4gaXQn bGwgZmFpbC4gQnV0Cj4gdGhhdCBzaG91bGQgYWN0YXVsbHkgbm90IGJlIHBvc3NpYmxlIHVzaW5n IHRoZSBsZWdhY3kgbW9kZXNldCBBUEkgYXMgaXQKPiBhbHdheXMgcmVjb25maWd1cmVzIHRoZSBw cmltYXJ5LCBzbyB3ZSdkIG9ubHkgaGF2ZSB0byB3b3JyeSBhYm91dCB0aGF0Cj4gd2l0aCBmdWxs IGF0b21pYyBtb2Rlc2V0LCBhbmQgZm9yIHRoYXQgd2UgYW55d2F5IG5lZWQgdG8gY2hhbmdlIHRo ZSBjb2RlCj4gdG8gZG8gdGhlIGNoZWNrIHN0dWZmIHVwIGZyb250Lgo+IAo+IFNvIHllYWgsIHdp dGggdGhlIHdheSB0aGluZ3MgYXJlIHRoaXMgc2hvdWxkIG5vdCBiZSBhYmxlIHRvIGZhaWwuIEkn bGwKPiByZXNwaW4gd2l0aCB0aGUgV0FSTi4KCkkgaGF2ZW4ndCBmdWxseSBkdWcgaW50byB0aGUg ZGV0YWlscyBoZXJlLCBidXQgYSBmZXcgcmFuZG9tZSBjb21tZW50czoKLSBXaGlsZSB0cmFuc2l0 aW9uaW5nIHdlJ3JlIGNhbGxpbmcgdGhlIHRyYW5zaXRpb25hbCBwbGFuZSBoZWxwZXJzLCB3aGlj aAogIHNob3VsZCBjYWxsIHRoZSBhdG9taWNfY2hlY2sgc3R1ZmYgZm9yIHVzIG9uIHRoZSBwcmlt YXJ5IHBsYW5lLiBJZiB3ZQogIG5lZWQgdG8gY2FsbCBhdG9taWNfY2hlY2sgb24gb3RoZXIgcGxh bmVzIHRvbyAod2h5PykgdGhlbiBJIHRoaW5rIHRoYXQKICBzaG91bGQgYmUgZG9uZSBhcyBjbG9z ZSBhcyBwb3NzaWJsZSB0byB3aGVyZSB3ZSBkbyB0aGF0IGZvciB0aGUgcHJpbWFyeQogIG9uZS4g U2luY2UgZXZlbnR1YWxseSB3ZSBuZWVkIHRvIHVuYnVyeSB0aGF0IGNhbGwgYWdhaW4uCgotIEkg ZG9uJ3QgbGlrZSBmcm9iYmluZyBzdGF0ZSBvYmplY3RzIHdoaWNoIGFyZSBjb21taXR0ZWQgKGku ZS4gdXBkYXRpbmcKICB2aXNpYmxlIGxpa2UgaGVyZSksIHRoZXkncmUgc3VwcG9zZWQgdG8gYmUg aW52YXJpYW50LiBXaXRoIHByb3BlciBhdG9taWMKICB0aGUgd2F5IHRvIGRlYWwgd2l0aCB0aGF0 IGlzIHRvIGdyYWIgYWxsIHRoZSByZXF1aXJlZCBwbGFuZSBzdGF0ZXMgYW5kCiAgcHV0IHRoZW0g aW50byB0aGUgZHJtX2F0b21pY19zdGF0ZSB1cGRhdGUgc3RydWN0dXJlLgoKLSBNeSBpZGVhIGZv ciByZXNvbHZpbmcgb3VyIGN1cnJlbnQgbmVzdGluZyBpc3N1ZXMgd2l0aAogIGVuYWJsZS9kaXNh YmxlX3BsYW5lcyBmdW5jdGlvbnMgd2FzIHR3byBwYXJ0czogYSkgb3Blbi1jb2RlIGEgaGFyZGNv ZGVkCiAgZGlzYWJsZS1hbGwtcGxhbmVzIGZ1bmN0aW9uIGJ5IGp1c3QgY2FsbGluZyBwbGFuZSBk aXNhYmxlIGNvZGUKICB1bmNvbmRpdGlvbmFsbHkuIElpcmMgdGhlcmUncyBiZWVuIHBhdGNoZXMg b25jZSBzb21ld2hlcmUgdG8gZG8gdGhhdAogIHNwbGl0IGluIGk5MTUgKG1heWJlIEknbSBkcmVh bWluZyksIGJ1dCB0aGlzIHVzZS1jYXNlIGlzIGFsc28gd2h5IEkKICBhZGRlZCB0aGUgYXRvbWlj X3BsYW5lX2Rpc2FibGUgaG9vay4gYikgb24gcmVzdG9yZSB3ZSBqdXN0IGRvIGEgbm9ybWFsCiAg cGxhbmUgY29tbWl0IHdpdGggdGhlIHVuY2hhbmdlZCBwbGFuZSBzdGF0ZXMsIHRoZXkgc2hvdWxk IGFsbCBzdGlsbAogIHdvcmsuCgpidHcgaWYgd2Ugd2lyZSB1cCB0aGUgYXRvbWljX2Rpc2FibGVf cGxhbmUgaG9vayB0aGVuIHdlIGNhbiByaXAgb3V0CmludGVsX3BsYW5lX2F0b21pY191cGRhdGUu IFRoZSAiZG9uJ3QgZGlzYWJsZSB0d2ljZSIgY2hlY2sgaXMgYWxyZWFkeSBkb25lCmJ5IHRoZSBo ZWxwZXJzIGluIHRoYXQgY2FzZS4KCkknbGwgZ3JhYiBzb21lIGNvZmZlZSBhbmQgc2VlIHdoYXQn cyBhbGwgd3Jvbmcgd2l0aCBteSBpZGVhcyBoZXJlIG5vdywgYnV0CnBsZWFzZSBicmluZyBpbiBj cml0aXF1ZSB0b28gOy0pCgpDaGVlcnMsIERhbmllbAotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2Fy ZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KKzQxICgwKSA3OSAzNjUgNTcgNDggLSBodHRw Oi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo=