From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 4/9] drm/i915: Make derived plane state correct after crtc_enable Date: Wed, 11 Mar 2015 12:05:39 +0200 Message-ID: <20150311100539.GO11371@intel.com> References: <1425986129-15547-1-git-send-email-ville.syrjala@linux.intel.com> <1425986129-15547-5-git-send-email-ville.syrjala@linux.intel.com> <20150310170151.GH27526@intel.com> <20150310175713.GJ11371@intel.com> <20150311095229.GZ3800@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 610346E344 for ; Wed, 11 Mar 2015 03:06:06 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20150311095229.GZ3800@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXIgMTEsIDIwMTUgYXQgMTA6NTI6MjlBTSArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUdWUsIE1hciAxMCwgMjAxNSBhdCAwNzo1NzoxM1BNICswMjAwLCBWaWxsZSBT eXJqw6Rsw6Qgd3JvdGU6Cj4gPiBPbiBUdWUsIE1hciAxMCwgMjAxNSBhdCAxMDowMTo1MUFNIC0w NzAwLCBNYXR0IFJvcGVyIHdyb3RlOgo+ID4gPiBPbiBUdWUsIE1hciAxMCwgMjAxNSBhdCAwMTox NToyNFBNICswMjAwLCB2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbSB3cm90ZToKPiA+ID4g PiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ ID4gPiA+IC1zdGF0aWMgdm9pZCBkaXNhYmxlX3BsYW5lX2ludGVybmFsKHN0cnVjdCBkcm1fcGxh bmUgKnBsYW5lKQo+ID4gPiA+ICtzdGF0aWMgdm9pZCBfaW50ZWxfY3J0Y19lbmFibGVfcGxhbmVz KHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+ID4gPiA+ICB7Cj4gPiA+ID4gLQlzdHJ1Y3QgaW50 ZWxfcGxhbmUgKmludGVsX3BsYW5lID0gdG9faW50ZWxfcGxhbmUocGxhbmUpOwo+ID4gPiA+IC0J c3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqc3RhdGUgPQo+ID4gPiA+IC0JCXBsYW5lLT5mdW5jcy0+ YXRvbWljX2R1cGxpY2F0ZV9zdGF0ZShwbGFuZSk7Cj4gPiA+ID4gLQlzdHJ1Y3QgaW50ZWxfcGxh bmVfc3RhdGUgKmludGVsX3N0YXRlID0gdG9faW50ZWxfcGxhbmVfc3RhdGUoc3RhdGUpOwo+ID4g PiA+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNydGMtPmJhc2UuZGV2Owo+ID4gPiA+ICsJ ZW51bSBwaXBlIHBpcGUgPSBjcnRjLT5waXBlOwo+ID4gPiA+ICsJc3RydWN0IGludGVsX3BsYW5l ICpwbGFuZTsKPiA+ID4gPiArCWNvbnN0IHN0cnVjdCBkcm1fY3J0Y19oZWxwZXJfZnVuY3MgKmNy dGNfZnVuY3MgPQo+ID4gPiA+ICsJCWNydGMtPmJhc2UuaGVscGVyX3ByaXZhdGU7Cj4gPiA+ID4g IAo+ID4gPiA+IC0JaW50ZWxfc3RhdGUtPnZpc2libGUgPSBmYWxzZTsKPiA+ID4gPiAtCWludGVs X3BsYW5lLT5jb21taXRfcGxhbmUocGxhbmUsIGludGVsX3N0YXRlKTsKPiA+ID4gPiArCWZvcl9l YWNoX2ludGVsX3BsYW5lKGRldiwgcGxhbmUpIHsKPiA+ID4gPiArCQljb25zdCBzdHJ1Y3QgZHJt X3BsYW5lX2hlbHBlcl9mdW5jcyAqZnVuY3MgPQo+ID4gPiA+ICsJCQlwbGFuZS0+YmFzZS5oZWxw ZXJfcHJpdmF0ZTsKPiA+ID4gPiArCQlzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKnN0YXRlID0K PiA+ID4gPiArCQkJdG9faW50ZWxfcGxhbmVfc3RhdGUocGxhbmUtPmJhc2Uuc3RhdGUpOwo+ID4g PiA+ICAKPiA+ID4gPiAtCWludGVsX3BsYW5lX2Rlc3Ryb3lfc3RhdGUocGxhbmUsIHN0YXRlKTsK PiA+ID4gPiArCQlpZiAocGxhbmUtPnBpcGUgIT0gcGlwZSkKPiA+ID4gPiArCQkJY29udGludWU7 Cj4gPiA+ID4gKwo+ID4gPiA+ICsJCWlmIChmdW5jcy0+YXRvbWljX2NoZWNrKCZwbGFuZS0+YmFz ZSwgJnN0YXRlLT5iYXNlKSkKPiA+ID4gCj4gPiA+IE1heWJlIGFkZCBhIFdBUk5fT04oKSBoZXJl PyAgSSdtIGFzc3VtaW5nIHRoYXQgdGhpcyBzaG91bGRuJ3QgcmVhbGx5IGJlCj4gPiA+IHBvc3Np YmxlIHNpbmNlIGlmIHRoaXMgZmFpbHMgaXQgbWVhbnMgd2UndmUgYWxyZWFkeSBwcmV2aW91c2x5 IGRvbmUgYQo+ID4gPiBjb21taXQgb2YgaW52YWxpZCBzdGF0ZSBvbiBhIHByZXZpb3VzIGF0b21p YyB0cmFuc2FjdGlvbi4gIEJ1dCBpZiBpdAo+ID4gPiBkb2VzIHNvbWVob3cgaGFwcGVuLCB0aGUg V0FSTiB3aWxsIGdpdmUgdXMgYSBjbHVlIHdoeSB0aGUgcGxhbmUgY29udGVudHMKPiA+ID4gc2lt cGx5IGRpZG4ndCBzaG93IHVwLgo+ID4gCj4gPiBJIGNhbiB0aGluayBvZiBvbmUgd2F5IHRvIG1h a2UgaXQgZmFpbC4gVGhhdCBpcywgZmlyc3Qgc2V0IGEgc21hbGxlcgo+ID4gbW9kZSB3aXRoIHRo ZSBwcmltYXJ5IHBsYW5lIChhbmQgZmIpIGNvbmZpZ3VyZWQgdG8gY292ZXIgdGhhdCBmdWxseSwg YW5kCj4gPiB0aGVuIHN3aXRjaCB0byBhIGxhcmdlciBtb2RlIHdpdGhvdXQgcmVjb25maWd1cmlu ZyB0aGUgcHJpbWFyeSBwbGFuZS4gSWYKPiA+IHRoZSBoYXJkd2FyZSByZXF1aXJlcyB0aGUgcHJp bWFyeSBwbGFuZSB0byBiZSBmdWxsc2NyZWVuIGl0J2xsIGZhaWwuIEJ1dAo+ID4gdGhhdCBzaG91 bGQgYWN0YXVsbHkgbm90IGJlIHBvc3NpYmxlIHVzaW5nIHRoZSBsZWdhY3kgbW9kZXNldCBBUEkg YXMgaXQKPiA+IGFsd2F5cyByZWNvbmZpZ3VyZXMgdGhlIHByaW1hcnksIHNvIHdlJ2Qgb25seSBo YXZlIHRvIHdvcnJ5IGFib3V0IHRoYXQKPiA+IHdpdGggZnVsbCBhdG9taWMgbW9kZXNldCwgYW5k IGZvciB0aGF0IHdlIGFueXdheSBuZWVkIHRvIGNoYW5nZSB0aGUgY29kZQo+ID4gdG8gZG8gdGhl IGNoZWNrIHN0dWZmIHVwIGZyb250Lgo+ID4gCj4gPiBTbyB5ZWFoLCB3aXRoIHRoZSB3YXkgdGhp bmdzIGFyZSB0aGlzIHNob3VsZCBub3QgYmUgYWJsZSB0byBmYWlsLiBJJ2xsCj4gPiByZXNwaW4g d2l0aCB0aGUgV0FSTi4KPiAKPiBJIGhhdmVuJ3QgZnVsbHkgZHVnIGludG8gdGhlIGRldGFpbHMg aGVyZSwgYnV0IGEgZmV3IHJhbmRvbWUgY29tbWVudHM6Cj4gLSBXaGlsZSB0cmFuc2l0aW9uaW5n IHdlJ3JlIGNhbGxpbmcgdGhlIHRyYW5zaXRpb25hbCBwbGFuZSBoZWxwZXJzLCB3aGljaAo+ICAg c2hvdWxkIGNhbGwgdGhlIGF0b21pY19jaGVjayBzdHVmZiBmb3IgdXMgb24gdGhlIHByaW1hcnkg cGxhbmUuIElmIHdlCj4gICBuZWVkIHRvIGNhbGwgYXRvbWljX2NoZWNrIG9uIG90aGVyIHBsYW5l cyB0b28gKHdoeT8pCgpCZWNhdXNlIHdlIHdhbnQgdGhlIGRlcml2ZWQgc3RhdGUgdG8gYmUgdXBk YXRlZCB0byBtYXRjaCB0aGUgKHBvdGVudGlhbGx5CmNoYW5nZWQpIGNydGMgY29uZmlnLiBXZSBk byBjYWxsIHRoZSAudXBkYXRlX3BsYW5lKCkgaG9vayBmcm9tIHRoZQptb2Rlc2V0IHBhdGgsIGJ1 dCB0aGF0IGhhcHBlbnMgYXQgYSB0aW1lIHdoZW4gdGhlIHBpcGUgaXMgb2ZmLCBzbyBvdXIKY2xp cHBpbmcgY2FsY3VsYXRpb25zIGVuZCB1cCBzYXlpbmcgdGhlIHBsYW5lIGlzIGludmlzaWJsZS4g SSB0aGluayBmaXhpbmcKdGhhdCB0aGUgcmlnaHQgd2F5IHByZXR0eSBtdWNoIGludm9sdmVzIHRo ZSBhdG9taWMgY29udmVyc2lvbiBvZiB0aGUKbW9kZXNldCBwYXRoLgoKPiAgIHRoZW4gSSB0aGlu ayB0aGF0Cj4gICBzaG91bGQgYmUgZG9uZSBhcyBjbG9zZSBhcyBwb3NzaWJsZSB0byB3aGVyZSB3 ZSBkbyB0aGF0IGZvciB0aGUgcHJpbWFyeQo+ICAgb25lLiBTaW5jZSBldmVudHVhbGx5IHdlIG5l ZWQgdG8gdW5idXJ5IHRoYXQgY2FsbCBhZ2Fpbi4KCldpdGggbXkgcGF0Y2ggX2FsbF8gcGxhbmVz IGdldCB0aGVpciAuYXRvbWljX2NoZWNrKCkgY2FsbGVkIGluIHRoZSBzYW1lCnBsYWNlIChkdXJp bmcgcGxhbmUgZW5hYmxlIHBoYXNlIG9mIC5jcnRjX2VuYWJsZSgpKS4KCj4gCj4gLSBJIGRvbid0 IGxpa2UgZnJvYmJpbmcgc3RhdGUgb2JqZWN0cyB3aGljaCBhcmUgY29tbWl0dGVkIChpLmUuIHVw ZGF0aW5nCj4gICB2aXNpYmxlIGxpa2UgaGVyZSksIHRoZXkncmUgc3VwcG9zZWQgdG8gYmUgaW52 YXJpYW50LiBXaXRoIHByb3BlciBhdG9taWMKPiAgIHRoZSB3YXkgdG8gZGVhbCB3aXRoIHRoYXQg aXMgdG8gZ3JhYiBhbGwgdGhlIHJlcXVpcmVkIHBsYW5lIHN0YXRlcyBhbmQKPiAgIHB1dCB0aGVt IGludG8gdGhlIGRybV9hdG9taWNfc3RhdGUgdXBkYXRlIHN0cnVjdHVyZS4KCldlIHJlYWxseSB3 YW50IHRvIGZyb2IgaXQgc28gdGhhdCB0aGUgZGVyaXZlZCBzdGF0ZSB3aWxsIHJlZmxlY3QKcmVh bGl0eS4gTW9zdCBpbXBvcnRhbnRseSBzdGF0ZS0+dmlzaWJsZSBzaG91bGQgYmUgZmFsc2Ugd2hl bmV2ZXIgdGhlCnBpcGUgaXMgb2ZmLCBvdGhlcndpc2Ugd2UgY2FuJ3QgdHJ1c3Qgc3RhdGUtPnZp c2libGUgYW5kIHdvdWxkIGFsc28gbmVlZApnbyBsb29rIGF0IHRoZSBjcnRjIHN0YXRlIHdoZW5l dmVyIHdlJ3JlIHRyeWluZyB0byBkZWNpZGUgaWYgdGhlIHBsYW5lCmlzIGFjdHVhbGx5IG9uIG9y IG5vdC4KCkFzIGZvciB0aGUgZGlyZWN0IHN0YXRlIGZyb2JiaW5nLCB3ZSBjb3VsZCBtYWtlIGEg Y29weSBJIGd1ZXNzIGFuZCBmcm9iCnRoYXQgaW5zdGVhZCwgYW5kIHRoZW4gY29tbWl0IGl0LiBC dXQgdGhhdCBzZWVtcyBhIGxvdCBvZiB3b3JrIGZvciBubyBnYWluLgoKPiAKPiAtIE15IGlkZWEg Zm9yIHJlc29sdmluZyBvdXIgY3VycmVudCBuZXN0aW5nIGlzc3VlcyB3aXRoCj4gICBlbmFibGUv ZGlzYWJsZV9wbGFuZXMgZnVuY3Rpb25zIHdhcyB0d28gcGFydHM6IGEpIG9wZW4tY29kZSBhIGhh cmRjb2RlZAo+ICAgZGlzYWJsZS1hbGwtcGxhbmVzIGZ1bmN0aW9uIGJ5IGp1c3QgY2FsbGluZyBw bGFuZSBkaXNhYmxlIGNvZGUKPiAgIHVuY29uZGl0aW9uYWxseS4gSWlyYyB0aGVyZSdzIGJlZW4g cGF0Y2hlcyBvbmNlIHNvbWV3aGVyZSB0byBkbyB0aGF0Cj4gICBzcGxpdCBpbiBpOTE1IChtYXli ZSBJJ20gZHJlYW1pbmcpLCBidXQgdGhpcyB1c2UtY2FzZSBpcyBhbHNvIHdoeSBJCj4gICBhZGRl ZCB0aGUgYXRvbWljX3BsYW5lX2Rpc2FibGUgaG9vay4gYikgb24gcmVzdG9yZSB3ZSBqdXN0IGRv IGEgbm9ybWFsCj4gICBwbGFuZSBjb21taXQgd2l0aCB0aGUgdW5jaGFuZ2VkIHBsYW5lIHN0YXRl cywgdGhleSBzaG91bGQgYWxsIHN0aWxsCj4gICB3b3JrLgo+IAo+IGJ0dyBpZiB3ZSB3aXJlIHVw IHRoZSBhdG9taWNfZGlzYWJsZV9wbGFuZSBob29rIHRoZW4gd2UgY2FuIHJpcCBvdXQKPiBpbnRl bF9wbGFuZV9hdG9taWNfdXBkYXRlLiBUaGUgImRvbid0IGRpc2FibGUgdHdpY2UiIGNoZWNrIGlz IGFscmVhZHkgZG9uZQo+IGJ5IHRoZSBoZWxwZXJzIGluIHRoYXQgY2FzZS4KPiAKPiBJJ2xsIGdy YWIgc29tZSBjb2ZmZWUgYW5kIHNlZSB3aGF0J3MgYWxsIHdyb25nIHdpdGggbXkgaWRlYXMgaGVy ZSBub3csIGJ1dAo+IHBsZWFzZSBicmluZyBpbiBjcml0aXF1ZSB0b28gOy0pCj4gCj4gQ2hlZXJz LCBEYW5pZWwKPiAtLSAKPiBEYW5pZWwgVmV0dGVyCj4gU29mdHdhcmUgRW5naW5lZXIsIEludGVs IENvcnBvcmF0aW9uCj4gKzQxICgwKSA3OSAzNjUgNTcgNDggLSBodHRwOi8vYmxvZy5mZndsbC5j aAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK