From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: remove indirection in the PCI ID macros
Date: Wed, 11 Mar 2015 17:08:50 +0100 [thread overview]
Message-ID: <20150311160850.GK3800@phenom.ffwll.local> (raw)
In-Reply-To: <20150203133600.GB25599@strange.ger.corp.intel.com>
On Tue, Feb 03, 2015 at 01:36:00PM +0000, Damien Lespiau wrote:
> On Tue, Feb 03, 2015 at 02:34:05PM +0200, Jani Nikula wrote:
> > Spell all the PCI IDs out to be able to quickly grep for the IDs. No
> > functional changes.
> >
> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >
> > ---
> >
> > I tested this by comparing the results of
> >
> > $ make drivers/gpu/drm/i915/i915_drv.s
> > $ make arch/x86/kernel/early-quirks.s
> >
> > before and after the patch. No change.
>
> I'm sold by the test so:
>
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
Jani just pinged me about this and I agree grepability is nice and bdw is
indeed the odd one out right now. I've added GT1/2 comments so that we
don't just drop that information on the floor and merged it to dinq. Minor
conflict but I think wiggle did the right thing ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-11 16:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 12:34 [PATCH] drm/i915: remove indirection in the PCI ID macros Jani Nikula
2015-02-03 12:39 ` Chris Wilson
2015-02-03 13:05 ` Jani Nikula
2015-02-03 13:14 ` Chris Wilson
2015-02-03 13:36 ` Damien Lespiau
2015-02-03 13:40 ` Chris Wilson
2015-03-11 16:08 ` Daniel Vetter [this message]
2015-02-03 17:51 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150311160850.GK3800@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox