From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: commit 440fd52 drm/mm: Support 4GiB and larger ranges oops on 32bit kernel Date: Mon, 16 Mar 2015 10:06:30 +0100 Message-ID: <20150316090629.GA30817@ulmo.nvidia.com> References: <54FF3532.8080701@winsoft.pl> <20150311081357.GA2296@nuc-i3427.alporthouse.com> <5505DBFC.9080407@winsoft.pl> <20150315193139.GA1112@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1329961440==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Airlie Cc: "intel-gfx@lists.freedesktop.org" , dri-devel , "Deucher, Alexander" , Dave Airlie , Krzysztof Kolasa List-Id: intel-gfx@lists.freedesktop.org --===============1329961440== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="J2SCkAp4GZ/dPZZf" Content-Disposition: inline --J2SCkAp4GZ/dPZZf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 16, 2015 at 09:15:22AM +1000, Dave Airlie wrote: > On 16 March 2015 at 05:31, Chris Wilson wrote: > > On Sun, Mar 15, 2015 at 08:22:36PM +0100, Krzysztof Kolasa wrote: > >> Problem solved and tested: > >> > >> [PATCH] drm/mm: Fix support 4 GiB and larger ranges > >> > >> bad argument if(tmp)... in check_free_hole > >> > >> fix oops: kernel BUG at drivers/gpu/drm/drm_mm.c:305! > >> > >> Signed-off-by: Krzysztof Kolasa > > > > Nice catch! > > Reviewed-by: Chris wilson > > -Chris >=20 > Nice work, that was what I planned on doing today, I've sent to Linus > and already merged for rc4. I was somewhat surprised that this patch got merged. I think Russell had some objections to it (he would've preferred to see it use page-granular allocations and hence avoid the need to switch to u64). But since it's already landed in Linus' tree and this fix in v4.0-rc4 I guess it'd be too much churn to back it out again. Thierry --J2SCkAp4GZ/dPZZf Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVBp0SAAoJEN0jrNd/PrOhV0EQAIB8UGBCuT38ij+Z2FKxbGyK +7W0Lh7blxoL41ZzcbzpCzK74V9e6PD/dOyxGwF+3yBlw5Zf8ti25GERB6vWcVLs DVbVxlSIRbe4fDde6GxEwz+HHki+tJcPw0a7MKmvtFf76vLkQ71BeF8lJgU/p6N2 QJP6rA3QDRZSQDSd/uAbYSvnWpcsaexHudkggXGgCd9XgkLg6vEqhYantbT1wmto wlZGDMuck3HAE6dOnL3fjRrg+CmtfcJ9E92RPpFASDjKDbgqO5oC/6ij/ZQ6G202 L7Gf7LFaLlGZhV7/TNk4GulTL2fm006ZhxVqoSSnPevgHFTj55NJoK2M7j9fLqDC jSYMr3pbGSKkD7cu2+Xx2hAvvnWWje0ETMZFYUYGcOW+v7OtJyTyplkFLC4yUNGH 8ltUQgC5jGjWW78uqUGdhgp6fPwmzrMW7K5z+pD2cZAUbb/n2vBG0vK54LU4UMY7 CxxL4KdN3OrT1CEK2GZL9HTcSXB8D8/jpPxFgwT0XfFayLyEMBX4JSVVQdFX+Ow4 FvS1eta2XwC90LCByq6Y4aLgwwJYSXmHtf2vqvFULhlXwi5qKPXK6m5JpM9sCkBb uE9IY2On2uXjHsCtBuWrtZ+CsW68OKxqVbpOeFqOsfV5HaahDnLzQCbIIEHiZoI4 q1Vg1U2SKrSj3inqnXTV =dUdw -----END PGP SIGNATURE----- --J2SCkAp4GZ/dPZZf-- --===============1329961440== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============1329961440==--