From: Daniel Vetter <daniel@ffwll.ch>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Turn on PIN_GLOBAL in i915_gem_object_ggtt_pin
Date: Wed, 18 Mar 2015 10:05:43 +0100 [thread overview]
Message-ID: <20150318090543.GG31422@phenom.ffwll.local> (raw)
In-Reply-To: <1426606611-10083-1-git-send-email-tvrtko.ursulin@linux.intel.com>
On Tue, Mar 17, 2015 at 03:36:51PM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> This makes the interface consistent to old i915_gem_obj_ggtt_pin.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Ok our naming of gem/vma pin/unpin/bind/unbind functions seems to be a
rather impressive mess now. We have lots of special-cases with devilishly
close names and distinct behaviour. This needs to be cleaned up once
rotated and partial views have landed.
Queued for -next meanwhile, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-18 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 15:36 [PATCH] drm/i915: Turn on PIN_GLOBAL in i915_gem_object_ggtt_pin Tvrtko Ursulin
2015-03-18 9:05 ` Daniel Vetter [this message]
2015-03-18 16:18 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150318090543.GG31422@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox